From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by sourceware.org (Postfix) with ESMTPS id 778983858C74; Wed, 23 Aug 2023 05:15:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 778983858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb30.google.com with SMTP id 3f1490d57ef6-d749f57cb22so3168515276.3; Tue, 22 Aug 2023 22:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692767714; x=1693372514; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PqEmA6BZGM4rm5SakmJrIwds427KNBMXUOtZARPAb5Q=; b=XfTY6umxXBxFKLhW6sjnu8pwJbEDxkrtGsj8cqoRxUWxH8/Ta/xGqrWKEgQqY5QiEu Dy2etlfsYQ3cZ99AztVDHOIowBF1XCJcph0Y4QXJm4J4GU+WF381moywr//ckQaZRGkn yhS5BItibQpPpzhoFCqQR/RNq1DkLB1kFMlcoK8zUq5IAvMPGuTG/HNAxVH0PysYebac 7cjePYOvIzH5itqaJ4LKIcse8Mx81pNTpuIwQ4I7W0FW4HV0ePEh6wZAAXLWsZjZkAGT a+gKTfohZ2ou0nx5qSmC/e2Sz8DDdBEi+MNkVLF0NIHTuO29T8doTwcyZs9FHEUikQEl +v7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692767714; x=1693372514; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PqEmA6BZGM4rm5SakmJrIwds427KNBMXUOtZARPAb5Q=; b=iRlToRgd4cTcvXVsLGhN3adtwt1812RBvvSojBy5Mue55ZPAP5rF1tbbiA6thnbMn/ 9gRuCI5Wp7IwLMx8ZcZ+uz8pYCtB6s5RBzTHEmdHP1A134ansPIsjbgiaKEcGgTMVvIs hXI9oJ120h/ZxeDyRmmV+MDLkmnVSkyGx2mDIYW8y+ighhJ/BCMhseeFXxatErHfU9kT EJpO26QodZJpaemN5QnbHW1QxuYdpcFEHQsX+8UFobOkJOKty7R6fL2ysb89Rm0Kqfyr qL3SWsjhTILVJA60B6TbLlIAhUnKpaCLDmbXb1zBAjmRuO0Vnl/dXOO2CjWTDr+6wC6o q5xw== X-Gm-Message-State: AOJu0YwUeQVqZjDoHLlrgaU2NiJvPTgdUmAZm/fN+TJxJi4HUI3NhodC jjxY8hzVQCeKjYHDxRMM0hnq4AHM0ZWNUfW8S1A= X-Google-Smtp-Source: AGHT+IF0TnXTsUc5Daiza9rnSG1fJ0mi9qetz8RIZXyFa4BjUYsRTTfoTsXSFhP6kwHea0Ax2YoJO+vSCQZ8kMVj0N4= X-Received: by 2002:a5b:b4a:0:b0:d06:2494:ef77 with SMTP id b10-20020a5b0b4a000000b00d062494ef77mr12331971ybr.16.1692767713603; Tue, 22 Aug 2023 22:15:13 -0700 (PDT) MIME-Version: 1.0 References: <20230807211335.701619-1-jwakely@redhat.com> In-Reply-To: From: Hongtao Liu Date: Wed, 23 Aug 2023 13:15:01 +0800 Message-ID: Subject: Re: [committed] i386: Fix grammar typo in diagnostic To: Marek Polacek Cc: Jonathan Wakely , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Aug 23, 2023 at 7:28=E2=80=AFAM Hongtao Liu wr= ote: > > On Tue, Aug 8, 2023 at 5:22=E2=80=AFAM Marek Polacek via Libstdc++ > wrote: > > > > On Mon, Aug 07, 2023 at 10:12:35PM +0100, Jonathan Wakely via Gcc-patch= es wrote: > > > Committed as obvious. > > > > > > Less obvious (to me) is whether it's correct to say "GCC V13" here. I > > > don't think we refer to a version that way anywhere else, do we? > > > > > > Would "since GCC 13.1.0" be better? > > > > x86_field_alignment uses > > > > inform (input_location, "the alignment of %<_Atomic %T%> = " > > "fields changed in %{GCC 11.1%}", > > > > so maybe the below should use %{GCC 13.1%}. "GCC V13" looks unusual > > to me. > %{GCC 13.1%} sounds reasonable. looks like %{ can't be using in const char*, so use % instead. How about: Author: liuhongt Date: Wed Aug 23 07:31:13 2023 +0800 Adjust GCC V13 to GCC 13.1 in diagnotic. gcc/ChangeLog: * config/i386/i386.cc (ix86_invalid_conversion): Adjust GCC V13 to GCC 13.1. diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc index e7822ef6500..88d9d7d537f 100644 --- a/gcc/config/i386/i386.cc +++ b/gcc/config/i386/i386.cc @@ -22899,7 +22899,7 @@ ix86_invalid_conversion (const_tree fromtype, const_tree totype) || (TYPE_MODE (totype) =3D=3D BFmode && TYPE_MODE (fromtype) =3D=3D HImode)) warning (0, "%<__bfloat16%> is redefined from typedef % " - "to real %<__bf16%> since GCC V13, be careful of " + "to real %<__bf16%> since %, be careful of " "implicit conversion between %<__bf16%> and %; " "an explicit bitcast may be needed here"); } > > > > > -- >8 -- > > > > > > gcc/ChangeLog: > > > > > > * config/i386/i386.cc (ix86_invalid_conversion): Fix grammar. > > > --- > > > gcc/config/i386/i386.cc | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc > > > index 50860050049..5d57726e22c 100644 > > > --- a/gcc/config/i386/i386.cc > > > +++ b/gcc/config/i386/i386.cc > > > @@ -22890,7 +22890,7 @@ ix86_invalid_conversion (const_tree fromtype,= const_tree totype) > > > warning (0, "%<__bfloat16%> is redefined from typedef %= " > > > "to real %<__bf16%> since GCC V13, be careful of " > > > "implicit conversion between %<__bf16%> and %;= " > > > - "a explicit bitcast may be needed here"); > > > + "an explicit bitcast may be needed here"); > > > } > > > > > > /* Conversion allowed. */ > > > -- > > > 2.41.0 > > > > > > > Marek > > > > > -- > BR, > Hongtao --=20 BR, Hongtao