From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com [IPv6:2607:f8b0:4864:20::e30]) by sourceware.org (Postfix) with ESMTPS id AA12B3858D20 for ; Fri, 8 Sep 2023 02:15:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA12B3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gwmail.gwu.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gwmail.gwu.edu Received: by mail-vs1-xe30.google.com with SMTP id ada2fe7eead31-44d526f96fcso626201137.1 for ; Thu, 07 Sep 2023 19:15:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gwmail.gwu.edu; s=google; t=1694139358; x=1694744158; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=w0iSf5tDtJbNIt1U/ZSqZ2qpUm1YhL0I5hzMZDfDH7w=; b=eTOU1yhEnj6g+6pSny17OKZFpXqgF9xlWoiGY2tff/fS8v64yIFiwzSLQpcGd3Q1Mi HqNXGAsjLtm3v3qTE+cBwka5X36H4czL9mQaFCUSKrV3ldYtgHYIDGYWn9khNzUG84F+ 59Bibw3hdJwzdto2WPfiXijqSH9R4zx1wO05xFcIzCGY3cnlC04nvp6vgUmWP6DoGBJH A9LIQPMMflrUGqX7RtrG4dI2MfHE4bsXaqOe00hULeNVXy3Sv6mec2XXzY2pCyD+mb3O 9tUpHYIdTGFbM+SXXi8pJHaC51kXIrmQCIqNzuRL7RorZN9ioOXLVEbBope4Qfmc+pDw dQPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694139358; x=1694744158; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w0iSf5tDtJbNIt1U/ZSqZ2qpUm1YhL0I5hzMZDfDH7w=; b=wppT+y8ejtYSXTrL4MOrQUgjs8rg2tNKwcGScdigewmjrMJCps7N6wnz/+jQQut2PX cK8b7kgTqS6HCLzvGwj/FwiG4gt+jg+iL4c3nbLnQ1SUKLBaNjIvcc8KAaUw4+ekHN5J O2EFFTX9kXtGMwCdgU1SBeiRt/Uhg0hbNtxhp7n/PV4T7cs1tt0m7sJqJUXccMLO/dqF frnz2q2DX1SbymxbZYTkmu8gV8NcW4auAGfo8H6FNmQu+if6YhIC2lz/5g8ZBq8Q9Bv/ CMMCGVbgjb657QehLBEMJY8dLko/ulpgH4H1YtNITWL5930NfuwYP/MrcNkn8z99pziw nYUA== X-Gm-Message-State: AOJu0YwO5v4gpxu24wObkRpNJP1ugGxwepWF5zsNfqUAIICXSwUob6El 5MZsdKwWtJqGyFr9L04Z3ajUx65fXfsKYs4+gfA9+A== X-Google-Smtp-Source: AGHT+IEwhkRwOhsNve52QnOFrVJbdVzH+0Pe67gWWZDLpATZPkOYdnSTm8z3ANql/J2X2d8Z86tLH+wJ5QnxkIf+HrM= X-Received: by 2002:a05:6102:2454:b0:44d:42c4:f4c1 with SMTP id g20-20020a056102245400b0044d42c4f4c1mr1325362vss.14.1694139358206; Thu, 07 Sep 2023 19:15:58 -0700 (PDT) MIME-Version: 1.0 References: <20230907133202.1013843-1-jwakely@redhat.com> In-Reply-To: <20230907133202.1013843-1-jwakely@redhat.com> From: Eric Gallager Date: Thu, 7 Sep 2023 22:15:47 -0400 Message-ID: Subject: Re: [PATCH] libstdc++: Reduce output of 'make check' To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Maybe use $(AM_V_at) instead? That would allow it to be controlled by the --enable-silent-rules flag to configure, as well as make V=3D1 vs. make V=3D0 too. On Thu, Sep 7, 2023 at 9:32=E2=80=AFAM Jonathan Wakely via Gcc-patches wrote: > > Any objections to this change? > > -- >8 -- > > This removes the 39 lines of shell commands that get echoed when > starting the testsuite. The fact that near the end of that output it > prints `echo "WARNING: could not find \`runtest'" 1>&2; :;` makes it > look like that warning is actually being shown the the user. > > Suppress echoing the recipe, so that users only see the actual output > from the testsuite, not the makefile recipe as well. > > libstdc++-v3/ChangeLog: > > * testsuite/Makefile.am (check-DEJAGNU): Use @ in recipe. > * testsuite/Makefile.in: Regenerate. > --- > libstdc++-v3/testsuite/Makefile.am | 2 +- > libstdc++-v3/testsuite/Makefile.in | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libstdc++-v3/testsuite/Makefile.am b/libstdc++-v3/testsuite/= Makefile.am > index 7adc5318192..4cee585fd8e 100644 > --- a/libstdc++-v3/testsuite/Makefile.am > +++ b/libstdc++-v3/testsuite/Makefile.am > @@ -117,7 +117,7 @@ $(check_DEJAGNU_normal_targets): check-DEJAGNUnormal%= : normal%/site.exp > > # Run the testsuite in normal mode. > check-DEJAGNU $(check_DEJAGNU_normal_targets): check-DEJAGNU%: site.exp > - $(if $*,@)AR=3D"$(AR)"; export AR; \ > + @$(if $*,@)AR=3D"$(AR)"; export AR; \ > RANLIB=3D"$(RANLIB)"; export RANLIB; \ > if [ -z "$*" ] && [ -n "$(filter -j%, $(MFLAGS))" ]; then \ > rm -rf normal-parallel || true; \ >