From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x932.google.com (mail-ua1-x932.google.com [IPv6:2607:f8b0:4864:20::932]) by sourceware.org (Postfix) with ESMTPS id 6F5493858D1E for ; Fri, 8 Sep 2023 12:15:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F5493858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gwmail.gwu.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gwmail.gwu.edu Received: by mail-ua1-x932.google.com with SMTP id a1e0cc1a2514c-7a52a1e2a59so753982241.0 for ; Fri, 08 Sep 2023 05:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gwmail.gwu.edu; s=google; t=1694175309; x=1694780109; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=x7XJ+yXthmLiWuvomTrOcT8UOEvnJ2ZFwEAAy9LyBMw=; b=SDEQb26rVJT9U+scVoZ6CZ+KasZcRj/V+86Pl/0b0RS7lMtlvQCZOjzONIm3wJBb4a tWWjQn3R2S+UUz9VeH/VieJcRbC8DUjBmkROrBtWChewCsqy/YEX76i//wnBFUO59Cre IdoHYR4TjA+rD423yCns76rpMAT5aWoT6D5SAY/IGYd2yYWenv9zvyG9GiYGF2aI48gV +9iHa/ssFbnMh95xpou3oAiN5ZK15dK86+Um8eInUMX8vOFWO06LbECbPRhQOb5F3yvK dLH9/oeDGzHlEqazk/jlo86puQlFz9/yg0K7ukqZFO7xZqaiPd5oqMoS4m1S3Fum2Rfs BFMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694175309; x=1694780109; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x7XJ+yXthmLiWuvomTrOcT8UOEvnJ2ZFwEAAy9LyBMw=; b=s1ht+kIdhNUc+4Y+a81eo/79X7hRc1yX3DN4RzOtD3Rh1/M91jU/6Y40h62A2lfOty IvzK7PXRlNVBNFD5NHKhjEwhg97vDoLOsT+xITAhUz/S1+hjxI3RDv/DGTS5WTukRHRc P3ejS+IFcuFEpE5ePkfx2GRzSzR77MdDdPPkMBpgahOCy03haaS8UjFIIndjIE3lN+OX SYe1I+Zo48EhQWoZ8r5lMAv64kX+b8rYs3kuDT8nvLG1Zc4WAKtMVZIq7DNp773TW/gw G28K4zAzQyWMP2EDgR9LPPTQf2vKTaJaf0YVWJjyc4iInu8f+CkswCWURQVnS7BnMK+9 w17A== X-Gm-Message-State: AOJu0Yw+NSNi++G0QUnIF2zb4HdfVc3ELLiWhrHY4gnhdVXRqw4+n9LO Km45l2y+6RmB8p2ywPXiJNJxEXZul+OcTjhX5pjAijfIhAZRnAbaG5s= X-Google-Smtp-Source: AGHT+IHJZ8TN5Qe0ulss5LMP09HAVyFk4n9POTFWjiedpftGfGYgKuTbcGA+5x+6v0AZey42H44j1IDmuhCjfLOYVJg= X-Received: by 2002:a05:6102:244b:b0:44e:82c3:5b88 with SMTP id g11-20020a056102244b00b0044e82c35b88mr2531953vss.22.1694175309634; Fri, 08 Sep 2023 05:15:09 -0700 (PDT) MIME-Version: 1.0 References: <20230907133202.1013843-1-jwakely@redhat.com> In-Reply-To: From: Eric Gallager Date: Fri, 8 Sep 2023 08:14:58 -0400 Message-ID: Subject: Re: [PATCH] libstdc++: Reduce output of 'make check' To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Sep 8, 2023 at 6:32=E2=80=AFAM Jonathan Wakely = wrote: > > On Fri, 8 Sept 2023 at 03:16, Eric Gallager wrote: > > > > Maybe use $(AM_V_at) instead? That would allow it to be controlled by > > the --enable-silent-rules flag to configure, as well as make V=3D1 vs. > > make V=3D0 too. > > I see two problems with that. Firstly, nobody uses that configure > option, so the net result would be that these 39 lines are still > printed for everybody. > > Secondly, why would anybody ever want this output? Having it > configurable (and default to noisy) just doesn't seem helpful. > > This is the output I'm talking about: > > make: Entering directory > '/home/jwakely/src/gcc/build/x86_64-pc-linux-gnu/libstdc++-v3/testsuite' > make check-DEJAGNU > make[1]: Entering directory > '/home/jwakely/src/gcc/build/x86_64-pc-linux-gnu/libstdc++-v3/testsuite' > Making a new site.exp file... > AR=3D"ar --plugin /home/jwakely/src/gcc/build/./gcc/liblto_plugin.so"; > export AR; \ > RANLIB=3D"ranlib --plugin > /home/jwakely/src/gcc/build/./gcc/liblto_plugin.so"; export RANLIB; \ > if [ -z "" ] && [ -n "" ]; then \ > rm -rf normal-parallel || true; \ > mkdir normal-parallel; \ > make check-DEJAGNUnormal1 check-DEJAGNUnormal2 check-DEJAGNUnormal3 > check-DEJAGNUnormal4 check-DEJAGNUnormal5 check-DEJAGNUnormal6 > check-DEJAGNUnormal7 c > heck-DEJAGNUnormal8 check-DEJAGNUnormal9 check-DEJAGNUnormal10 > check-DEJAGNUnormal11 check-DEJAGNUnormal12 check-DEJAGNUnormal13 > check-DEJAGNUnormal14 check > -DEJAGNUnormal15 check-DEJAGNUnormal16 check-DEJAGNUnormal17 > check-DEJAGNUnormal18 check-DEJAGNUnormal19 check-DEJAGNUnormal20 > check-DEJAGNUnormal21 check-D > EJAGNUnormal22 check-DEJAGNUnormal23 check-DEJAGNUnormal24 > check-DEJAGNUnormal25 check-DEJAGNUnormal26 check-DEJAGNUnormal27 > check-DEJAGNUnormal28 check-DEJ > AGNUnormal29 check-DEJAGNUnormal30 check-DEJAGNUnormal31 > check-DEJAGNUnormal32 check-DEJAGNUnormal33 check-DEJAGNUnormal34 > check-DEJAGNUnormal35 check-DEJAG > NUnormal36 check-DEJAGNUnormal37 check-DEJAGNUnormal38 > check-DEJAGNUnormal39 check-DEJAGNUnormal40 check-DEJAGNUnormal41 > check-DEJAGNUnormal42 check-DEJAGNU > normal43 check-DEJAGNUnormal44 check-DEJAGNUnormal45 > check-DEJAGNUnormal46 check-DEJAGNUnormal47 check-DEJAGNUnormal48 > check-DEJAGNUnormal49 check-DEJAGNUno > rmal50 check-DEJAGNUnormal51 check-DEJAGNUnormal52 > check-DEJAGNUnormal53 check-DEJAGNUnormal54 check-DEJAGNUnormal55 > check-DEJAGNUnormal56 check-DEJAGNUnorm > al57 check-DEJAGNUnormal58 check-DEJAGNUnormal59 check-DEJAGNUnormal60 > check-DEJAGNUnormal61 check-DEJAGNUnormal62 check-DEJAGNUnormal63 > check-DEJAGNUnormal > 64 check-DEJAGNUnormal65 check-DEJAGNUnormal66 check-DEJAGNUnormal67 > check-DEJAGNUnormal68 check-DEJAGNUnormal69 check-DEJAGNUnormal70 > check-DEJAGNUnormal71 > check-DEJAGNUnormal72 check-DEJAGNUnormal73 check-DEJAGNUnormal74 > check-DEJAGNUnormal75 check-DEJAGNUnormal76 check-DEJAGNUnormal77 > check-DEJAGNUnormal78 c > heck-DEJAGNUnormal79 check-DEJAGNUnormal80 check-DEJAGNUnormal81 > check-DEJAGNUnormal82 check-DEJAGNUnormal83 check-DEJAGNUnormal84 > check-DEJAGNUnormal85 che > ck-DEJAGNUnormal86 check-DEJAGNUnormal87 check-DEJAGNUnormal88 > check-DEJAGNUnormal89 check-DEJAGNUnormal90 check-DEJAGNUnormal91 > check-DEJAGNUnormal92 check > -DEJAGNUnormal93 check-DEJAGNUnormal94 check-DEJAGNUnormal95 > check-DEJAGNUnormal96 check-DEJAGNUnormal97 check-DEJAGNUnormal98 > check-DEJAGNUnormal99 check-D > EJAGNUnormal100 check-DEJAGNUnormal101 check-DEJAGNUnormal102 > check-DEJAGNUnormal103 check-DEJAGNUnormal104 check-DEJAGNUnormal105 > check-DEJAGNUnormal106 ch > eck-DEJAGNUnormal107 check-DEJAGNUnormal108 check-DEJAGNUnormal109 > check-DEJAGNUnormal110 check-DEJAGNUnormal111 check-DEJAGNUnormal112 > check-DEJAGNUnormal1 > 13 check-DEJAGNUnormal114 check-DEJAGNUnormal115 > check-DEJAGNUnormal116 check-DEJAGNUnormal117 check-DEJAGNUnormal118 > check-DEJAGNUnormal119 check-DEJAGNUno > rmal120 check-DEJAGNUnormal121 check-DEJAGNUnormal122 > check-DEJAGNUnormal123 check-DEJAGNUnormal124 check-DEJAGNUnormal125 > check-DEJAGNUnormal126 check-DEJA > GNUnormal127 check-DEJAGNUnormal128; \ > rm -rf normal-parallel || true; \ > for idx in 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 > 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 > 46 47 48 49 50 51 > 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 > 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 > 98 99 100 101 102 > 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 > 120 121 122 123 124 125 126 127 128; do \ > if [ -d normal$idx ]; then \ > mv -f normal$idx/libstdc++.sum normal$idx/libstdc++.sum.sep; \ > mv -f normal$idx/libstdc++.log normal$idx/libstdc++.log.sep; \ > fi; \ > done; \ > /bin/sh /home/jwakely/src/gcc/gcc/libstdc++-v3/testsuite/../../contrib/d= g-extract-results.sh > \ > normal[0-9]*/libstdc++.sum.sep > libstdc++.sum; \ > /bin/sh /home/jwakely/src/gcc/gcc/libstdc++-v3/testsuite/../../contrib/d= g-extract-results.sh > -L \ > normal[0-9]*/libstdc++.log.sep > libstdc++.log; \ > exit 0; \ > fi; \ > srcdir=3D`CDPATH=3D"${ZSH_VERSION+.}:" && cd > /home/jwakely/src/gcc/gcc/libstdc++-v3/testsuite && pwd`; export > srcdir; \ > EXPECT=3Dexpect; export EXPECT; \ > runtest=3D; \ > if [ -z "$runtest" ]; then runtest=3Druntest; fi; \ > tool=3Dlibstdc++; \ > if [ -n "" ]; then \ > if [ -f normal-parallel/finished ]; then rm -rf ""; exit 0; fi; \ > GCC_RUNTEST_PARALLELIZE_DIR=3D`${PWDCMD-pwd}`/normal-parallel; \ > export GCC_RUNTEST_PARALLELIZE_DIR; \ > cd ""; \ > fi; \ > if /bin/sh -c "$runtest --version" > /dev/null 2>&1; then \ > $runtest --tool $tool --srcdir $srcdir \ > ; \ > if [ -n "" ]; then \ > touch $GCC_RUNTEST_PARALLELIZE_DIR/finished; \ > fi; \ > else \ > echo "WARNING: could not find \`runtest'" 1>&2; :;\ > fi > WARNING: Couldn't find the global config file. > dejagnu - timeout default set to 90s > Using /home/jwakely/src/gcc/gcc/libstdc++-v3/testsuite/lib/libstdc++.exp > as tool init file. > Test run by jwakely on Fri Sep 8 11:27:44 2023 > Native configuration is x86_64-pc-linux-gnu > > =3D=3D=3D libstdc++ tests =3D=3D=3D > > > Everything from the AR=3D line to the echo "WARNING" line and the "fi" > after it would be suppressed with this patch. I don't think making it > configurable (and default to still being printed) is useful. > You can change the default by sticking AM_SILENT_RULES([yes]) in configure.ac; see the "Silencing `make`" portion of the automake documentation: https://www.gnu.org/software/automake/manual/html_node/Automake-Silent-Rule= s.html > > > > > > On Thu, Sep 7, 2023 at 9:32=E2=80=AFAM Jonathan Wakely via Gcc-patches > > wrote: > > > > > > Any objections to this change? > > > > > > -- >8 -- > > > > > > This removes the 39 lines of shell commands that get echoed when > > > starting the testsuite. The fact that near the end of that output it > > > prints `echo "WARNING: could not find \`runtest'" 1>&2; :;` makes it > > > look like that warning is actually being shown the the user. > > > > > > Suppress echoing the recipe, so that users only see the actual output > > > from the testsuite, not the makefile recipe as well. > > > > > > libstdc++-v3/ChangeLog: > > > > > > * testsuite/Makefile.am (check-DEJAGNU): Use @ in recipe. > > > * testsuite/Makefile.in: Regenerate. > > > --- > > > libstdc++-v3/testsuite/Makefile.am | 2 +- > > > libstdc++-v3/testsuite/Makefile.in | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/libstdc++-v3/testsuite/Makefile.am b/libstdc++-v3/testsu= ite/Makefile.am > > > index 7adc5318192..4cee585fd8e 100644 > > > --- a/libstdc++-v3/testsuite/Makefile.am > > > +++ b/libstdc++-v3/testsuite/Makefile.am > > > @@ -117,7 +117,7 @@ $(check_DEJAGNU_normal_targets): check-DEJAGNUnor= mal%: normal%/site.exp > > > > > > # Run the testsuite in normal mode. > > > check-DEJAGNU $(check_DEJAGNU_normal_targets): check-DEJAGNU%: site.= exp > > > - $(if $*,@)AR=3D"$(AR)"; export AR; \ > > > + @$(if $*,@)AR=3D"$(AR)"; export AR; \ > > > RANLIB=3D"$(RANLIB)"; export RANLIB; \ > > > if [ -z "$*" ] && [ -n "$(filter -j%, $(MFLAGS))" ]; then \ > > > rm -rf normal-parallel || true; \ > > > > > >