From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id ABC69398A865 for ; Wed, 9 Jun 2021 14:52:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ABC69398A865 Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-558-2WFzx8JLObmSw5Qc1fg5tw-1; Wed, 09 Jun 2021 10:52:41 -0400 X-MC-Unique: 2WFzx8JLObmSw5Qc1fg5tw-1 Received: by mail-il1-f198.google.com with SMTP id z3-20020a92cb830000b02901bb45557893so19546680ilo.18 for ; Wed, 09 Jun 2021 07:52:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8NfEGrpDoFCtQBTPZXO/qqu5f1fiBqVscsH2pVohI38=; b=Gbo+WQfMuwzPvKytZYPdJMMGH/L+VOLcG3rSJuvxCm9o4qJG/D2bIec5tenzAb3YBm EvvWvHPKyYGizvSZuuiw53eBADwyjabDBb+UtOof7YcpaAQU77GozZxPpo4bGYoly1zf MPnxqgFPECl6DwxoVluUF08KbOkMaC9r62I2DiIw4PH0SLjIEjL8tq67jKiDQIhtaIuA uyhSDbNKxXGB5qo7RuLMUEaeIgAryOc8HH6uzmFbrC9QFDyqiAtperm/R3RipTCCgH8T 0VZGONuImd5eY2/pMUKDBNrdDX5/M2CIZt51B1sVFbU4wBAd156H3TtGgjga2//eajjj a/tA== X-Gm-Message-State: AOAM530hnNo+i5n6/E34qCzE3lWqmfFhVziM/qGYmc11u/7z25cBixQJ jJ4cWAwjxwxy1jvHFG4NYNuaS46WqiE+frwc5KiVcWSsw39afkcKPsKrk3g4e2P+s+Wl0o3bC/9 XBTHdDZC+qj1nVJkoXpwVPU+zNhyKOFA= X-Received: by 2002:a05:6638:1029:: with SMTP id n9mr125733jan.48.1623250360921; Wed, 09 Jun 2021 07:52:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeGpdCTGyigay/sypa7S/Rt2JKCR4Qxuqw4kYPokb/teksDgWQ+ugj0A0qsJ0CRSUYEMYNgrMxXxKZnFvKxH4= X-Received: by 2002:a05:6638:1029:: with SMTP id n9mr125717jan.48.1623250360716; Wed, 09 Jun 2021 07:52:40 -0700 (PDT) MIME-Version: 1.0 References: <20210607220207.944400-1-rodgert@appliantology.com> <20210608002843.945023-1-rodgert@appliantology.com> In-Reply-To: From: Thomas Rodgers Date: Wed, 9 Jun 2021 07:52:29 -0700 Message-ID: Subject: Re: [PATCH] libstdc++: Fix Wrong param type in :atomic_ref<_Tp*>::wait [PR100889] To: Christophe Lyon Cc: Jonathan Wakely , gcc Patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2021 14:52:45 -0000 Pretty sure I know this is, I'll work on a fix today. On Wed, Jun 9, 2021 at 7:30 AM Christophe Lyon wrote: > Hi, > > > On Wed, 9 Jun 2021 at 01:05, Thomas Rodgers via Gcc-patches > wrote: > > > > Tested x86_64-pc-linux-gnu, committed to master, backported to > > releases/gcc-11. > > > > On Tue, Jun 8, 2021 at 8:44 AM Jonathan Wakely > wrote: > > > > > On Tue, 8 Jun 2021 at 01:29, Thomas Rodgers wrote: > > > > > >> This time without the repeatred [PRnnnn] in the subject line. > > >> > > >> Fixes libstdc++/100889 > > >> > > > > > > This should be part of the ChangeLog entry instead, preceded by PR so > it > > > updates bugzilla, i.e. > > > > > > > > > > > >> libstdc++-v3/ChangeLog: > > >> > > > > > > PR libstdc++/100889 > > > > > > > > >> * include/bits/atomic_base.h (atomic_ref<_Tp*>::wait): > > >> Change parameter type from _Tp to _Tp*. > > >> * testsuite/29_atomics/atomic_ref/wait_notify.cc: Extend > > >> coverage of types tested. > > >> > > > > > > > > > OK for trunk and gcc-11 with that change, thanks. > > > > > > > > This is causing a regression on old arm targets: > --target arm-none-linux-gnueabi > RUNTESTFLAGS: -march=armv5t > > FAIL: 29_atomics/atomic_ref/wait_notify.cc (test for excess errors) > Excess errors: > /aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-linux-gnueabi/bin/ld: > /ccaaHfBz.o: in function `void > std::__atomic_impl::store(double*, > std::remove_volatile::type, std::memory_order)': > > /aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-linux-gnueabi/gcc3/arm-none-linux-gnueabi/libstdc++-v3/include/bits/atomic_base.h:971: > undefined reference to `__atomic_store_8' > /aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-linux-gnueabi/bin/ld: > /ccaaHfBz.o: in function `std::remove_volatile::type > std::__atomic_impl::load(double const*, std::memory_order)': > > /aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-linux-gnueabi/gcc3/arm-none-linux-gnueabi/libstdc++-v3/include/bits/atomic_base.h:979: > undefined reference to `__atomic_load_8' > /aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-linux-gnueabi/bin/ld: > > /aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-linux-gnueabi/gcc3/arm-none-linux-gnueabi/libstdc++-v3/include/bits/atomic_base.h:979: > undefined reference to `__atomic_load_8' > /aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-linux-gnueabi/bin/ld: > > /aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-linux-gnueabi/gcc3/arm-none-linux-gnueabi/libstdc++-v3/include/bits/atomic_base.h:979: > undefined reference to `__atomic_load_8' > collect2: error: ld returned 1 exit status > > Can you check? > > Thanks > >