Re: Add clang-format for libstdc++

[Thomas Rodgers <trodgers@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2179 bytes --]

I am potentially interested in this, with an additional twist -

Is it possible to get clang-format to enforce the libstdc++ uglification
rules (probably requires a clang-format plugin though)?

The concrete example I am thinking of here is when we adopt something like
the PSTL. It was a substantial manual effort to do the uglification on that
code in the first place, and despite multiple reviews by myself and
jwakely, we still managed to miss some identifiers. To complicate matters,
the upstream also makes ongoing changes while making a best effort to
preserve the uglifcation. They also miss some uglfications. The main
contributors in this case are shipping the PSTL as part of oneTBB and so
don't have the same requirements to 'get it right' as libstdc++, so this
often goes undetected.

I am looking to rebase libstdc++'s PSTL in the near future so I'd be
willing to try something based on clang-format, if it existed, for this
particular purpose (I'm less interested in enforcing the indentation rules
in this case, as I want to preserve the upstream's formatting).

I also think it is potentially useful to have both the uglification and
indentation combined. The case I'm thinking of is something like the <simd>
contribution (or ranges) which are similarly large and need to get the
uglification checks and in those cases, the correct libstdc++ formatting as
part of the adoption process.



On Tue, Feb 7, 2023 at 12:39 PM Dimitrij Mijoski via Libstdc++ <
libstdc++@gcc.gnu.org> wrote:

> Is there interest to add a clang-format file for libstdc++?
>
> The basic idea is to take the existing clang format located at
> contrib/clang-format,
> copy it to contrib/clang-format-libstdc++, and modify it according to
> libstdc++ rules
> https://gcc.gnu.org/onlinedocs/libstdc++/manual/source_code_style.html .
> Similarly to the first clang-format, it will be optional and it will be
> enabled if the developer
> calls the command:
>
> make clang-format
>
> inside the build tree. That will create the symbolic link
> srcdir/libstdc++-v3/.clang-format .
> Alternatively, it can be put directly where it is required without the
> need for the invocation
> of make.
>
>