From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DFECD3858429 for ; Fri, 9 Sep 2022 19:01:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DFECD3858429 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662750083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2js0NGmKQOPrCyS1ZyxOf2s32SA0WggjofNkNxZbpsc=; b=aNFL/W5VyZ1l/zHVR9MkqrQx5z78P37/rZjSOa4ZbySOLMMl7ZtfsyUrfKjzqB0RyjVarm iPVsORFBpymtksVF4GiuIUDVdY5DTd7BBscHhFlvxWgb6Fu0ukACt5/OZimHrRFg2kh5On Tp5bmeXsBeEzn/9N32CG22ESLnoC8uU= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-629-dJSXzhigNwa0NVd_4-2DiA-1; Fri, 09 Sep 2022 15:01:20 -0400 X-MC-Unique: dJSXzhigNwa0NVd_4-2DiA-1 Received: by mail-ot1-f72.google.com with SMTP id r6-20020a05683001c600b00655af6217deso1047991ota.10 for ; Fri, 09 Sep 2022 12:01:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=2js0NGmKQOPrCyS1ZyxOf2s32SA0WggjofNkNxZbpsc=; b=Cgkvnj/wkwkvS+7vJcHK6gPJLt5rgLmap10LmpCa9YlM+2et7iSNIFAvCKIdWw689Z B+3y90CzoV6zSJuv0T+BjLVYwLn8gPJJbAC1RyCMj7BNtV3g3ZE/qAVjGNQg/YilR0UK eNrFL9Ro+oGDm1kA/3M86VggNu75paX2LoFgRoU7yN1lU+FFxr4fqksT8YL+83qdTPl4 84B6IzzBAdEVH9p7l356aVbocwgoEr138EhHemz2MPSGuBp4LxJhXYLPGS22EEfnVAfv ttTwcaqMA0jqu5oZACaJa3e79ehtbQ4eVrOCA5h3JP98ckFPQ9ynuc4IQKQyE7RwYsIE F53Q== X-Gm-Message-State: ACgBeo12R/faCMvJ2DUBwAn1oHrJwOlX1MjCMs4JhC/din4L83zvP2D+ hFOwaSDMGtrsxH842zEmxtgNmLc4GWJfdEHNKQOt4JU/VG+Y6P0+jtSG1rjxbkZgZA3sN9oaya+ N5PJQsx5TlPRBvXhCJ3fq7YwdpnEj5Mw= X-Received: by 2002:a54:4e8d:0:b0:325:988d:afaf with SMTP id c13-20020a544e8d000000b00325988dafafmr4143799oiy.135.1662750079660; Fri, 09 Sep 2022 12:01:19 -0700 (PDT) X-Google-Smtp-Source: AA6agR6yIqX6IO5N8iwX8MxqXmD1KwoKHJrahQk1NNAxqHveUDfQ/4GOwSyTRQ1y4kwDaQyP/onlS8fWNrT1FupXYTs= X-Received: by 2002:a54:4e8d:0:b0:325:988d:afaf with SMTP id c13-20020a544e8d000000b00325988dafafmr4143787oiy.135.1662750079461; Fri, 09 Sep 2022 12:01:19 -0700 (PDT) MIME-Version: 1.0 References: <20210923180837.633173-1-rodgert@appliantology.com> <20210927141031.651313-1-rodgert@appliantology.com> <8657FF75-BB98-4C92-9985-B953D0CA6061@googlemail.com> In-Reply-To: <8657FF75-BB98-4C92-9985-B953D0CA6061@googlemail.com> From: Thomas Rodgers Date: Fri, 9 Sep 2022 12:01:08 -0700 Message-ID: Subject: Re: Patch ping (was Re: [PATCH] libstdc++: Clear padding bits in atomic compare_exchange) To: Iain Sandoe Cc: Rainer Orth , Jonathan Wakely , Jakub Jelinek , "libstdc++" , GCC Patches , Thomas Rodgers X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000d6417405e8432b1e" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000d6417405e8432b1e Content-Type: text/plain; charset="UTF-8" s/__weak/__is_weak/g perhaps? On Fri, Sep 9, 2022 at 11:46 AM Iain Sandoe via Libstdc++ < libstdc++@gcc.gnu.org> wrote: > > > > On 9 Sep 2022, at 19:36, Rainer Orth > wrote: > > > > >> Here's a complete patch that combines the various incremental patches > >> that have been going around. I'm testing this now. > >> > >> Please take a look. > > > > unfortunately, this patch broke macOS bootstrap (seen on > > x86_64-apple-darwin11.4.2): > > > > In file included from > /var/gcc/regression/master/10.7-gcc/build/x86_64-apple-darwin11.4.2/libstdc++-v3/include/bits/shared_ptr_atomic.h:33, > > from > /var/gcc/regression/master/10.7-gcc/build/x86_64-apple-darwin11.4.2/libstdc++-v3/include/memory:78, > > from > /vol/gcc/src/hg/master/darwin/libstdc++-v3/include/precompiled/stdc++.h:82: > > > /var/gcc/regression/master/10.7-gcc/build/x86_64-apple-darwin11.4.2/libstdc++-v3/include/bits/atomic_base.h: > In function 'bool std::__atomic_impl::__compare_exchange(_Tp&, _Val<_Tp>&, > _Val<_Tp>&, bool, std::memory_order, std::memory_order)': > > > /var/gcc/regression/master/10.7-gcc/build/x86_64-apple-darwin11.4.2/libstdc++-v3/include/bits/atomic_base.h:1008:49: > error: expected primary-expression before ',' token > > 1008 | __weak, int(__s), > int(__f))) > > | ^ > > > /var/gcc/regression/master/10.7-gcc/build/x86_64-apple-darwin11.4.2/libstdc++-v3/include/bits/atomic_base.h:1017:50: > error: expected primary-expression before ',' token > > 1017 | __weak, int(__s), > int(__f)); > > | ^ > > > > Darwin gcc predefines __weak= in gcc/config/darwin-c.cc > (darwin_cpp_builtins). > > yes, __weak and __strong are Objective C things (in principle, applicable > to non-Darwin targets > using NeXT runtime - there is at least one such target). > > Iain > > --000000000000d6417405e8432b1e--