From: Thomas Rodgers <trodgers@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: libstdc++: Make atomic<T*>::wait() const [PR102994]
Date: Thu, 9 Dec 2021 18:14:36 -0800 [thread overview]
Message-ID: <CAMmuTO9HkBmUq5No=5JfcorjfsQQimQpZ08-BOVGO9D7siFOug@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4=cP8rfsqDqR9iahCv8EqB34mH2yt4STaoCsY0wYk8nnQ@mail.gmail.com>
Tested uild-x86_64-pc-linux-gnu, pushed to trunk and gcc-11.
On Thu, Nov 25, 2021 at 1:24 PM Jonathan Wakely <jwakely@redhat.com> wrote:
> On Wed, 24 Nov 2021 at 01:27, Thomas Rodgers wrote:
> >
> > const qualification was also missing in the free functions for
> wait/wait_explicit/notify_one/notify_all. Revised patch attached.
>
> Please tweak the whitespace in the new test:
>
> > +test1(const std::atomic<char*> &a, char*p)
>
> The '&' should be on the type not the variable, and there should be a
> space before 'p':
>
> > +test1(const std::atomic<char*>& a, char* p)
>
> OK for trunk and gcc-11 with that tweak, thanks!
>
>
prev parent reply other threads:[~2021-12-10 2:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 21:44 Thomas Rodgers
2021-11-05 21:48 ` Jonathan Wakely
2021-11-05 23:46 ` Jonathan Wakely
2021-11-09 18:09 ` Thomas Rodgers
2021-11-09 19:40 ` Jonathan Wakely
2021-11-24 1:27 ` Thomas Rodgers
2021-11-25 21:24 ` Jonathan Wakely
2021-12-10 2:14 ` Thomas Rodgers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMmuTO9HkBmUq5No=5JfcorjfsQQimQpZ08-BOVGO9D7siFOug@mail.gmail.com' \
--to=trodgers@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).