From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7B98C3858405 for ; Tue, 9 Nov 2021 18:09:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7B98C3858405 Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-432-7b5jd-0ZOOyHZcLOoLUFmQ-1; Tue, 09 Nov 2021 13:09:46 -0500 X-MC-Unique: 7b5jd-0ZOOyHZcLOoLUFmQ-1 Received: by mail-io1-f72.google.com with SMTP id r15-20020a6b600f000000b005dde03edc0cso14990921iog.6 for ; Tue, 09 Nov 2021 10:09:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rUNBM1RLyUba6mM32CP4fYYMRBSI2W+EL6zSDWjBRGc=; b=H2Ey+Ef0FzTj6urUdNAz4SXoqeMwtW7wH65fYa0CGjbVT/eOgE/CXROAyGTWTsf7YC kyX79bQDRZs1xMa0OofIEwygp+bT94I0sOddJZysKDqqXrmdIyn0KZNdZs86a10J9SWJ TI8rffF3wtjXZ2ueQWytjLk6odhPtwXWyGendnIstfvN9noD2OuqjAkJHm99R4bRXKox C0rdVRB2YnOYYL35s2JlM2/XKD12SmKRiwKqm5RulnfnX2UrOhYK7aFdq4CxG1spffCL UNicH+OP9dWbJH48tSPTlhwDLxyOPYql84XZOoAFe1EfABpv5WDeSI8aNpOabQp5ImjE poNw== X-Gm-Message-State: AOAM5330o/54wjshdsNwTuJ9mz2AtrDPy5MKpSw4rlFzmCjVw54RYrwl yaWRGv3Ke6RYU4dpUg82k3YZUF8kYnXfYSCOITfr/9PUL6q7jnjZHADScixKPL1Y4iNsL5Vbd/j hh2tFfFV46UsxCstqCcoxTGuxvEX/kwo= X-Received: by 2002:a05:6e02:1d8a:: with SMTP id h10mr6865379ila.51.1636481385654; Tue, 09 Nov 2021 10:09:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJw2JoGOrC6BcuanBNI8aLAkOsxJpZ1uoIUHBI4egS0WQv8dTD2Wr9Z7z/3lG4IQeo9GzoKCCHY7zeKDHKpGiiI= X-Received: by 2002:a05:6e02:1d8a:: with SMTP id h10mr6865359ila.51.1636481385414; Tue, 09 Nov 2021 10:09:45 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Thomas Rodgers Date: Tue, 9 Nov 2021 10:09:34 -0800 Message-ID: Subject: Re: libstdc++: Make atomic::wait() const [PR102994] To: Jonathan Wakely Cc: Jonathan Wakely , "libstdc++" , gcc Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="000000000000a9024105d05f0313" X-Spam-Status: No, score=-14.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, URI_HEX autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2021 18:09:50 -0000 --000000000000a9024105d05f0313 Content-Type: text/plain; charset="UTF-8" Revised patch attached. On Fri, Nov 5, 2021 at 4:46 PM Jonathan Wakely wrote: > On Fri, 5 Nov 2021 at 21:51, Jonathan Wakely via Libstdc++ > wrote: > > > > OK, thanks. > > Actually, we should really have a test to verify it can be called on a > const object. Please add something when you commit, it can be dumb and > simple, it just needs to verify that it can be called. > > > > > > > > On Fri, 5 Nov 2021 at 21:46, Thomas Rodgers via Libstdc++ < > > libstdc++@gcc.gnu.org> wrote: > > > > > > > > > > --000000000000a9024105d05f0313 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-libstdc-Make-atomic-T-wait-const-PR102994.patch" Content-Disposition: attachment; filename="0001-libstdc-Make-atomic-T-wait-const-PR102994.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kvsepyvn0 RnJvbSA2OTczN2JlN2NkYTUzMjhlYjBmNjdjOTcyNWMzYjY5MWJjYjZjYjJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG9tYXMgUm9kZ2VycyA8cm9kZ2VydEB0d3JvZGdlcnMuY29t PgpEYXRlOiBUdWUsIDkgTm92IDIwMjEgMDk6NDI6NDkgLTA4MDAKU3ViamVjdDogW1BBVENIXSBs aWJzdGRjKys6IE1ha2UgYXRvbWljPFQqPjo6d2FpdCgpIGNvbnN0IFtQUjEwMjk5NF0KClRoaXMg d2FzIGFuIG92ZXJzaWdodCBpbiB0aGUgb3JpZ2luYWwgY29tbWl0IGFkZGluZyB3YWl0L25vdGlm eQp0byBhdG9taWM8VD4uCgpsaWJzdGRjKystdjMvQ2hhbmdlTG9nOgoKCVBSIGxpYnN0ZGMrKy8x MDI5OTQKCSogaW5jbHVkZS9iaXRzL2F0b21pY19iYXNlLmggKF9fYXRvbWljX2Jhc2U8X1BUcCo+ Ojp3YWl0KCkpOgoJQWRkIGNvbnN0IHF1YWxpZmllci4KCSogaW5jbHVkZS9zdGQvYXRvbWljIChh dG9taWM8X1RwKj46OndhaXQoKSk6CglMaWtld2lzZS4KCSogdGVzdHN1aXRlLzI5X2F0b21pY3Mv YXRvbWljL3dhaXRfbm90aWZ5LzEwMjk5NC5jYzoKCU5ldyB0ZXN0LgotLS0KIGxpYnN0ZGMrKy12 My9pbmNsdWRlL2JpdHMvYXRvbWljX2Jhc2UuaCAgICAgICAgICAgICAgIHwgIDIgKy0KIGxpYnN0 ZGMrKy12My9pbmNsdWRlL3N0ZC9hdG9taWMgICAgICAgICAgICAgICAgICAgICAgIHwgIDQgKyst LQogLi4uL3Rlc3RzdWl0ZS8yOV9hdG9taWNzL2F0b21pYy93YWl0X25vdGlmeS8xMDI5OTQuY2Mg fCAxMSArKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAzIGRl bGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGxpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjlf YXRvbWljcy9hdG9taWMvd2FpdF9ub3RpZnkvMTAyOTk0LmNjCgpkaWZmIC0tZ2l0IGEvbGlic3Rk YysrLXYzL2luY2x1ZGUvYml0cy9hdG9taWNfYmFzZS5oIGIvbGlic3RkYysrLXYzL2luY2x1ZGUv Yml0cy9hdG9taWNfYmFzZS5oCmluZGV4IDllMThhYWRhZGFmLi5hMTA0YWRjMWExMCAxMDA2NDQK LS0tIGEvbGlic3RkYysrLXYzL2luY2x1ZGUvYml0cy9hdG9taWNfYmFzZS5oCisrKyBiL2xpYnN0 ZGMrKy12My9pbmNsdWRlL2JpdHMvYXRvbWljX2Jhc2UuaApAQCAtODkzLDcgKzg5Myw3IEBAIF9H TElCQ1hYX0JFR0lOX05BTUVTUEFDRV9WRVJTSU9OCiAjaWYgX19jcHBfbGliX2F0b21pY193YWl0 CiAgICAgICBfR0xJQkNYWF9BTFdBWVNfSU5MSU5FIHZvaWQKICAgICAgIHdhaXQoX19wb2ludGVy X3R5cGUgX19vbGQsCi0JICAgbWVtb3J5X29yZGVyIF9fbSA9IG1lbW9yeV9vcmRlcl9zZXFfY3N0 KSBub2V4Y2VwdAorCSAgIG1lbW9yeV9vcmRlciBfX20gPSBtZW1vcnlfb3JkZXJfc2VxX2NzdCkg Y29uc3Qgbm9leGNlcHQKICAgICAgIHsKIAlzdGQ6Ol9fYXRvbWljX3dhaXRfYWRkcmVzc192KCZf TV9wLCBfX29sZCwKIAkJCQkgICAgIFtfX20sIHRoaXNdCmRpZmYgLS1naXQgYS9saWJzdGRjKyst djMvaW5jbHVkZS9zdGQvYXRvbWljIGIvbGlic3RkYysrLXYzL2luY2x1ZGUvc3RkL2F0b21pYwpp bmRleCA5MzZkZDUwYmExYy4uYzk3MWI3MTJlZjYgMTAwNjQ0Ci0tLSBhL2xpYnN0ZGMrKy12My9p bmNsdWRlL3N0ZC9hdG9taWMKKysrIGIvbGlic3RkYysrLXYzL2luY2x1ZGUvc3RkL2F0b21pYwpA QCAtNjQ2LDkgKzY0Niw5IEBAIF9HTElCQ1hYX0JFR0lOX05BTUVTUEFDRV9WRVJTSU9OCiAJCQkJ CSAgICBfX2NtcGV4Y2hfZmFpbHVyZV9vcmRlcihfX20pKTsKICAgICAgIH0KIAotI2lmIF9fY3Bw X2xpYl9hdG9taWNfd2FpdCAKKyNpZiBfX2NwcF9saWJfYXRvbWljX3dhaXQKICAgICB2b2lkCi0g ICAgd2FpdChfX3BvaW50ZXJfdHlwZSBfX29sZCwgbWVtb3J5X29yZGVyIF9fbSA9IG1lbW9yeV9v cmRlcl9zZXFfY3N0KSBub2V4Y2VwdAorICAgIHdhaXQoX19wb2ludGVyX3R5cGUgX19vbGQsIG1l bW9yeV9vcmRlciBfX20gPSBtZW1vcnlfb3JkZXJfc2VxX2NzdCkgY29uc3Qgbm9leGNlcHQKICAg ICB7IF9NX2Iud2FpdChfX29sZCwgX19tKTsgfQogCiAgICAgLy8gVE9ETyBhZGQgY29uc3Qgdm9s YXRpbGUgb3ZlcmxvYWQKZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjlfYXRv bWljcy9hdG9taWMvd2FpdF9ub3RpZnkvMTAyOTk0LmNjIGIvbGlic3RkYysrLXYzL3Rlc3RzdWl0 ZS8yOV9hdG9taWNzL2F0b21pYy93YWl0X25vdGlmeS8xMDI5OTQuY2MKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmJjODE0YTcwOGFhCi0tLSAvZGV2L251bGwKKysrIGIv bGlic3RkYysrLXYzL3Rlc3RzdWl0ZS8yOV9hdG9taWNzL2F0b21pYy93YWl0X25vdGlmeS8xMDI5 OTQuY2MKQEAgLTAsMCArMSwxMSBAQAorLy8geyBkZy1vcHRpb25zICItc3RkPWdudSsrMjAiIH0K Ky8vIHsgZGctZG8gY29tcGlsZSB7IHRhcmdldCBjKysyMCB9IH0KKy8vIHsgZGctcmVxdWlyZS1n dGhyZWFkcyAiIiB9CisKKyNpbmNsdWRlIDxhdG9taWM+CisKK3ZvaWQKK3Rlc3RfaXQoY29uc3Qg c3RkOjphdG9taWM8Y2hhcio+ICZhLCBjaGFyKnApCit7CisgIGEud2FpdChwKTsKK30KLS0gCjIu MzEuMQoK --000000000000a9024105d05f0313--