From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A4D67398580F for ; Tue, 8 Jun 2021 23:04:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A4D67398580F Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-182-TodhYkMpPFmb0uRVjy7mrQ-1; Tue, 08 Jun 2021 19:04:21 -0400 X-MC-Unique: TodhYkMpPFmb0uRVjy7mrQ-1 Received: by mail-il1-f197.google.com with SMTP id o6-20020a056e0214c6b02901e2d3bfd590so15995784ilk.15 for ; Tue, 08 Jun 2021 16:04:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BNnWaQwOs8ZOVX8e2vMynBC3DNt3f/BxOYYzfdxycpE=; b=VfE7s+Fwe9hJaIqfKAqtEObBKQ8yvVoq3JKovVverUSPA6J7wUTCoaPA6pj+O9dtd6 ZZeYioeNXpwd9krhMu10UeiSj7ENcit1XWCVQWuqleIOY/lAhjQaQu8OZzA4j/uVd8tg 5H00FxYdUpDJVrdFcH+ozLfZ81ZGpx5id6bMBMCF2i0LM4Pj1yo67DdjO/4PA5IENng4 BSZL3zQMDxGzuJdD2yMVW8x2fsa3NWpzmPc6q8u2ry6kFsQDcDfXnC/TQFhahg/sdej4 eoQNwi4pru4kjiXsqOHQhknVlprLyY7c1hiMI5rLxpMBrOmVi1VPuqfuZSODozg+oNLY 3WkA== X-Gm-Message-State: AOAM532U34K0jTBpOPxtrbK1aNXm3BsynLoNp5/iVhHnr5Jjb/+6uLXY HID2a6PuUUv1dXUU4eKB4/kBSB/8Mrmqd3mBbKDUVjoh4yqJeBrBWW5f8Hroajfa9DZ3ik2MXqB VxzY/P/pvxGV/+Ez3AtDduSj89j/10uU= X-Received: by 2002:a92:c7cf:: with SMTP id g15mr8506634ilk.28.1623193461011; Tue, 08 Jun 2021 16:04:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynZRMOrtuxSde6lAjZ4bL2EqbpZWdOodlFkZ1v5i0qHxsZcmFzD2IGNFuqciF/JjCq4nml2p3fLVtr4sLFxqk= X-Received: by 2002:a92:c7cf:: with SMTP id g15mr8506621ilk.28.1623193460838; Tue, 08 Jun 2021 16:04:20 -0700 (PDT) MIME-Version: 1.0 References: <20210604195156.706986-1-rodgert@appliantology.com> In-Reply-To: From: Thomas Rodgers Date: Tue, 8 Jun 2021 16:04:10 -0700 Message-ID: Subject: Re: [PATCH] [libstdc++] Remove unused hasher instance. To: Jonathan Wakely Cc: Thomas Rodgers , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2021 23:04:24 -0000 Tested x86_64-pc-linux-gnu, committed to master, backported to releases/gcc-11. On Fri, Jun 4, 2021 at 1:30 PM Jonathan Wakely wrote: > > > On Fri, 4 Jun 2021 at 20:54, Thomas Rodgers wrote: > >> This is a remnant of poorly executed refactoring. >> > > OK for trunk and gcc-11, thanks. > > > >> libstdc++-v3/ChangeLog: >> >> * include/std/barrier (__tree_barrier::_M_arrive): Remove >> unnecessary hasher instantiation. >> --- >> libstdc++-v3/include/std/barrier | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/libstdc++-v3/include/std/barrier >> b/libstdc++-v3/include/std/barrier >> index fd61fb4f9da..4210e30d1ce 100644 >> --- a/libstdc++-v3/include/std/barrier >> +++ b/libstdc++-v3/include/std/barrier >> @@ -103,7 +103,6 @@ It looks different from literature pseudocode for two >> main reasons: >> static_cast<__barrier_phase_t>(__old_phase_val >> + 2); >> >> size_t __current_expected = _M_expected; >> - std::hash __hasher; >> __current %= ((_M_expected + 1) >> 1); >> >> for (int __round = 0; ; ++__round) >> -- >> 2.26.2 >> >>