From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 6F225384646C; Thu, 4 Apr 2024 16:28:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F225384646C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6F225384646C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712248139; cv=none; b=CwtTxgdsiwRUFZ1czlNX2Ph+4vp485KZ8y/DgVGSaTwvjctI5xIef2bWdaBovv2/qDiM9ywyhdz0KyOr0dx7TqMov9gJNC3Bj35lMFLzuBF1JrmIt3YJfLGPYUEumV7f57sVeJHnXUOuRh9hom7ipgPA1uVP9xw8wqp+KVQ35Bg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712248139; c=relaxed/simple; bh=9fJG7hbaC7XooBLaKsPAgTrPV8+rcs+3vQ/FUh1JO60=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=G006ALZHqzkewDcQHjPvqI/M+31eRpT6iuSfCxVVCbusPt3PI2+sM8sW++UBAtE7F/tO7OxzkQ+SHEXxgZc5H4NX41UY3WMbHeGxJK3hg+5gUQiIBY49oQEkG2bRkUBLFIBuNd8LxW2wgWICRfUJvRpQyE/Xkg9W82JH3MDXYrE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4162bac95d4so4450515e9.2; Thu, 04 Apr 2024 09:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712248135; x=1712852935; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GjgA5SJhoeBKg9Mil4LfYaQNvzdTWutJomig3LNDdd4=; b=HwQmw53Az5d0NXn46E/zhXQU68PnaO0Gxe+C5LgYYAb3NALr7EabmhfCRGfcrTKzYT ki351TAZjqGgxAmWqsKJFjvS9IcO1aCXjQ+zHPx2qY5adbwo939g/FP7K6kt4QKdymog N2y80En6C6EwFQhrcxWyexyIT3myQMzH/tnDd4ndh9IXOVqk+6KAZ16x/ewqCka0KxNk Tkjn397EQMTbZYbspEUGWt17XHjDBfrC4Mev7/cTjWYWBVPORgE465vpR/r41UxNWrUu 2HnJ1nl0S9cmzqtYTbPYpXy0jHav/jHbGYvUgJW82GkDI6IXmXXGLSxxG2m1Ma9JmNHJ M4Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712248135; x=1712852935; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GjgA5SJhoeBKg9Mil4LfYaQNvzdTWutJomig3LNDdd4=; b=FEfxR+dFFo8FDbAJY9C/Hl35jxaeVHLhxnzBRdZvGneml+pxQlNp2HQU0sZmsSKobF dhYaLXliaPKHCc5rbYoGlrfY8km0xRUSAqiJeHj4iCP6cA7zpyYKBmHFnpv8B46uZl4n HxM+cPSw0xvcP5WOcUZc64ykGtG+aDJm+xuhuLtLahZpwYgepM/1JxC07OseWQZVp6UF 6VNWOoFEByqAQX5E+srFRaUM0RXoumJK/FSiiMlquzLQqSjgyr39bRBRmnMBeBzjZgYI N3pCy2HBHeXtBwj1Tx3KUj+lYgU5lL/avR+6cHKYDfuSFIFuUu2msC4S+G0iJQLL8zmB bpsw== X-Forwarded-Encrypted: i=1; AJvYcCWS2TTgLvYB7DovOcdcimPAPQ/Qcnj1x3W7LrIfwVJCM7lm5CwtA43u/ELfQ/81iDm68Y4I/ID2MF+uh49yj/Ax05lMVGDO9A== X-Gm-Message-State: AOJu0YzY5Yr0YixzlbthQerpHT7H/bSatr2AkCAPYc3gM+9n/T6KrJNJ 5MmTxwYfNwlM9tMbzexvwJ1R4CcTz8Fpm3PuKfDQYTvjXrIKwXyqE9OSZbh20NKzPK9t2RTOFgt nOkOm7oOrDtU9M+H2uhsv8Qn7a2s= X-Google-Smtp-Source: AGHT+IFnr26uZaS3TmEkDFzfeo9hDwY2U4+mMZhTK2Fgv1ivx6+AOj/bkW5w4tHZZVNOIFAOjG45fg6/ymPz4ShR82E= X-Received: by 2002:adf:fac6:0:b0:343:68ea:c0a8 with SMTP id a6-20020adffac6000000b0034368eac0a8mr2277271wrs.34.1712248134601; Thu, 04 Apr 2024 09:28:54 -0700 (PDT) MIME-Version: 1.0 References: <20240404153158.313297-1-jwakely@redhat.com> In-Reply-To: <20240404153158.313297-1-jwakely@redhat.com> From: Ulrich Drepper Date: Thu, 4 Apr 2024 18:28:43 +0200 Message-ID: Subject: Re: [PATCH] libstdc++: Fix infinite loop in std::istream::ignore(n, delim) [PR93672] To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Apr 4, 2024 at 5:29=E2=80=AFPM Jonathan Wakely = wrote: > I would appreciate more eyes on this to confirm my conclusions about > negative int_type values, and the proposed fix, make sense. The way something like this is handled in glibc's ctype functions is that both branches are considered. For isXXX(c) whether c is -v or 256-v the same value is returned (except for EOF which is -1). This caused the least number of bad surprises. You could here also perform similar actions.