From: Tim Song <t.canens.cpp@gmail.com>
To: Patrick Palka <ppalka@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Fix access issues in elements_view::_Sentinel [PR100631]
Date: Mon, 17 May 2021 17:20:27 -0500 [thread overview]
Message-ID: <CAPQZVxtRp1ZeYJfB6hy6fAT4+2Ymhx4H8mmpypP8445O89DOxw@mail.gmail.com> (raw)
In-Reply-To: <20210517161736.870316-1-ppalka@redhat.com>
On Mon, May 17, 2021 at 12:21 PM Patrick Palka via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> using _Base = elements_view::_Base<_Const>;
> sentinel_t<_Base> _M_end = sentinel_t<_Base>();
> @@ -3800,7 +3807,7 @@ namespace views::__adaptor
> requires sized_sentinel_for<sentinel_t<_Base>, iterator_t<_Base2>>
> friend constexpr range_difference_t<_Base>
Preexisting, but this one should be _Base2 - we always want to get the
difference type from the iterator being used.
> operator-(const _Sentinel& __x, const _Iterator<_Const2>& __y)
> - { return __x._M_end - __y._M_current; }
> + { return __x._M_distance_from(__y); }
>
next prev parent reply other threads:[~2021-05-17 22:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 16:17 Patrick Palka
2021-05-17 16:49 ` Jonathan Wakely
2021-05-17 22:20 ` Tim Song [this message]
2021-05-18 4:42 ` Patrick Palka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPQZVxtRp1ZeYJfB6hy6fAT4+2Ymhx4H8mmpypP8445O89DOxw@mail.gmail.com \
--to=t.canens.cpp@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).