From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id DC268385801A; Mon, 17 May 2021 22:21:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DC268385801A Received: by mail-ed1-x536.google.com with SMTP id w12so988151edx.1; Mon, 17 May 2021 15:21:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k/Y9eks9u7hP32VUEBI7fsL54E/O7tAE8tWXTxcyZhI=; b=qGfqOnRkMsYjOPuJ1yXp0bSxgv5JW/aR6NtThcgLyAC9CFZt8Rfrk6agvSsR98UhQd GneCdB9I0l1SR3rcYrgj6PZRYTJQH0+WjfJg3t2xA4UiOKBmwP8SNXFiW88tAuwI/gwF jS9ucmFLTfW0x3kzGr6nphtf+bQs8shyBZ8TKXJwm/vXS8RlqHOo4So2IYQ457amdiq7 p4fYtgOGI1T3CI/pvli9RK7Olg8n3c1eXzcz5tMpiPJ1fzDCh3xloANZBIteCak12lnx 8dJi9nRxs2ahkeH3fCWbptsuAlPCHqkX8WAex1lu8dWvkU8Tb+GZmzU106vvP5QOlqaF Fx2A== X-Gm-Message-State: AOAM53038BhUD1bqYC26Mw/cOrwQ2c8AamYOvmietddVZ6YQRZMv9rGj KMCFXdnTiiBuix96cYgRQ/H8epcDqPar9yAAUEw= X-Google-Smtp-Source: ABdhPJyScMw08QivHewo0WKhqsZZMFwFm4NzpZ3vElHTgPpELdjtuEJr8EoEmq1BbY+mJ2gDGEiCKB+BJCFY7QwS2FQ= X-Received: by 2002:a05:6402:34d5:: with SMTP id w21mr2763839edc.38.1621290062007; Mon, 17 May 2021 15:21:02 -0700 (PDT) MIME-Version: 1.0 References: <20210517161736.870316-1-ppalka@redhat.com> In-Reply-To: <20210517161736.870316-1-ppalka@redhat.com> From: Tim Song Date: Mon, 17 May 2021 17:20:27 -0500 Message-ID: Subject: Re: [PATCH] libstdc++: Fix access issues in elements_view::_Sentinel [PR100631] To: Patrick Palka Cc: gcc-patches , "libstdc++" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 May 2021 22:21:08 -0000 On Mon, May 17, 2021 at 12:21 PM Patrick Palka via Gcc-patches wrote: > > using _Base = elements_view::_Base<_Const>; > sentinel_t<_Base> _M_end = sentinel_t<_Base>(); > @@ -3800,7 +3807,7 @@ namespace views::__adaptor > requires sized_sentinel_for, iterator_t<_Base2>> > friend constexpr range_difference_t<_Base> Preexisting, but this one should be _Base2 - we always want to get the difference type from the iterator being used. > operator-(const _Sentinel& __x, const _Iterator<_Const2>& __y) > - { return __x._M_end - __y._M_current; } > + { return __x._M_distance_from(__y); } >