From: Tim Song <t.canens.cpp@gmail.com>
To: Patrick Palka <ppalka@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Avoid hard error in ranges::unique_copy [PR100770]
Date: Wed, 26 May 2021 12:27:27 -0500 [thread overview]
Message-ID: <CAPQZVxuOwjP498ZN8CkYBSGS2pVVdE0E6JuQBoZ0KKV=nqs6OQ@mail.gmail.com> (raw)
In-Reply-To: <20210526164541.1701738-1-ppalka@redhat.com>
I noticed that output_iterator_wrapper still has a (non-void)
value_type. Perhaps we can get better coverage if it doesn't have one?
The existing tests should have caught this case with that change, at least.
On Wed, May 26, 2021 at 12:00 PM Patrick Palka via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> - else if constexpr (input_iterator<_Out>
> - && same_as<iter_value_t<_Iter>, iter_value_t<_Out>>)
> + else if constexpr (requires { requires (input_iterator<_Out>
> + && same_as<iter_value_t<_Iter>,
> + iter_value_t<_Out>>); })
It's arguably cleaner to extract this into a concept which can then
also be used in the constraint.
next prev parent reply other threads:[~2021-05-26 17:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 16:45 Patrick Palka
2021-05-26 17:27 ` Tim Song [this message]
2021-05-26 18:43 ` Patrick Palka
2021-05-26 19:07 ` Tim Song
2021-05-27 13:50 ` Patrick Palka
2021-06-03 11:54 ` Jonathan Wakely
2021-05-26 19:55 ` Jonathan Wakely
2021-05-27 0:38 ` Tim Song
2021-05-26 17:28 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPQZVxuOwjP498ZN8CkYBSGS2pVVdE0E6JuQBoZ0KKV=nqs6OQ@mail.gmail.com' \
--to=t.canens.cpp@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).