From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 61166385E03D for ; Thu, 25 Jan 2024 15:54:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 61166385E03D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 61166385E03D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706198053; cv=none; b=rR3sN/fPdtI3Wo8ATV3srwVmUMaSl3IUUfCDeNO8MgjZ3+1BlxPuGXQnGgl95o0f81dkPz5epNvk6HW5j8j5Tay+st2/RT8pbVGYsBnB3R0IvRy5LrCTMTIpYUa7lO6JGKsL4dxBShECUDgct0ShOa47YxwK8wX9ni5viCHi528= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706198053; c=relaxed/simple; bh=ZfyK76/tTOAZmtkRBEQk1RG9DYNTshrc4VxjwZbrFQc=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=StpMsmmf+fOo1Gij0E8EOavTqKvasiJHNhGHErGSUbDO7QOiNUgzn2+6LIvxe9qhzA57Jas34Aooo1d8Da2Gj6akkzm5wsVfEnu7o30wlMzn07dKnfwO+/RTrVqwUg++B/Re9yJouml4GjE3N8+m2RqRrKZ3dL4comPOc4Z4PSE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a298accc440so758034266b.1 for ; Thu, 25 Jan 2024 07:54:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706198049; x=1706802849; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nL2bCmxQH7kBUxAi7cfIsxDiugTf9gzL6KCfgyeHAFY=; b=PhUNI/frA9JLduNuGKYDNtLR21nza3y+VbxNTUwBQ4nn1Yxs9TBWt+EKpuUxavvbtR R6wZFnQMpqkomcWEfS/nV0fg+BxuwcfLVuMl+MnoCMJ2mr9vfS6c2yUITLIeaZKm03DA wty8q4XLtsQwgLBi7qRvFkJEM0o/dKwG2zzhFMPV3UUiceJKfbleqibLSQdQypflzEOl z9qntOK3i61aE1TJF75w1t4MIgtQjPXyQKc211LuS4pmFTYBxA6sxdaayz9jdr11o2We nNmMULJPu0LMkFjPA/XO9kB5D3x9YuRJqBvtS5x6FVnCUXzu6OOuD5K97Lex5mZv4Nzc f0uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706198049; x=1706802849; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nL2bCmxQH7kBUxAi7cfIsxDiugTf9gzL6KCfgyeHAFY=; b=rsuKRjjx9Ocb4WAId4S8he9t+WO1OtMO8c7e9C/sGCJPdNO7GCBmYisLAO1E3Mv6Xk DY3CnDBeLn2tBaYA/UgR4AFOZcissYSML9JD6Xet0KYddVNzWczFgdO1U/+C0w2v4sfH z3ZvtygbQ0M2oY8qovINbTkvmtzk66bcCvdlVF2H1eJorw7/BKO3m+tz4+ienMIRO9bI AMzJDjmsFb41n0d9r4IU1VteioZ2UugXHjoYEBalSk1DqTgSQKGTsEIN9OSX4GOpl6p4 XdPhqpC+er3IpRmvabmg1EP/C5bji8qGkFkO53NKubBhrWU6/ViAg4ofIyTQw+EEOh54 vS2A== X-Gm-Message-State: AOJu0Yx3+eh0YTJGOPacJjpzSjQ7OJhutUgHecNVQz8x0D70D2Ds2rJS vK3mOVB576wbo6EOD7f7iNPCZuqfXl9TJlfA4hfk9OLP2l9Ch2VIJ+KmfcyEISa1SC07mWwr+VN elWPxeY4q6yu2UC7pnQj7ydLfmApImXmuhZdFQTjIUyEGs76z4b/5vA== X-Google-Smtp-Source: AGHT+IG/gmtAbb+tFz5Iytv2Ss1Yd45pi//mT4RE4eHD/Hxtc7jT7iqMHFse6ZBbJG30At3s1q9ngp/NOLeXHtWiHsQ= X-Received: by 2002:a17:906:2516:b0:a31:2993:9b69 with SMTP id i22-20020a170906251600b00a3129939b69mr1047536ejb.52.1706198048972; Thu, 25 Jan 2024 07:54:08 -0800 (PST) MIME-Version: 1.0 References: <20240124104750.1024129-1-christophe.lyon@linaro.org> In-Reply-To: From: Christophe Lyon Date: Thu, 25 Jan 2024 16:54:00 +0100 Message-ID: Subject: Re: [PATCH] [testsuite] Fix pretty printers regexps for GDB output To: Jonathan Wakely Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, tom@tromey.com Content-Type: multipart/mixed; boundary="000000000000a04812060fc73024" X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000a04812060fc73024 Content-Type: text/plain; charset="UTF-8" On Wed, 24 Jan 2024 at 12:02, Jonathan Wakely wrote: > > On Wed, 24 Jan 2024 at 10:48, Christophe Lyon wrote: > > > > GDB emits end of lines as \r\n, we currently match the reverse \n\r, > > We currently match [\n\r]+ which should match any of \n, \r, \n\r or \r\n > Hmm, right, sorry I had this patch in my tree for quite some time, but wrote the description just now, so I read a bit too quickly. > > > possibly leading to mismatches under racy conditions. > > What do we incorrectly match? Is the problem that a \r\n sequence > might be incompletely printed, due to buffering, and so the regex only > sees (and matches) the \r which then leaves an unwanted \n in the > stream, which then interferes with the next match? I don't understand > why that problem wouldn't just result in a failed match with your new > regex though. > Exactly: READ1 forces read() to return 1 byte at a time, so we leave an unwanted \r in front of a string that should otherwise match the "got" case. > > > > > I noticed this while running the GCC testsuite using the equivalent of > > GDB's READ1 feature [1] which helps detecting bufferization issues. > > > > Adjusting the first regexp to match the right order implied fixing the > > second one, to skip the empty lines. > > At the very least, this part of the description is misleading. The > existing regex matches "the right order" already. The change is to > match *exactly* \r\n instead of any mix of CR and LF characters. > That's not about matching "the right order", it's being more precise > in what we match. > > But I'm still confused about what the failure scenario is and how the > change fixes it. > I followed what the GDB testsuite does (it matches \r\n at the end of many regexps), but in fact it seems it's not needed: it works if I update the "got" regexp like this (ie. accept any number of leading \r or \n): - -re {^(type|\$([0-9]+)) = ([^\n\r]*)[\n\r]+} { + -re {^[\n\r]*(type|\$([0-9]+)) = ([^\n\r]*)[\n\r]+} { and leave the "skipping" regexp as it is currently. Is the new attached version OK? Thanks, Christophe > > > > Tested on aarch64-linux-gnu. > > > > [1] https//github.com/bminor/binutils-gdb/blob/master/gdb/testsuite/README#L269 > > > > 2024-01-24 Christophe Lyon > > > > libstdc++-v3/ > > * testsuite/lib/gdb-test.exp (gdb-test): Fix regexps. > > --- > > libstdc++-v3/testsuite/lib/gdb-test.exp | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libstdc++-v3/testsuite/lib/gdb-test.exp b/libstdc++-v3/testsuite/lib/gdb-test.exp > > index 31206f2fc32..0de8d9ee153 100644 > > --- a/libstdc++-v3/testsuite/lib/gdb-test.exp > > +++ b/libstdc++-v3/testsuite/lib/gdb-test.exp > > @@ -194,7 +194,7 @@ proc gdb-test { marker {selector {}} {load_xmethods 0} } { > > > > set test_counter 0 > > remote_expect target [timeout_value] { > > - -re {^(type|\$([0-9]+)) = ([^\n\r]*)[\n\r]+} { > > + -re {^(type|\$([0-9]+)) = ([^\n\r]*)\r\n} { > > send_log "got: $expect_out(buffer)" > > > > incr test_counter > > @@ -250,7 +250,7 @@ proc gdb-test { marker {selector {}} {load_xmethods 0} } { > > return > > } > > > > - -re {^[^$][^\n\r]*[\n\r]+} { > > + -re {^[\r\n]*[^$][^\n\r]*\r\n} { > > send_log "skipping: $expect_out(buffer)" > > exp_continue > > } > > -- > > 2.34.1 > > > --000000000000a04812060fc73024 Content-Type: text/x-patch; charset="US-ASCII"; name="v2-0001-testsuite-Fix-pretty-printers-regexp-for-GDB-outp.patch" Content-Disposition: attachment; filename="v2-0001-testsuite-Fix-pretty-printers-regexp-for-GDB-outp.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lrte9av30 RnJvbSBlN2NkMDQ3NTE0MTkyMTI4MmQ1YzkwNDRiMjQ1MGFlOGUxOTZlZmM0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RvcGhlIEx5b24gPGNocmlzdG9waGUubHlvbkBsaW5h cm8ub3JnPgpEYXRlOiBUaHUsIDI1IEphbiAyMDI0IDE1OjQzOjU2ICswMDAwClN1YmplY3Q6IFtQ QVRDSCB2Ml0gW3Rlc3RzdWl0ZV0gRml4IHByZXR0eSBwcmludGVycyByZWdleHAgZm9yIEdEQiBv dXRwdXQKCkdEQiBlbWl0cyBlbmQgb2YgbGluZXMgYXMgXHJcbiwgd2UgY3VycmVudGx5IG1hdGNo IGFueSA+MCBudW1iZXIgb2YKZWl0aGVyIFxuIG9yIFxyLCBwb3NzaWJseSBsZWFkaW5nIHRvIG1p c21hdGNoZXMgdW5kZXIgcmFjeSBjb25kaXRpb25zLgoKSSBub3RpY2VkIHRoaXMgd2hpbGUgcnVu bmluZyB0aGUgR0NDIHRlc3RzdWl0ZSB1c2luZyB0aGUgZXF1aXZhbGVudCBvZgpHREIncyBSRUFE MSBmZWF0dXJlIFsxXSB3aGljaCBoZWxwcyBkZXRlY3RpbmcgYnVmZmVyaXphdGlvbiBpc3N1ZXMu CgpXZSB0cnkgdG8gbWF0Y2gKXG4kMSA9IGVtcHR5IHN0ZDo6dHVwbGVccgoKYWdhaW5zdCB7Xih0 eXBlfFwkKFswLTldKykpID0gKFteXG5ccl0qKVtcblxyXSt9IHdoaWNoIGZhaWxzIGJlY2F1c2UK b2YgdGhlIGxlYWRpbmcgXG4gKHdoaWNoIHdhcyBsZWZ0IGluIHRoZSBidWZmZXIgYWZ0ZXIgdGhl IHByZXZpb3VzCiJza2lwcGluZyIgcGF0dGVybiBtYXRjaGVkIHRoZSBwcmVjZWRpbmcgXHIpLgoK VGhpcyBwYXRjaCBhY2NlcHRzIGFueSBudW1iZXIgb2YgbGVhZGluZyBcbiBhbmQvb3IgXHIgaW4g dGhlICJnb3QiIGNsYXVzZS4KCkFsc28gdGFrZSB0aGlzIG9wcG9ydHVuaXR5IHRvIHF1b3RlIFxy IGFuZCBcciBpbiB0aGUgbG9ncywgdG8gbWFrZQpkZWJ1Z2dpbmcgc3VjaCBpc3N1ZXMgZWFzaWVy LgoKVGVzdGVkIG9uIGFhcmNoNjQtbGludXgtZ251LgoKWzFdIGh0dHBzLy9naXRodWIuY29tL2Jt aW5vci9iaW51dGlscy1nZGIvYmxvYi9tYXN0ZXIvZ2RiL3Rlc3RzdWl0ZS9SRUFETUUjTDI2OQoK MjAyNC0wMS0yNCAgQ2hyaXN0b3BoZSBMeW9uICA8Y2hyaXN0b3BoZS5seW9uQGxpbmFyby5vcmc+ CgoJbGlic3RkYysrLXYzLwoJKiB0ZXN0c3VpdGUvbGliL2dkYi10ZXN0LmV4cCAoZ2RiLXRlc3Qp OiBGaXggcmVnZXhwLiAgUXVvdGUKCW5ld2xpbmVzIGluIGxvZ3MuCi0tLQogbGlic3RkYysrLXYz L3Rlc3RzdWl0ZS9saWIvZ2RiLXRlc3QuZXhwIHwgMTIgKysrKysrKysrLS0tCiAxIGZpbGUgY2hh bmdlZCwgOSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpYnN0 ZGMrKy12My90ZXN0c3VpdGUvbGliL2dkYi10ZXN0LmV4cCBiL2xpYnN0ZGMrKy12My90ZXN0c3Vp dGUvbGliL2dkYi10ZXN0LmV4cAppbmRleCAzMTIwNmYyZmMzMi4uMmVjNTU5Njk4M2QgMTAwNjQ0 Ci0tLSBhL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvbGliL2dkYi10ZXN0LmV4cAorKysgYi9saWJz dGRjKystdjMvdGVzdHN1aXRlL2xpYi9nZGItdGVzdC5leHAKQEAgLTE5NCw4ICsxOTQsMTEgQEAg cHJvYyBnZGItdGVzdCB7IG1hcmtlciB7c2VsZWN0b3Ige319IHtsb2FkX3htZXRob2RzIDB9IH0g ewogCiAgICAgc2V0IHRlc3RfY291bnRlciAwCiAgICAgcmVtb3RlX2V4cGVjdCB0YXJnZXQgW3Rp bWVvdXRfdmFsdWVdIHsKLQktcmUge14odHlwZXxcJChbMC05XSspKSA9IChbXlxuXHJdKilbXG5c cl0rfSB7Ci0JICAgIHNlbmRfbG9nICJnb3Q6ICRleHBlY3Rfb3V0KGJ1ZmZlcikiCisJLXJlIHte W1xuXHJdKih0eXBlfFwkKFswLTldKykpID0gKFteXG5ccl0qKVtcblxyXSt9IHsKKwkgICAgIyBF c2NhcGUgbmV3bGluZXMgc28gdGhhdCB3ZSBjYW4gcHJpbnQgdGhlbS4KKwkgICAgc2V0IGVzY2Fw ZWQgW3N0cmluZyBtYXAgeyJcbiIgIlxcbiJ9ICRleHBlY3Rfb3V0KGJ1ZmZlcildCisJICAgIHNl dCBlc2NhcGVkMiBbc3RyaW5nIG1hcCB7IlxyIiAiXFxyIn0gJGVzY2FwZWRdCisJICAgIHNlbmRf bG9nICJnb3Q6ICRlc2NhcGVkMiIKIAogCSAgICBpbmNyIHRlc3RfY291bnRlcgogCSAgICBzZXQg Zmlyc3QgJGV4cGVjdF9vdXQoMyxzdHJpbmcpCkBAIC0yNTEsNyArMjU0LDEwIEBAIHByb2MgZ2Ri LXRlc3QgeyBtYXJrZXIge3NlbGVjdG9yIHt9fSB7bG9hZF94bWV0aG9kcyAwfSB9IHsKIAl9CiAK IAktcmUge15bXiRdW15cblxyXSpbXG5ccl0rfSB7Ci0JICAgIHNlbmRfbG9nICJza2lwcGluZzog JGV4cGVjdF9vdXQoYnVmZmVyKSIKKwkgICAgIyBFc2NhcGUgbmV3bGluZXMgc28gdGhhdCB3ZSBj YW4gcHJpbnQgdGhlbS4KKwkgICAgc2V0IGVzY2FwZWQgW3N0cmluZyBtYXAgeyJcbiIgIlxcbiJ9 ICRleHBlY3Rfb3V0KGJ1ZmZlcildCisJICAgIHNldCBlc2NhcGVkMiBbc3RyaW5nIG1hcCB7Ilxy IiAiXFxyIn0gJGVzY2FwZWRdCisJICAgIHNlbmRfbG9nICJza2lwcGluZzogJGVzY2FwZWQyIgog CSAgICBleHBfY29udGludWUKIAl9CiAKLS0gCjIuMzQuMQoK --000000000000a04812060fc73024--