From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id 58D263858CDB for ; Wed, 4 Oct 2023 18:21:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58D263858CDB Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-oi1-x232.google.com with SMTP id 5614622812f47-3af609c4dfeso88103b6e.1 for ; Wed, 04 Oct 2023 11:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696443678; x=1697048478; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CpnBdKDjGwaZbKeWcphlR34mLOnAd3fcU2pLCPa0dE4=; b=qTjlLGoAguMioFvtA343Bvmuua21MQJbZDuzD066J0TrPZZykSFFpqeuPxkKkag1gg /jkDYmfvlF62ysign0bc4LDv9VZupbHJS1c/p6H7E1nRL3r9zGm6XALy1AzjySrNAQGS iRemufhkwLGQtK3ci8aZB4QwmcHH32gxbT59H/aWNxXvLLGmAjyn1etE4o4FM4QlG9mt fqpLqtbvFf3sObs9CvJaBqoqJ40j27B8M8oQXuGpv4lRE8ARx61t2KXIKjpOwYdj601g hNINVJujMFh/wTC1NGT3rdPtCa7E/BY8DqE8AHIoTwfJsezIBXTRw5Ullm7yxhkhwfsu ckRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696443678; x=1697048478; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CpnBdKDjGwaZbKeWcphlR34mLOnAd3fcU2pLCPa0dE4=; b=dtdEJIWMAWbmXgAEEC8c8174RHLKiAUbV4Eu4iX7rL+3tiNnNTfA2MeCaHCc8W6ZaD wjMUJgKey7UA8nq1ulb1UueqYk9puglCVwv/ozd6TmlwCmfxdSr+tUvSfuXjA/wx9r5S 5bstqexZI3yiX3fQTj5lOygB+kXiyvdCQ/lq9dnf9Y5ztILPe7hLagJQhEIWfgbZS0fR /E4KXDeuddhKEn5OuFdQW+aOPv8F8m4VrcHiuGM4OqNnP1EUO3vky0MP62RbT7/BU2eW vlLYWYZ842za69tkngJu4qCudK7lJtOlCgqB0UizLPJpyihZcMkiqPxsMDHSpsNmjblB 9tyg== X-Gm-Message-State: AOJu0Ywt+rAbDQ1wzAFXZLSz43cyfThG5iAM2WOck7sCM7zsjoMhhnog rNigNHPbsfyV1RHh6eIzlUT+YC39RmIbogC/xtNUaw== X-Google-Smtp-Source: AGHT+IE/yO3MnN85gb7igLIxgpe4/9sJmjqlxLrQLsIB44xjuNlxrAUBzTYGaHWLVJ5QI0OWjF1j50Egz8HwscvPovs= X-Received: by 2002:a05:6808:1aae:b0:3a7:7988:9916 with SMTP id bm46-20020a0568081aae00b003a779889916mr2657301oib.59.1696443678434; Wed, 04 Oct 2023 11:21:18 -0700 (PDT) MIME-Version: 1.0 References: <20230817203213.1131496-1-jwakely@redhat.com> <097e48f1-b915-4d6c-b68e-8ee282bc6de5@redhat.com> In-Reply-To: From: Pranav Kant Date: Wed, 4 Oct 2023 11:21:05 -0700 Message-ID: Subject: Re: [committed] libstdc++: Define std::numeric_limits<_FloatNN> before C++23 To: Jakub Jelinek Cc: Jonathan Wakely , Stephan Bergmann , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="000000000000d5e93e0606e812d1" X-Spam-Status: No, score=-17.5 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,HTML_MESSAGE,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000d5e93e0606e812d1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I have reverted the change upstream ( https://github.com/llvm/llvm-project/commit/7d21086d0ca4a680e96e0f4cd3e2597= ebe027a48 ). On Wed, Oct 4, 2023 at 10:00=E2=80=AFAM Pranav Kant wrote: > I will revert the commit while I work on this. Thanks for the pointers. > > On Wed, Oct 4, 2023 at 9:57=E2=80=AFAM Jakub Jelinek w= rote: > >> On Wed, Oct 04, 2023 at 09:47:34AM -0700, Pranav Kant wrote: >> > Thanks for bringing this to my attention. I am working on a fix. Will >> keep >> > this thread posted. >> > >> > Clang *does* define this macro only when float128 type is available. B= ut >> > the problem seems to be that clang doesn't define _Float128 alias type >> > which is what's being used here. It only defines __float128 type. >> Should be >> > easy to fix. >> >> _Float128 (and other _FloatNN types) are standard C23 and C++23 types, >> they certainly can't be simple aliases to __float128 or other similar >> types. >> In C++ they mangle differently, have significantly different behavior in >> lots of different language details. >> So, you need to implement the https://wg21.link/P1467R9 paper, rather >> than >> doing quick hacks. >> >> Jakub >> >> --000000000000d5e93e0606e812d1--