public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: sotrdg sotrdg <euloanty@live.com>
To: unlvsur unlvsur via Libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] print extended assertion failures to stderr
Date: Thu, 4 Nov 2021 14:17:45 +0000	[thread overview]
Message-ID: <CH2PR02MB6522DDFB04427CD0D4A54BD8B28D9@CH2PR02MB6522.namprd02.prod.outlook.com> (raw)
In-Reply-To: <CACb0b4m7oddSaVMqDG61gDQ_++pC4nrJYRpPE3U6E+QRbyVNQA@mail.gmail.com>

i do have other arguments like no longer use none std compiler specific extensions or allow user to replace that function with linker in some environments.

Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Jonathan Wakely <jwakely@redhat.com>
Sent: Thursday, November 4, 2021 10:01:27 AM
To: sotrdg sotrdg <euloanty@live.com>
Subject: Re: [PATCH] print extended assertion failures to stderr



On Thu, 4 Nov 2021 at 13:59, sotrdg sotrdg wrote:
It reduces one function call

Who cares if aborting the program takes an additional function call?!


and reduces compilation time for each translation unit.

That's a valid argument. As is the fact that __replacement_assert won't get inlined into its callers, keeping them smaller.

But "reduces on function call" seems an absurd thing to care about in this case.


  parent reply	other threads:[~2021-11-04 14:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 13:53 sotrdg sotrdg
2021-11-04 13:54 ` Jonathan Wakely
     [not found]   ` <CH2PR02MB65229EA7D6AA4BCC9515F087B28D9@CH2PR02MB6522.namprd02.prod.outlook.com>
     [not found]     ` <CACb0b4m7oddSaVMqDG61gDQ_++pC4nrJYRpPE3U6E+QRbyVNQA@mail.gmail.com>
2021-11-04 14:17       ` sotrdg sotrdg [this message]
2021-11-04 15:13         ` Jonathan Wakely
  -- strict thread matches above, loose matches on Subject: below --
2021-10-27  8:25 Jay Feldblum
2021-11-04 11:30 ` Jonathan Wakely
2021-11-04 23:44   ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH2PR02MB6522DDFB04427CD0D4A54BD8B28D9@CH2PR02MB6522.namprd02.prod.outlook.com \
    --to=euloanty@live.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).