From: Petr Ovtchenkov <ptr@void-ptr.info>
To: libstdc++@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: [PATCH] Remove CANADIAN, that break compilation for foreign target
Date: Wed, 20 Sep 2017 10:38:00 -0000 [thread overview]
Message-ID: <E1ducOT-0002W3-T8@void-ptr.info> (raw)
Some old ad-hoc (adding -I/usr/include to compiler
flags) break compilation of libstdc++ for foreign
target architecture (due to compiler see includes
of native).
---
libstdc++-v3/acinclude.m4 | 5 -----
libstdc++-v3/configure | 22 ----------------------
libstdc++-v3/configure.ac | 14 --------------
3 files changed, 41 deletions(-)
diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4
index e48cf96..60c93bf 100644
--- a/libstdc++-v3/acinclude.m4
+++ b/libstdc++-v3/acinclude.m4
@@ -734,11 +734,6 @@ AC_DEFUN([GLIBCXX_EXPORT_INCLUDES], [
-I$glibcxx_builddir/include \
-I$glibcxx_srcdir/libsupc++"
- # For Canadian crosses, pick this up too.
- if test $CANADIAN = yes; then
- GLIBCXX_INCLUDES="$GLIBCXX_INCLUDES -I\${includedir}"
- fi
-
# Stuff in the actual top level. Currently only used by libsupc++ to
# get unwind* headers from the libgcc dir.
#TOPLEVEL_INCLUDES='-I$(toplevel_srcdir)/libgcc -I$(toplevel_srcdir)/include'
diff --git a/libstdc++-v3/configure b/libstdc++-v3/configure
index 9bf152a..7839518 100755
--- a/libstdc++-v3/configure
+++ b/libstdc++-v3/configure
@@ -21762,11 +21762,6 @@ done
# Only do link tests if native. Else, hardcode.
if $GLIBCXX_IS_NATIVE; then
- # We can do more elaborate tests that assume a working linker.
- CANADIAN=no
-
-
-
# Check whether --with-gnu-ld was given.
if test "${with_gnu_ld+set}" = set; then :
withval=$with_gnu_ld; test "$withval" = no || with_gnu_ld=yes
@@ -28807,17 +28802,6 @@ else
# When all of that is done, all of this hokey, excessive AC_DEFINE junk for
# crosses can be removed.
- # If Canadian cross, then don't pick up tools from the build directory.
- # Used only in GLIBCXX_EXPORT_INCLUDES.
- if test -n "$with_cross_host" &&
- test x"$build_alias" != x"$with_cross_host" &&
- test x"$build" != x"$target";
- then
- CANADIAN=yes
- else
- CANADIAN=no
- fi
-
# Construct crosses by hand, eliminating bits that need ld...
# GLIBCXX_CHECK_MATH_SUPPORT
@@ -81041,7 +81025,6 @@ CPU_OPT_BITS_RANDOM=config/${cpu_opt_bits_random}
# Determine cross-compile flags and AM_CONDITIONALs.
#AC_SUBST(GLIBCXX_IS_NATIVE)
-#AM_CONDITIONAL(CANADIAN, test $CANADIAN = yes)
if test $is_hosted = yes; then
GLIBCXX_HOSTED_TRUE=
GLIBCXX_HOSTED_FALSE='#'
@@ -81423,11 +81406,6 @@ $as_echo "$gxx_include_dir" >&6; }
-I$glibcxx_builddir/include \
-I$glibcxx_srcdir/libsupc++"
- # For Canadian crosses, pick this up too.
- if test $CANADIAN = yes; then
- GLIBCXX_INCLUDES="$GLIBCXX_INCLUDES -I\${includedir}"
- fi
-
# Stuff in the actual top level. Currently only used by libsupc++ to
# get unwind* headers from the libgcc dir.
#TOPLEVEL_INCLUDES='-I$(toplevel_srcdir)/libgcc -I$(toplevel_srcdir)/include'
diff --git a/libstdc++-v3/configure.ac b/libstdc++-v3/configure.ac
index 9e19e99..3a8e26d 100644
--- a/libstdc++-v3/configure.ac
+++ b/libstdc++-v3/configure.ac
@@ -243,8 +243,6 @@ wchar.h wctype.h])
if $GLIBCXX_IS_NATIVE; then
# We can do more elaborate tests that assume a working linker.
- CANADIAN=no
-
GLIBCXX_CHECK_LINKER_FEATURES
GLIBCXX_CHECK_MATH_SUPPORT
GLIBCXX_CHECK_STDLIB_SUPPORT
@@ -276,17 +274,6 @@ else
# When all of that is done, all of this hokey, excessive AC_DEFINE junk for
# crosses can be removed.
- # If Canadian cross, then don't pick up tools from the build directory.
- # Used only in GLIBCXX_EXPORT_INCLUDES.
- if test -n "$with_cross_host" &&
- test x"$build_alias" != x"$with_cross_host" &&
- test x"$build" != x"$target";
- then
- CANADIAN=yes
- else
- CANADIAN=no
- fi
-
# Construct crosses by hand, eliminating bits that need ld...
# GLIBCXX_CHECK_MATH_SUPPORT
@@ -480,7 +467,6 @@ AC_SUBST(CPU_OPT_BITS_RANDOM)
# Determine cross-compile flags and AM_CONDITIONALs.
#AC_SUBST(GLIBCXX_IS_NATIVE)
-#AM_CONDITIONAL(CANADIAN, test $CANADIAN = yes)
GLIBCXX_EVALUATE_CONDITIONALS
AC_CACHE_SAVE
--
2.10.1
next reply other threads:[~2017-09-20 10:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 10:38 Petr Ovtchenkov [this message]
2017-09-20 10:45 ` Petr Ovtchenkov
2017-11-16 17:55 ` [PING] " Petr Ovtchenkov
2017-12-19 8:37 ` [PING^2] " Petr Ovtchenkov
2018-01-30 7:19 ` [PING^3] " Petr Ovtchenkov
2018-01-30 12:55 ` Jonathan Wakely
2018-01-30 18:36 ` Petr Ovtchenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1ducOT-0002W3-T8@void-ptr.info \
--to=ptr@void-ptr.info \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).