From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smarthost2.atos.net (smtppost.atos.net [193.56.114.177]) by sourceware.org (Postfix) with ESMTPS id 6428E385783D; Wed, 13 Jan 2021 12:24:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6428E385783D IronPort-SDR: ngP51NpqTF/Bs72W780b/SKBh5gM4S4Eou25zKrrcwIJY4Z8Wz5q+o6suN9TM2ADxoecwWQqzT SlStiTXWD+64buGdNs8DxSHHgnAxXxzOuGrGLBit3cdJhnlHxj2L6VwKNo0YGljFq8XlnVLGzh Lpnkff2x1LTUpppThd6xZ2gY8JI3H/rDHZ2BfwvXdBVDmyIctL99sifAi08p8YY+aobq2gzvQ9 dLBgXQguIzFFjj4a7hXAnQR5KIYhs8ZCReeTXeROSE3gi0guwd1YAL3xtNRhKt/O4/ab7LWSG6 ubJFzBFLN0VSYHIDcFfwasKH X-IronPort-AV: E=Sophos;i="5.79,344,1602540000"; d="scan'208,217";a="149095246" X-MGA-submission: =?us-ascii?q?MDHmJEzJe7+Yrg50HkVLsYSrce+g1Q5X6EbDuI?= =?us-ascii?q?FRfjKD2aOL9nN1/4mvDm6uN9jC86omO71sRo9pEJYrav4v6Ybwy03q+5?= =?us-ascii?q?pDmx7ugIfwYZ+9lkRABUQMcWLGOkZwkWr/lOZNWHr8Zm9uAeJ326LPWu?= =?us-ascii?q?lX?= Received: from unknown (HELO GITEXCPRDMB21.ww931.my-it-solutions.net) ([10.89.29.131]) by smarthost2.atos.net with ESMTP/TLS/AES256-GCM-SHA384; 13 Jan 2021 13:23:41 +0100 Received: from GITEXCPRDMB21.ww931.my-it-solutions.net (10.89.29.131) by GITEXCPRDMB21.ww931.my-it-solutions.net (10.89.29.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Wed, 13 Jan 2021 13:23:40 +0100 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (172.16.214.170) by GITEXCPRDMB21.ww931.my-it-solutions.net (10.89.29.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4 via Frontend Transport; Wed, 13 Jan 2021 13:23:40 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jCg42YQsAll/3bdnAFuVdgB4w8b49hL1/jZCJXpRgrm4+UcIy+2UInsc457PTu0g/JCAV1Y5YY9dfTRj21posocVeHjLQq1GgOCEIv6AVNMHs7RSTo6f+1DGARFgmVyEfq9KyAlWMh0q8cbQXwOXn3kgcbmfynGx4+Zmxe7Y+DnIBZwrqeIec1/YfVlWXG6BgwMXTwMQQp4FyepIJsLk/jNMPSvoEvuer0TEdh9Mzt/RWRVLtgW8dbZSBxS5xd1IheXQyjhUyg2/zJJGk1+MiqdxNYNVxittxamxq+V520VGcTjFWGmR6AdmGkBE8rfVCnufqX4yIs4xMwhiedUOvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8iq/NDpY50YiW5Qd9/iUf+vFPI86dfDJHLozqu58QfA=; b=fyTircNC6iW5osunA7881C+1OHF3LZ40fxrcyVWCyF8Pnj+ENB1meLwbjKnbMOPB9boaq1kUc76vJcmiupefHLnKboofjIMs8QMo7yqCXfNRJPzwqS4sC7yltV3C/lnuqnGQpoAZMR+XZu0FEtlaTUCZxDmPswceuOQ6w5CWf5Mfq63O1cNbGHV84JyRXaTRGWN2H/rH71fpRkcTDHO0aFhFzk1qZOkOcn1uWzn8igsbzDe4NCpyKxgNYySSR5Acn4pp7q/6kmNU5LD5JzK9LSoXM0Cg43fkzlO56PLV0X2uaCy+yy20Hdf5hmiHE+gfYix8I1GjqDDWd+fFZnr3ZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=atos.net; dmarc=pass action=none header.from=atos.net; dkim=pass header.d=atos.net; arc=none Received: from PA4PR02MB6686.eurprd02.prod.outlook.com (2603:10a6:102:ff::14) by PA4PR02MB6720.eurprd02.prod.outlook.com (2603:10a6:102:fc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.10; Wed, 13 Jan 2021 12:23:39 +0000 Received: from PA4PR02MB6686.eurprd02.prod.outlook.com ([fe80::e06c:aa84:a21d:6932]) by PA4PR02MB6686.eurprd02.prod.outlook.com ([fe80::e06c:aa84:a21d:6932%7]) with mapi id 15.20.3763.010; Wed, 13 Jan 2021 12:23:39 +0000 From: "CHIGOT, CLEMENT" To: Rainer Orth , David Edelsohn CC: Jonathan Wakely , "libstdc++@gcc.gnu.org" , David Edelsohn via Gcc-patches Subject: Re: [PATCH] libstdc++: implement locale support for AIX Thread-Topic: [PATCH] libstdc++: implement locale support for AIX Thread-Index: AQHW5/cse5cUzOlFpUGzG3vP4ZkwbKoiheqAgAAI90CAAAGAAIAAAJC4gABu9YCAARiZb4AABceAgAAHyTOAAB5/x4AAALUAgAAlmBiAAQvegIAAApjf Date: Wed, 13 Jan 2021 12:23:39 +0000 Message-ID: References: <20210111154058.GB21410@redhat.com> <20210112152505.GE21410@redhat.com> , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_Enabled=True; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_SiteId=33440fc6-b7c7-412c-bb73-0e70b0198d5a; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_SetDate=2021-01-13T12:23:39.235Z; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_Name=Atos For Internal Use - All Employees; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_ContentBits=0; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_Method=Standard; x-originating-ip: [165.225.77.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ce47729f-68c6-41ab-e58a-08d8b7be0f12 x-ms-traffictypediagnostic: PA4PR02MB6720: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UDxMMH6NJWI/MrZpVidBu90CREewfFGTYGCiYflXtG3L8egB6qMfsKzgcsZcmh6L9aT/qpw+hsEGT2mCfQWuY5fStkLHjuf0IMSxB4c/IiWZiqaSxbFd5I1XdTIlPEGTSXb9dvk7JrUG0isbBdlZpULb6sZK+cDggfbvrTHwvUNd0WfleQ+sUR0nAlobp+z1h4PnMTOIYAuF1mXH8flPh6yFoWDT6cEFPSTHeWKqpZPzzEXu/NMgz18hHrySoWJBPDtpwbZOD+EqLG+VN/EiWQ1cbM70QTIdS2R64sbJy5p80SN0blKHcAPp2/XPl0US3zpwJ6OnEUsCWEz4+ZqMbCMW07CneUPIxRUwM+0BDXSdkSqoEbt1nt4UqioZA16X3x7HyLPcsYXorOFWa6ye/Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR02MB6686.eurprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(396003)(366004)(39860400002)(136003)(6506007)(76116006)(8936002)(19627405001)(55236004)(316002)(2906002)(26005)(186003)(8676002)(52536014)(66476007)(66946007)(33656002)(64756008)(66574015)(86362001)(66556008)(7696005)(66446008)(9686003)(55016002)(478600001)(5660300002)(54906003)(83380400001)(110136005)(4326008)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?04CWNsBS9ZYmDlhfD0ufpLxaFZ/ZZ05yDCr36gwzZY5RUfgtr8i+O5ACPv?= =?iso-8859-1?Q?k1aKHwA6YUaQQlzhaY3o/EyYkU4lr3VdtGpIB4vW9naKS6EleL+xmhES+s?= =?iso-8859-1?Q?I29Pgjh9oxtU/e8DBay6hVu7ZGKqc3nnkjeLN3dneZm7BCNM/hu1X95w4/?= =?iso-8859-1?Q?S/i3KEUxxUL00oncf2BIZn6M59RZswRhsOQ4fhAdfFz7d7FzIe6IP4T9kW?= =?iso-8859-1?Q?f01+zBWncZjpwr7bMbkoJ+oDUPFGiGSe8CzUve3iu6dGfoR6Q5maQtUHm2?= =?iso-8859-1?Q?RZqDjRTYeyWcIhulccS0hquYPsTQVzTrHKxIz7o86nnnmG48W6sHut+MLK?= =?iso-8859-1?Q?0WMBkW7yMaw2ekPgKzm5Xu55Qe9ZzwdQLZ/TM1YRIERuJH+qwNr0VCd+SJ?= =?iso-8859-1?Q?9r45Cx5T4soSUNIBOIwbNh0Hm5j7xQhX8qtDMVDWQrZy3wj/2smVtppiUP?= =?iso-8859-1?Q?lcQCnjvsoZUfInXG5TL4A5s+daMPBDv20JF8jz2xbpnYquULEz1VMofjgo?= =?iso-8859-1?Q?l20pOgx73iTjSETZK7du1+JdNZSmpCFCzbkeULqJ0y9SVeAV6FX6IBp4kX?= =?iso-8859-1?Q?pt9g2b/l7HvV5VoVdEZ2DFCgggpSF1+H2f3PRm1esRLdol3Fhudc7Q8P7i?= =?iso-8859-1?Q?ccfyP7hYJ21sTowXc+VLiuTs7bvrsLp7zzNsKpTF8yiHLwWf0VNc7WvOBO?= =?iso-8859-1?Q?mz4MSfey2pKSEJOj5+ckl4s75+/JyDbXzmhVL9ry2CfXUipVgVgL1Wm4DR?= =?iso-8859-1?Q?1qz3FUkO2rKJCasH3YHc9Xt0ggLvwS+QOfvbFyUi2tkVBzJyJa6X5qc5Rc?= =?iso-8859-1?Q?X2sXc9cJyIC6DlDkptKlfVDylwORga7yWkRN4PCLdvHcveAcsTqJk6umJE?= =?iso-8859-1?Q?9wChZfdfY1lRFArihvvgSWwmQ6XC+ofFEwoebJ91FwMliLwpLOC5GTCJ1A?= =?iso-8859-1?Q?zuKyxWOhRpegr6rco1kgQ8TitT/yfPWASHFX1S63u3vcwZUxa9/35X1gU0?= =?iso-8859-1?Q?ogaElAkxBmhQVyELo=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR02MB6686.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce47729f-68c6-41ab-e58a-08d8b7be0f12 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2021 12:23:39.6435 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 33440fc6-b7c7-412c-bb73-0e70b0198d5a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MP/mCO1THEAVkVanF8zgYQkBpOXLooFCuIrEV+LF7gLo9itLgpLkPQt4xl97fvcudvHIa969tfcX0W5vdLXOZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR02MB6720 X-OriginatorOrg: atos.net X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2021 12:24:34 -0000 Hi Rainer, > This alone makes the patch inacceptable in its present form: breaking > the libstdc++ ABI is a non-starter. However, I suspect this can be > avoided somehow. Thanks for having tried and I agree the patch isn't ready at all. I've just wanted to see how behave on other systems and it seems that it might not work as is. However, is the C++ ABI not standard ? I don't have this test failing on AIX, AFAIK. Strange. > +FAIL: 22_locale/classification/isblank.cc execution test > > /vol/gcc/src/hg/master/solaris/libstdc++-v3/testsuite/22_locale/classific= ation/isblank.cc:38: void test02(): Assertion 'std::isblank(L' ', std::loca= le::classic())' failed. > > It turns out that this is caused by ieee_1003.1-2008/ctype_members.cc > using __bitmapsize =3D 11 in a couple of places, unlike the generic > version which uses 15 to accomodate variations in character > classifications. 11 is the correct value on AIX and maybe also in Dragnofly/FreeBSD, based on the value of Dragonfly model. However, big endian vs little endian needs to be handled. I haven't fix that part on the current patch I guess. (when bitmapsize =3D 15, there is no difference, endianness doesn't matter). However, it might be simpler to set bitmapsize =3D 15 for everyone, instead of having some defines for that. Maybe. > However, there are many more which I haven't even started to > investigate. I suspect there's one (or a few) reasons immediately > obvious to someone familiar with the code. Thanks for the list. I'll check if there is some common with AIX. But wait until I push the new patch to start studying them. It'll have the correct #ifdef based on configure and I'll try it on Linux. Thus, it should be far better. Thanks, Cl=E9ment