From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smarthost1.atos.net (smtppost.atos.net [193.56.114.176]) by sourceware.org (Postfix) with ESMTPS id 690033893646; Wed, 27 Jan 2021 14:45:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 690033893646 X-IronPort-AV: E=Sophos;i="5.79,379,1602540000"; d="scan'208";a="207696541" X-MGA-submission: =?us-ascii?q?MDFrUzSiFJxJU/MMRPaT7yxUbd9X7YDEXetoLP?= =?us-ascii?q?sUWfCwW24wQ6MmZiNEAJRMh8C1iQQaR+IXJlydxAMIRPCCwTfb2fRSEK?= =?us-ascii?q?Z5xgOSfmxKRDZNV/wMiu29615u2VUJfaxNBu/aVJ4WYJMDT0kyUcL/+Z?= =?us-ascii?q?fy?= Received: from mail.sis.atos.net (HELO GITEXCPRDMB23.ww931.my-it-solutions.net) ([10.89.29.133]) by smarthost1.atos.net with ESMTP/TLS/AES256-GCM-SHA384; 27 Jan 2021 15:44:51 +0100 Received: from GITEXCPRDMB22.ww931.my-it-solutions.net (10.89.29.132) by GITEXCPRDMB23.ww931.my-it-solutions.net (10.89.29.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Wed, 27 Jan 2021 15:44:51 +0100 Received: from FRA01-MR2-obe.outbound.protection.outlook.com (172.16.214.170) by GITEXCPRDMB22.ww931.my-it-solutions.net (10.89.29.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4 via Frontend Transport; Wed, 27 Jan 2021 15:44:51 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iYTp4s53idxNfnmzEY73YjmaU6DWIwlqmMHY3/BbJtX3PwLtKavmEtJQCtCP7n1GeA7qFZZQ2mhDWZlLZt3sSYYRI7hzHhBE0bZvHUoiw5DwlB6NiyWUEi/x6fMtgJ2DNnV6NxkbTBHiemJc6AvhvXC5A3rnbd1xG9AEnE0YFH7VmfWX3jlx4mRppbX66qDgu+UJm1Zr33h2w6153+VESWNnkpCsosAnL6Pn/EAGwNXBGYs/R06d/x7NO5einxoyRWbkK83ksOo4BCNcBhI+Dit4HVJB4LIVI87SisqJl0Eq/R+xoLq1WbvJgal5XHotlR2DK6xF4OOI66otVv5ukg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qKeDQqH5rBj9MFYLJNSJ8DlZVFWphI6s6p5aXtxphS4=; b=TKHIjcX+wuXVhqHraQ8eTNwJjnfV/Vc6KNsLMlrhctjNcvDJ0f73q34SM7VK3xFBC6Jq80wU15crptwi3hnjj+rVhVo/rAsDuXmMiJ3O64HWI1e8kxV2ey3XEaZf3di8tvKeLX4WQpCvY7zmQfwVlHFVSpnUVfgEiiC4ZfSP5bG0OEknJp//oEPJBgkvs8uEz5mxpXtoqjKCuZkdkeUoobLnsmX3p5+80K3uKYylQ7Q4Xnvl3Q5UIPxvvXhS/R2cSQLajJjibEHp7eeOARRD5QVOkgo8pfPruL6HXWRQ5tVuJdTxbE4KpeZOEyPaSVdb9BwCX+bQQO5hRAtjEFhrQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=atos.net; dmarc=pass action=none header.from=atos.net; dkim=pass header.d=atos.net; arc=none Received: from PA4PR02MB6686.eurprd02.prod.outlook.com (2603:10a6:102:ff::14) by PR1PR02MB4939.eurprd02.prod.outlook.com (2603:10a6:102:6::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.17; Wed, 27 Jan 2021 14:44:50 +0000 Received: from PA4PR02MB6686.eurprd02.prod.outlook.com ([fe80::e06c:aa84:a21d:6932]) by PA4PR02MB6686.eurprd02.prod.outlook.com ([fe80::e06c:aa84:a21d:6932%7]) with mapi id 15.20.3784.019; Wed, 27 Jan 2021 14:44:50 +0000 From: "CHIGOT, CLEMENT" To: Rainer Orth CC: Jonathan Wakely , libstdc++ , David Edelsohn via Gcc-patches , David Edelsohn Subject: Re: [PATCH] libstdc++: implement locale support for AIX Thread-Topic: [PATCH] libstdc++: implement locale support for AIX Thread-Index: AQHW5/cse5cUzOlFpUGzG3vP4ZkwbKoiheqAgAAI90CAAAGAAIAAAJC4gABu9YCAARiZb4AABceAgAAHyTOAAB5/x4AAALUAgAAlmBiAAQvegIAAApjfgAAHBSmAAAEXtYAAA1Z+gAyHwmCAAErKJoABGGUwgAAdWFOAAAagAIAAB0GOgAADaO+AB+TWnYAAHarZgAADjDI= Date: Wed, 27 Jan 2021 14:44:50 +0000 Message-ID: References: <20210122112910.GI541588@redhat.com> , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_Enabled=True; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_SiteId=33440fc6-b7c7-412c-bb73-0e70b0198d5a; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_SetDate=2021-01-27T14:44:49.621Z; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_Name=Atos For Internal Use - All Employees; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_ContentBits=0; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_Method=Standard; x-originating-ip: [165.225.77.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e9d77bc3-fc05-426a-abfc-08d8c2d2199f x-ms-traffictypediagnostic: PR1PR02MB4939: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5qWJDuqey6gQ8mdChaXVKeY9fkoUr61XOllOg0n93cunUW+NleDDlf+1RKvs5Znj2WIlmjm4OgkgLMLG2aqGGTHGvrikd8cMFRmk1FWdXTvfhfgW0myQlDpSZfkLh2isAu9AH8zYcfLBZ4w2waNEJGueehwShdXXGvKyarWrH9qba/LjNuHUbkrB1aYxTuqRptwf2qpLCxyuaNfA2rUDqLHNYo6Z24rFeNKgBCIxFhGHYyYs+7PAUIPrIqvKWF681/BbOQcyjgE1g9nkPApFcuSOJiq1zzB7VWkoDnimFdMzMzw5eECFU2vls8VEjYep7rKtiKSmO9AjLqtHa/sBOgighcWmFe5E27aD45Mz1bBrhKblVNW17T64rdbY6TZGXkaXggFqHI99/Jyf1LBB5Yf4GlCusSibr3dgESqzhKp+knsXA7GbcfPyHAop7x+h3CHimg+lCbIb+bh9rgN7cNUSxfatc0+Xa97j2gDQS5+VJ88Va+3Jnad+Y4wA9Vxz0M/g58B2glNYpmXDRaUI4g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR02MB6686.eurprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(39860400002)(366004)(376002)(396003)(55016002)(71200400001)(6916009)(2906002)(478600001)(8936002)(86362001)(9686003)(8676002)(4326008)(33656002)(316002)(66446008)(66946007)(66556008)(64756008)(26005)(66476007)(55236004)(186003)(83380400001)(76116006)(6506007)(7696005)(52536014)(54906003)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?reoWPufh1jE3hmun5IESTASA6SzkLcdrXQBD0XdO/6cLO5cCFPJyYVXk+n?= =?iso-8859-1?Q?tzino5NH5dGeL2nC8SeeS0KVgEZ7bB6nJ8xv5wuKc9XrxEd6npb4pbs9gM?= =?iso-8859-1?Q?8g7dSJem9kZxxr14xLI7JEe/4NBFQYfuR4ky+M7iekLFX4ofToGN9vh/+I?= =?iso-8859-1?Q?NtBrED1dnWalxz8YCOEAGyD4o3Gr7VOFljH5wPm+4fmhmRqIyJLDaO+XI3?= =?iso-8859-1?Q?Fe6jB0rELcv9XhFR1pKLZl2TH0cyl6QgRPDKGCEc3vRZHK+WAfQriG6QpW?= =?iso-8859-1?Q?jTalRebx7WLnph2+t2zhaaZHDfO5xFkLvtaCWsyhQ++trYVzp7Zvvm79/C?= =?iso-8859-1?Q?DYNSlauQCExhR6vS7IrV+jX8EDY7dp0NZeXTkHgBo1cfL3T2vkzrSeXBcU?= =?iso-8859-1?Q?uV1Ylbbfi/Darx6gpSvqez38PbMFT4oddghJQTqANd3ejwlf9xa5alPJJU?= =?iso-8859-1?Q?YR4sT4fyOrTY+xz33V9MDxflg8PhtL727auBvuUbLrzx+dQOWsTm7mi1Wx?= =?iso-8859-1?Q?ocAvIwlSv8b6tNfgVI6eQvfbbn4bdf0cbqOxippMtAQtXUZAy2DE5yl0Wv?= =?iso-8859-1?Q?keD3LIQzLlIdkpO9G3VFQmRdDeiUYwBuf81nx57Y95vqFwg3fVyys1FLFZ?= =?iso-8859-1?Q?1R08GiEqKY031hHyEyiKrdCnkYXAGL56n/HQ+xk5MIZ8atjihvJpYaGMDK?= =?iso-8859-1?Q?zbTBCVbv3ZmSN37pCMjNgJXpty2tWXM7jvkQLvaDG5UiIx43EbKx6xaJfV?= =?iso-8859-1?Q?PYvJaofPO6F0V7MdsFTOYQNrU/Q0IYthR6MH+DtHMyc7Qas2ogPTk1wAln?= =?iso-8859-1?Q?6iUOH7jPQpKUgVW+E5CRZN304rih6RJHxmd06VMOqX8SdDHBnUyxR8P8dI?= =?iso-8859-1?Q?uw83eH3lMNIOz5zxom1Y6KzTthoxcgf7gs/CtQn32jUum4h+fSVQNYIN8Y?= =?iso-8859-1?Q?vriBdlyc8bBePXfNsMnULWh7NtMlfbftGeF6FR0UpjbHHHdvjC4/9wJrE1?= =?iso-8859-1?Q?fuXBYfb9HoD3gYUK48laXSG1ziOnT7vv7VRWJklHNu5pE2otG0rmpHCHGQ?= =?iso-8859-1?Q?0ru5mlk1GfstKELA6R7Q5rP4WtEW61Zk9RhLko0sdoKi?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR02MB6686.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9d77bc3-fc05-426a-abfc-08d8c2d2199f X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2021 14:44:50.0555 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 33440fc6-b7c7-412c-bb73-0e70b0198d5a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9eR4knP46U/cpu4F0c3PGINyxpnReYNNWqhyFluZWAF0L4xOArDXKw3aK7gImewWqhWBUGO1gxFYobaTnQ/YVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR1PR02MB4939 X-OriginatorOrg: atos.net X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_ABUSEAT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2021 14:45:10 -0000 > * There are minor formatting issues:=0A= > =0A= > =A0 Should the linebreak in the extern inline definitions of strtof_l be= =0A= > =A0 after the return type, not before, matching GNU coding standards?=A0 = It=0A= > =A0 may well be that the C++ style is different, though.=0A= > =0A= > Unrelated whitespace changes in xpg7/ctype_members.cc=0A= =0A= I haven't yet check all the format issues. Especially, because the previous= =0A= code was already wrongly formatted at some point. I'll do that when =0A= releasing a "final" version of the patch.=0A= =0A= > * The changes in the copyright ranges need to be undone, given that this= =0A= > is just a renamed/augmented version of the previous dragonfly code.=0A= =0A= Ok, I wasn't sure about that. I'll revert. =0A= =0A= > * Seeing the __DragonFly__ || __FreeBSD__ again, I had a quick look at=0A= > =A0 the FreeBSD 12.2 headers and found that localeconv_l does take a=0A= > =A0 locale_t arg, just like uselocale.=A0 DragonFlyBSD seems to be the sa= me=0A= > =A0 according to their online manuals.=A0 I expect to give the code a try= in=0A= > =A0 a FreeBSD 12.2 VM at some point to check.=0A= =0A= Actually, it seems that the problem isn't about input argument, but =0A= the output which should "int*".=0A= =0A= > * While you now define _GLIBCXX_C_LOCALE_XPG7 in=0A= > config/locale/xpg7/c_locale.h, config/os/aix/ctype_configure_char.cc=0A= > =A0 still tests the previous _GLIBCXX_C_LOCALE_IEEE_2008.=0A= =0A= Arf, I've missed that. it might not be the last patch then. =0A= (I've made so much versions of it as I've tried to backport it to our =0A= old versions. It seems that I've mixed up things...) =0A=