From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 544EF3858D3C for ; Fri, 7 Oct 2022 11:14:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 544EF3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665141269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7bLyx8iu3HJaJiTEXphNVag6TanqCdZBJnVhnuLpbBU=; b=Mk4ivLqmE4uYFTHjc8Bam+Bt006vejajR2Bh16FcZAy25jOLE3c4aBXyivjWEka2p3ApDb yIdIEgEv8vyNV7OS/pbODIsiZnLHcPrs94DK3fwtRBJPFg6gUudgy2RLfwiDaTBvwMhWvY eXZKSVwGSJHPzT6XUxIn217mW8gmyWA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-175-9PKffIP6Oj-0T-HOmVZPBQ-1; Fri, 07 Oct 2022 07:14:27 -0400 X-MC-Unique: 9PKffIP6Oj-0T-HOmVZPBQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 64F9C1C07598; Fri, 7 Oct 2022 11:14:27 +0000 (UTC) Received: from localhost (unknown [10.33.36.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2613C404705F; Fri, 7 Oct 2022 11:14:27 +0000 (UTC) Date: Fri, 7 Oct 2022 12:14:26 +0100 From: Jonathan Wakely To: gcc-patches@gcc.gnu.org, bug-hurd@gnu.org Cc: libstdc++@gcc.gnu.org Subject: Re: [PATCH] libstdc++: Introduce GNU/Hurd-specific libstdc++ os-defines.h Message-ID: References: <20220829003040.kfgr7epzzyavbsjm@begin> MIME-Version: 1.0 In-Reply-To: <20220829003040.kfgr7epzzyavbsjm@begin> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: As documented at https://gcc.gnu.org/lists.html all patches for libstdc++ need to be CC'd to the libstdc++ list. That's why your patch has not been reviewed, because I didn't see it. On 29/08/22 02:30 +0200, Samuel Thibault wrote: >This is notably needed because in glibc 2.34, the move of pthread functions >into libc.so happened for Linux only, not GNU/Hurd. > >The pthread_self() function can also always be used fine as it is. > >libstdc++-v3/ChangeLog: > > * config/os/gnu/os_defines.h: New file. > * config/os/gnu/ctype_base.h: New file. > * config/os/gnu/ctype_configure_char.cc: New file. > * config/os/gnu/ctype_inline.h: New file. > * configure.host: On gnu* host, use os/gnu instead of os/gnu-linux. I think the commit message should note that these files are all copied from the existing gnu-linux ones, so that the git log records that and people don't need to compare them manually. But if these files are all identical to the existing gnu-linux ones, except for a couple of macros in os_defines.h being conditional on Linux, why not just test __linux__ in os_defines.h? Do we need three new ctype files that are identical to existing files? Why maintain two copies of the same code? >diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog >index ba5939d9003..dd288cce2ca 100644 >--- a/libstdc++-v3/ChangeLog >+++ b/libstdc++-v3/ChangeLog >@@ -1,3 +1,11 @@ >+2022-08-28 Samuel Thibault >+ >+ * config/os/gnu/os_defines.h: New file. >+ * config/os/gnu/ctype_base.h: New file. >+ * config/os/gnu/ctype_configure_char.cc: New file. >+ * config/os/gnu/ctype_inline.h: New file. >+ * configure.host: On gnu* host, use os/gnu instead of os/gnu-linux. >+ Please do not include ChangeLog diffs in the patch, it just means the patch can't be applied cleanly. GCC changelogs are auto-generated every night. The ChangeLog entry should be submitted as plain text not inthe diff, or just make it part of your Git commit message. https://gcc.gnu.org/contribute.html#patches