From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 14E6A38515E4 for ; Wed, 12 Oct 2022 11:25:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14E6A38515E4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665573919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8R+h0iHr6i1oh2a8826Guic3sr250rdsjuIFZr/8PFc=; b=NcqTFA4mQgoz/PmL31MXTy1C6988LWzHFngUacSard+WOtm4LHT6ndDhE7B6MZV7pkXnuB 9rVgmNofOKr8ycw7B61CMJbic4NuJqstx3MfHeCG54hVLSX/35+6/Eez9i979HIpzhBNPw IT6VfQm+OQO5sgl1oZljYklnNnYLk0E= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-668-MOhC2jstNuip3IuFNKSyKA-1; Wed, 12 Oct 2022 07:25:18 -0400 X-MC-Unique: MOhC2jstNuip3IuFNKSyKA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1110B85A583; Wed, 12 Oct 2022 11:25:18 +0000 (UTC) Received: from localhost (unknown [10.33.36.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id CE1D9492B05; Wed, 12 Oct 2022 11:25:17 +0000 (UTC) Date: Wed, 12 Oct 2022 12:25:16 +0100 From: Jonathan Wakely To: Seija Kijin Cc: "gcc-patches@gcc.gnu.org" , libstdc++@gcc.gnu.org Subject: Re: [PATCH] libstdc++: Fixing Error: invalid type argument of unary '*' (have 'int') Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 04/08/22 12:54 -0400, Seija Kijin wrote: >Had an error compiling tiny-cuda-nn using gcc 12.1. With this minor >patch, I recompiled and the build succeeded. This looks like a bug in the cuda compiler then. The libstdc++ code is correct. N.B. libstdc++ patches need to be CC'd to the libstdc++ list, or they won't get reviewed. >No behavioral change. >--- > libstdc++-v3/include/bits/locale_facets_nonio.tcc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/libstdc++-v3/include/bits/locale_facets_nonio.tcc >b/libstdc++-v3/include/bits/locale_facets_nonio.tcc >index 17a2c8d4486e..fc35a9e693e7 100644 >--- a/libstdc++-v3/include/bits/locale_facets_nonio.tcc >+++ b/libstdc++-v3/include/bits/locale_facets_nonio.tcc >@@ -1474,8 +1474,8 @@ _GLIBCXX_END_NAMESPACE_LDBL_OR_CXX11 > // calls. So e.g. if __fmt is "%p %I:%M:%S", we can't handle it > // properly, because we first handle the %p am/pm specifier and only > // later the 12-hour format specifier. >- if ((void*)(this->*(&time_get::do_get)) == (void*)(&time_get::do_get)) >- __use_state = true; >+ if ((void*)(this->*(&time_get::do_get)) == (&time_get::do_get)) >+ __use_state = true; > #pragma GCC diagnostic pop > #endif > __time_get_state __state = __time_get_state();