From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BDC093858036 for ; Tue, 8 Nov 2022 08:43:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BDC093858036 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667897004; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=YZmdGwTggmMC/nFFRLzufZMOKbGRfHMWk2Eu2TdYD4o=; b=i1mIgVrP3J2JQFhHOYrZJ7e3nYA1Ixp66isRpX9Ln0e5iAyOGzltfoccuKqQQwADjYy87j aksWSqryWjj5+p/GifFTJl6x9PmKgkpI4+vamsbFjTeICbyYc37biVaZIBAR/uic3Lc/Hq IwJlkmXO9ep2pNTyVwmDNE+6R1XP5gA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-3-3isKRCDNMhW9m_RfdShrJA-1; Tue, 08 Nov 2022 03:43:20 -0500 X-MC-Unique: 3isKRCDNMhW9m_RfdShrJA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3B5413817963; Tue, 8 Nov 2022 08:43:20 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E827B2028E96; Tue, 8 Nov 2022 08:43:19 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2A88hGjg2235292 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 8 Nov 2022 09:43:17 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2A88hEka2235291; Tue, 8 Nov 2022 09:43:14 +0100 Date: Tue, 8 Nov 2022 09:43:14 +0100 From: Jakub Jelinek To: Joseph Myers Cc: Jonathan Wakely , Patrick Palka , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] libstdc++: Add _Float128 to_chars/from_chars support for x86, ia64 and ppc64le with glibc Message-ID: Reply-To: Jakub Jelinek References: <6cffcff-f879-c122-2aeb-fa53714511ac@codesourcery.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Nov 08, 2022 at 01:41:41AM +0000, Joseph Myers wrote: > I've committed this further fix for a syntax error as obvious. Thanks and sorry. > libstdc++: Fix syntax error in old-glibc case in floating_from_chars.cc [PR107562] > > PR libstdc++/107562 > * src/c++17/floating_from_chars.cc (from_chars_impl): Fix syntax > error. > > diff --git a/libstdc++-v3/src/c++17/floating_from_chars.cc b/libstdc++-v3/src/c++17/floating_from_chars.cc > index 29eb4634e9d..be1e1051b5c 100644 > --- a/libstdc++-v3/src/c++17/floating_from_chars.cc > +++ b/libstdc++-v3/src/c++17/floating_from_chars.cc > @@ -632,7 +632,7 @@ namespace > { > #ifndef _GLIBCXX_HAVE_FLOAT128_MATH > if (&__strtof128 == nullptr) > - tmpval = _Float128(std::strtold(str, &endptr); > + tmpval = _Float128(std::strtold(str, &endptr)); > else > #endif > tmpval = __strtof128(str, &endptr); Jakub