From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 46E343858D39 for ; Wed, 4 Jan 2023 17:14:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 46E343858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672852456; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nqfHh+dyEEW8KgADwaokmMlABawj0eF8aiLaOcx7y4A=; b=J9Kv7sYgc6EkDLN630qljENU6MGxIAHMXLC6hTixgo4eiyzkdKG6ltXBzTXbm9ZIxBzHWc fMxlYCaJCiCd4ZUVyHtfCrbywU+8PRuFVWBYX8JGhdaxlJTNJ0HDQn7LTvaN8GKUbXZsE4 gRrkCi1RLr29H1xiVsPqQn2AYShzzB0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-352-mA5fa4OeOAOhvTMBXDKPNQ-1; Wed, 04 Jan 2023 12:14:12 -0500 X-MC-Unique: mA5fa4OeOAOhvTMBXDKPNQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3012C281DE68; Wed, 4 Jan 2023 17:14:12 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E0D1F140EBF5; Wed, 4 Jan 2023 17:14:11 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 304HE82e2533001 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 4 Jan 2023 18:14:09 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 304HE79q2533000; Wed, 4 Jan 2023 18:14:07 +0100 Date: Wed, 4 Jan 2023 18:14:06 +0100 From: Jakub Jelinek To: Jonathan Wakely Cc: Iain Sandoe , Jonathan Wakely , libstdc++ , GCC Patches Subject: Re: [PATCH] libstdc++: Export the __gnu_cxx::zoneinfo_dir_override symbol. Message-ID: Reply-To: Jakub Jelinek References: <20221224113525.20201-1-iain@sandoe.co.uk> <448810FA-97CC-430A-B9A0-75EDB470C935@sandoe.co.uk> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jan 04, 2023 at 03:17:42PM +0000, Jonathan Wakely via Gcc-patches wrote: > On Sat, 24 Dec 2022 at 12:21, Iain Sandoe wrote: > > > > > > > > > On 24 Dec 2022, at 12:12, Jonathan Wakely wrote: > > > > > > > > > > > > On Sat, 24 Dec 2022, 11:35 Iain Sandoe via Libstdc++, wrote: > > > If this is not the right place to export the symbol (or you do not want > > > to export it in the general case), I can always add a platform-specific > > > file for it. So far, tested on x86_64-darwin21, wider testing will > > > follow over the holidays. > > > > > > OK for trunk? > > > > > > I'd like to check if this causes the undefined weak symbol to be exported on ELF, > > > > I’d expect so, since it’s in the common file. > > hppa-hp-hpux* wants this symbol to be defined anyway (see PR 108228), > so please push your patch to trunk. Isn't it wrong though to export it with GLIBCXX_3.4 symbol version? I mean, if it wasn't exported in GCC 3.4 libstdc++.so, then it shouldn't be in that symver. Perhaps GLIBCXX_3.4.31 instead? Jakub