From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 25BA03850439 for ; Mon, 10 May 2021 20:22:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 25BA03850439 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-283-sLWWZ16lMQy8EmEjpkucgA-1; Mon, 10 May 2021 16:22:48 -0400 X-MC-Unique: sLWWZ16lMQy8EmEjpkucgA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7A02C8186E1; Mon, 10 May 2021 20:22:47 +0000 (UTC) Received: from localhost (unknown [10.33.36.164]) by smtp.corp.redhat.com (Postfix) with ESMTP id 26A0460BD8; Mon, 10 May 2021 20:22:47 +0000 (UTC) Date: Mon, 10 May 2021 21:22:46 +0100 From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [committed] libstdc++: Remove TODO comment Message-ID: MIME-Version: 1.0 X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="bYuxruyE8iB5a17b" Content-Disposition: inline X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 May 2021 20:22:52 -0000 --bYuxruyE8iB5a17b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline We have a comment saying to replace the simple binary_semaphore type with std::binary_semaphore, which has been done. However, that isn't defined on all targets. So keep the simple one here that just implements the parts of the API needed by , and remove the comment suggesting it should be replaced. libstdc++-v3/ChangeLog: * include/std/stop_token: Remove TODO comment. Tested powerpc64le-linux. Committed to trunk. --bYuxruyE8iB5a17b Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch.txt" commit 151154a21da8b0784894b2463a117f4e283d5525 Author: Jonathan Wakely Date: Mon May 10 21:06:22 2021 libstdc++: Remove TODO comment We have a comment saying to replace the simple binary_semaphore type with std::binary_semaphore, which has been done. However, that isn't defined on all targets. So keep the simple one here that just implements the parts of the API needed by , and remove the comment suggesting it should be replaced. libstdc++-v3/ChangeLog: * include/std/stop_token: Remove TODO comment. diff --git a/libstdc++-v3/include/std/stop_token b/libstdc++-v3/include/std/stop_token index fffc215d2a8..d0cfcf31097 100644 --- a/libstdc++-v3/include/std/stop_token +++ b/libstdc++-v3/include/std/stop_token @@ -107,7 +107,6 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION } #ifndef __cpp_lib_semaphore - // TODO: replace this with a real implementation of std::binary_semaphore struct binary_semaphore { explicit binary_semaphore(int __d) : _M_counter(__d > 0) { } --bYuxruyE8iB5a17b--