From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jwakely@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTP id 6B1123846079
 for <libstdc++@gcc.gnu.org>; Mon, 17 May 2021 16:45:29 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6B1123846079
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-488-Wnl0y0mcMneKV_x5cnq54Q-1; Mon, 17 May 2021 12:45:27 -0400
X-MC-Unique: Wnl0y0mcMneKV_x5cnq54Q-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A6F22106BB2E;
 Mon, 17 May 2021 16:45:26 +0000 (UTC)
Received: from localhost (unknown [10.33.36.7])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 55B145D9F2;
 Mon, 17 May 2021 16:45:26 +0000 (UTC)
Date: Mon, 17 May 2021 17:45:25 +0100
From: Jonathan Wakely <jwakely@redhat.com>
To: Patrick Palka <ppalka@redhat.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Fix up semiregular-box partial specialization
 [PR100475]
Message-ID: <YKKdpU+MYp0axmq3@redhat.com>
References: <20210517154326.840680-1-ppalka@redhat.com>
MIME-Version: 1.0
In-Reply-To: <20210517154326.840680-1-ppalka@redhat.com>
X-Clacks-Overhead: GNU Terry Pratchett
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=unavailable autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libstdc++@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libstdc++ mailing list <libstdc++.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/libstdc++/>
List-Post: <mailto:libstdc++@gcc.gnu.org>
List-Help: <mailto:libstdc++-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 17 May 2021 16:45:30 -0000

On 17/05/21 11:43 -0400, Patrick Palka via Libstdc++ wrote:
>This makes the in-place constructor of our partial specialization of
>__box for already-semiregular types to use direct-non-list-initialization
>(in accordance with the specification of the primary template), and
>additionally makes its data() member function use std::__addressof.
>
>Tested on x86_64-pc-linux-gnu, does this look OK for 10/11/trunk?

Yes for all, thanks.