From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id B3839385E447 for ; Wed, 19 May 2021 13:27:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B3839385E447 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-153-toIzZ69uMv-_1-f0mRIc8g-1; Wed, 19 May 2021 09:27:26 -0400 X-MC-Unique: toIzZ69uMv-_1-f0mRIc8g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2F9158015F5; Wed, 19 May 2021 13:27:25 +0000 (UTC) Received: from localhost (unknown [10.33.36.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id C23681971B; Wed, 19 May 2021 13:27:24 +0000 (UTC) Date: Wed, 19 May 2021 14:27:23 +0100 From: Jonathan Wakely To: Bernd Edlinger Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [committed] libstdc++: Fix std::jthread assertion and re-enable skipped test Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2021 13:27:29 -0000 On 18/05/21 13:58 +0200, Bernd Edlinger wrote: >On 5/18/21 1:55 PM, Bernd Edlinger wrote: >> On 5/17/21 7:13 PM, Jonathan Wakely via Gcc-patches wrote: >>> libstdc++-v3/ChangeLog: >>> >>> * include/std/thread (jthread::_S_create): Fix static assert >>> message. >>> * testsuite/30_threads/jthread/95989.cc: Re-enable test. >>> * testsuite/30_threads/jthread/jthread.cc: Do not require >>> pthread effective target. >>> * testsuite/30_threads/jthread/2.cc: Moved to... >>> * testsuite/30_threads/jthread/version.cc: ...here. >>> >>> Tested powerpc64le-linux. Committed to trunk. >>> >>> Let's see if this test is actually fixed, or if it still causes >>> failures on some targets. >>> >>> >> >> Yes, indeed it is failing on x86_64-pc-linux-gnu. >> > >that means only this one: > >FAIL: 30_threads/jthread/95989.cc execution test What's your glibc version?