public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Patrick Palka <ppalka@redhat.com>
Cc: Tim Song <t.canens.cpp@gmail.com>,
	libstdc++ <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Fix iterator caching inside range adaptors [PR100479]
Date: Mon, 24 May 2021 19:59:50 +0100	[thread overview]
Message-ID: <YKv3phbxGr2KKUdS@redhat.com> (raw)
In-Reply-To: <79bd58a5-63fd-d14c-c23b-9534f8331b3@idea>

On 18/05/21 00:53 -0400, Patrick Palka via Libstdc++ wrote:
>On Mon, 17 May 2021, Tim Song wrote:
>
>> On Mon, May 17, 2021 at 2:59 PM Patrick Palka <ppalka@redhat.com> wrote:
>> >
>> > +       constexpr _CachedPosition&
>> > +       operator=(_CachedPosition&& __other) noexcept
>> > +       {
>> > +         if (std::__addressof(__other) != this)
>>
>> I don't think we need this check - self-move-assigning the underlying
>> view isn't required to be a no-op, so we should still invalidate.
>
>Sounds good, so like so:

Looks good to me (but then so did the previous one ;-)

Please push, as this is an improvement on what's on trunk now. If Tim
spots any more problems they can be fixed later.


Thanks both of you.


      reply	other threads:[~2021-05-24 18:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 15:43 Patrick Palka
2021-05-17 16:51 ` Jonathan Wakely
2021-05-17 18:39 ` Tim Song
2021-05-17 19:59   ` Patrick Palka
2021-05-17 22:28     ` Tim Song
2021-05-18  4:53       ` Patrick Palka
2021-05-24 18:59         ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKv3phbxGr2KKUdS@redhat.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=ppalka@redhat.com \
    --cc=t.canens.cpp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).