Re: [committed] libstdc++: Use reserved name for attribute [PR101055]

[Jonathan Wakely <jwakely@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

On 14/06/21 11:54 +0100, Jonathan Wakely wrote:
>The no_unique_address attribute is not a reserved name until C++20, so
>to use it in C++11/14/17 modes we should use the __no_unique_address_
>form. We already use that form when using the attribute, but not in the
>__has_cpp_attribute check.
>
>libstdc++-v3/ChangeLog:
>
>	PR libstdc++/101055
>	* include/std/tuple: Use reserved form of attribute name.
>	* testsuite/17_intro/headers/c++2011/all_attributes.cc: Add
>	check for no_unique_address.
>	* testsuite/17_intro/headers/c++2014/all_attributes.cc:
>	Likewise.
>	* testsuite/17_intro/headers/c++2017/all_attributes.cc:
>	Likewise.

And this ensures the modified C++17 test doesn't fail when using a
newer -std option.

Tested powerpc64le-linux. Committed to trunk.




[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 1224 bytes --]

commit 45fb3d45a4d4b79a00c56fa93e9e69d9d7762ca0
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Jun 14 13:17:40 2021

    libstdc++: Add explicit -std=gnu++17 option to test
    
    This test has no -std option so when the testsuite is run with
    -std=gnu++20 or later, this test will use that. The recent addition of
    no_unique_address will cause it to FAIL, because that's a reserved word
    after C++17. Add an explicit option, so that this test alays uses
    exactly C++17.
    
    libstdc++-v3/ChangeLog:
    
            * testsuite/17_intro/headers/c++2017/all_attributes.cc: Add
            -std=gnu++17 option.

diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++2017/all_attributes.cc b/libstdc++-v3/testsuite/17_intro/headers/c++2017/all_attributes.cc
index 811b3fe3613..ea2c7d20ba2 100644
--- a/libstdc++-v3/testsuite/17_intro/headers/c++2017/all_attributes.cc
+++ b/libstdc++-v3/testsuite/17_intro/headers/c++2017/all_attributes.cc
@@ -15,6 +15,7 @@
 // with this library; see the file COPYING3.  If not see
 // <http://www.gnu.org/licenses/>.
 
+// { dg-options "-std=gnu++17" }
 // { dg-do compile { target c++17 } }
 
 // Ensure the library only uses the __name__ form for attributes.