From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id D128A39B90A5 for ; Thu, 19 Aug 2021 13:58:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D128A39B90A5 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-tJzXmUlWNICtwnkhj_EkXg-1; Thu, 19 Aug 2021 09:58:04 -0400 X-MC-Unique: tJzXmUlWNICtwnkhj_EkXg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 86373100CEC1; Thu, 19 Aug 2021 13:58:03 +0000 (UTC) Received: from localhost (unknown [10.33.36.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1FCAC100EBAD; Thu, 19 Aug 2021 13:58:02 +0000 (UTC) Date: Thu, 19 Aug 2021 14:58:02 +0100 From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [committed] libstdc++: Don't check always-true condition [PR101965] Message-ID: MIME-Version: 1.0 X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="i8/hCF1azwWp8zLB" Content-Disposition: inline X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2021 13:58:08 -0000 --i8/hCF1azwWp8zLB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: PR libstdc++/101965 * include/std/charconv (__to_chars_i): Remove redundant check. Tested powerpc64le-linux. Committed to trunk. --i8/hCF1azwWp8zLB Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch.txt" commit 85a709595005b5df4b2ee9d81717a5df19c0023f Author: Jonathan Wakely Date: Thu Aug 19 13:05:54 2021 libstdc++: Don't check always-true condition [PR101965] Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: PR libstdc++/101965 * include/std/charconv (__to_chars_i): Remove redundant check. diff --git a/libstdc++-v3/include/std/charconv b/libstdc++-v3/include/std/charconv index ac9c34d4601..2e368843fc9 100644 --- a/libstdc++-v3/include/std/charconv +++ b/libstdc++-v3/include/std/charconv @@ -336,12 +336,10 @@ namespace __detail *__first = '0'; return { __first + 1, errc{} }; } - - if _GLIBCXX17_CONSTEXPR (std::is_signed<_Tp>::value) + else if _GLIBCXX17_CONSTEXPR (std::is_signed<_Tp>::value) if (__value < 0) { - if (__builtin_expect(__first != __last, 1)) - *__first++ = '-'; + *__first++ = '-'; __unsigned_val = _Up(~__value) + _Up(1); } --i8/hCF1azwWp8zLB--