* [PATCH] libstdc++: Fix return values for atomic wait on futex
@ 2021-09-28 19:35 Jonathan Wakely
0 siblings, 0 replies; only message in thread
From: Jonathan Wakely @ 2021-09-28 19:35 UTC (permalink / raw)
To: libstdc++, gcc-patches; +Cc: Thomas Rodgers
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
This fixes a logic error in the futex-based timed wait.
Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
libstdc++-v3/ChangeLog:
* include/bits/atomic_timed_wait.h (__platform_wait_until_impl):
Return false for ETIMEDOUT and true otherwise.
Tested x86_64-linux.
I'm not seeing any tests fail as a result of this, btu it does seem to
be incorrect. Please check my working.
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 1136 bytes --]
commit 94dc544bbf42e95a363b916ed0d665afcfcccc88
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Aug 31 10:20:41 2021
libstdc++: Fix return values for atomic wait on futex
This fixes a logic error in the futex-based timed wait.
Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
libstdc++-v3/ChangeLog:
* include/bits/atomic_timed_wait.h (__platform_wait_until_impl):
Return false for ETIMEDOUT and true otherwise.
diff --git a/libstdc++-v3/include/bits/atomic_timed_wait.h b/libstdc++-v3/include/bits/atomic_timed_wait.h
index 3db08f82707..d423a7af7c3 100644
--- a/libstdc++-v3/include/bits/atomic_timed_wait.h
+++ b/libstdc++-v3/include/bits/atomic_timed_wait.h
@@ -101,12 +101,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
if (__e)
{
- if ((errno != ETIMEDOUT) && (errno != EINTR)
- && (errno != EAGAIN))
+ if (errno == ETIMEDOUT)
+ return false;
+ if (errno != EINTR && errno != EAGAIN)
__throw_system_error(errno);
- return true;
}
- return false;
+ return true;
}
// returns true if wait ended before timeout
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-09-28 19:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 19:35 [PATCH] libstdc++: Fix return values for atomic wait on futex Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).