From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id F24BF3858D33 for ; Mon, 2 May 2022 05:05:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F24BF3858D33 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-513-Qqc0PqlnPLii7mfZ5KUqkg-1; Mon, 02 May 2022 01:05:53 -0400 X-MC-Unique: Qqc0PqlnPLii7mfZ5KUqkg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8109A803524; Mon, 2 May 2022 05:05:53 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E3ACD551E6E; Mon, 2 May 2022 05:05:52 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 24255oif3995825 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 2 May 2022 07:05:50 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 24255oSP3995824; Mon, 2 May 2022 07:05:50 +0200 Date: Mon, 2 May 2022 07:05:50 +0200 From: Jakub Jelinek To: Jonathan Wakely Cc: Patrick Palka , libstdc++ , gcc Patches Subject: Re: [PATCH 1/2] libstdc++: case-sensitivity in hexfloat std::from_chars [PR105441] Message-ID: Reply-To: Jakub Jelinek References: <20220501182109.3668200-1-ppalka@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2022 05:05:57 -0000 On Sun, May 01, 2022 at 08:09:05PM +0100, Jonathan Wakely via Gcc-patches wrote: > On Sun, 1 May 2022 at 19:22, Patrick Palka via Libstdc++ > wrote: > > > > The hexfloat parser for binary32/64 added in r12-6645-gcc3bf3404e4b1c > > overlooked that the exponent part can also begin with an uppercase 'P'. > > > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk/11, and possibly the > > 12 branch now for 12.1? > > OK for trunk, and as it's a regression since gcc-11 I'd recommend > release manager approval for 12.1 as well, but it's the RMs call. Ok for 12.1. > > PR libstdc++/105441 > > > > libstdc++-v3/ChangeLog: > > > > * src/c++17/floating_from_chars.cc (__floating_from_chars_hex): > > Also accept 'P' as the start of the exponent. > > * testsuite/20_util/from_chars/7.cc: Add corresponding testcase. Jakub