From: Marek Polacek <polacek@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [committed] i386: Fix grammar typo in diagnostic
Date: Mon, 7 Aug 2023 17:22:14 -0400 [thread overview]
Message-ID: <ZNFghgkL2kKqrqEA@redhat.com> (raw)
In-Reply-To: <20230807211335.701619-1-jwakely@redhat.com>
On Mon, Aug 07, 2023 at 10:12:35PM +0100, Jonathan Wakely via Gcc-patches wrote:
> Committed as obvious.
>
> Less obvious (to me) is whether it's correct to say "GCC V13" here. I
> don't think we refer to a version that way anywhere else, do we?
>
> Would "since GCC 13.1.0" be better?
x86_field_alignment uses
inform (input_location, "the alignment of %<_Atomic %T%> "
"fields changed in %{GCC 11.1%}",
so maybe the below should use %{GCC 13.1%}. "GCC V13" looks unusual
to me.
> -- >8 --
>
> gcc/ChangeLog:
>
> * config/i386/i386.cc (ix86_invalid_conversion): Fix grammar.
> ---
> gcc/config/i386/i386.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc
> index 50860050049..5d57726e22c 100644
> --- a/gcc/config/i386/i386.cc
> +++ b/gcc/config/i386/i386.cc
> @@ -22890,7 +22890,7 @@ ix86_invalid_conversion (const_tree fromtype, const_tree totype)
> warning (0, "%<__bfloat16%> is redefined from typedef %<short%> "
> "to real %<__bf16%> since GCC V13, be careful of "
> "implicit conversion between %<__bf16%> and %<short%>; "
> - "a explicit bitcast may be needed here");
> + "an explicit bitcast may be needed here");
> }
>
> /* Conversion allowed. */
> --
> 2.41.0
>
Marek
next prev parent reply other threads:[~2023-08-07 21:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 21:12 Jonathan Wakely
2023-08-07 21:22 ` Marek Polacek [this message]
2023-08-22 14:08 ` Gerald Pfeifer
2023-08-22 23:28 ` Hongtao Liu
2023-08-23 5:15 ` Hongtao Liu
2023-08-23 7:02 ` Jonathan Wakely
2023-08-23 8:08 ` Hongtao Liu
2023-08-24 3:38 ` Hongtao Liu
2023-08-24 6:27 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNFghgkL2kKqrqEA@redhat.com \
--to=polacek@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).