From: Jakub Jelinek <jakub@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: Jason Merrill <jason@redhat.com>,
gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org,
Jonathan Wakely <jwakely@redhat.com>,
Nathan Sidwell <nathan@acm.org>
Subject: Re: Skip a number of C++ test cases for '-fno-exceptions' testing (was: Support in the GCC(/C++) test suites for '-fno-exceptions')
Date: Fri, 3 Nov 2023 12:15:08 +0100 [thread overview]
Message-ID: <ZUTWPDqWYXBLP09r@tucnak> (raw)
In-Reply-To: <87msvvt7yt.fsf@euler.schwinge.homeip.net>
On Fri, Nov 03, 2023 at 12:03:06PM +0100, Thomas Schwinge wrote:
> --- a/gcc/testsuite/g++.dg/cpp0x/catch1.C
> +++ b/gcc/testsuite/g++.dg/cpp0x/catch1.C
> @@ -1,5 +1,6 @@
> // PR c++/53371
> // { dg-do compile { target c++11 } }
> +// Explicit { dg-require-effective-target exceptions_enabled } to avoid verify compiler messages FAILs for '-fno-exceptions'.
Ugh, this is just too ugly.
Please don't mix explanation comment with a directive, one line should be
just a directive and you can add explanation in a line above it.
Jakub
prev parent reply other threads:[~2023-11-03 11:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 19:13 Support in the GCC(/C++) test suites for '-fno-exceptions' Thomas Schwinge
2023-06-06 19:31 ` Jonathan Wakely
2023-06-07 7:13 ` Support 'UNSUPPORTED: [...]: exception handling disabled' for libstdc++ testing (was: Support in the GCC(/C++) test suites for '-fno-exceptions') Thomas Schwinge
2023-06-07 8:12 ` Jonathan Wakely
2023-06-07 9:08 ` Thomas Schwinge
2023-06-07 11:51 ` Jonathan Wakely
2023-06-07 15:56 ` Jonathan Wakely
2023-06-15 15:15 ` Skip a number of C++ test cases for '-fno-exceptions' " Thomas Schwinge
2023-09-08 13:30 ` Thomas Schwinge
2023-11-03 11:03 ` Thomas Schwinge
2023-11-03 11:15 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUTWPDqWYXBLP09r@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=nathan@acm.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).