From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C0F383858D20 for ; Thu, 11 Apr 2024 14:06:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C0F383858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C0F383858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712844404; cv=none; b=PaHgkWS4276ggFsltC54hqKsboB6yBVfjgBCnGKjOP5zlW7ow6lMVLCp+IX3Rso3wkCUuUOOPuN6wTnyaeiJK67UV+ziqXRVr0hNjEWIegkh3Go9zaaaBaQaKUS4Xhqp4bMNB6/EzuiY8/jLTELy6RdHYZu5uDvpE4erjoihgoI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712844404; c=relaxed/simple; bh=lPLZJHQRep2zy5HINQhfF0n4XxQsSCIQuh0hFOOXNGw=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=gG1/yWg/8mT+FQJw0n0jcEcZc20JkrvMb+R/6BzRu9ZKFuDjtK9nWwG1cEhkEYTG6lNb9EsiI3wUZDSSJEWRD7SE6+kF7/rhhBedJMBDC4c3eEO26g839JqsFfSvjF4hS5i9YbMUaBq47ihgE5zdL9xYCiFD8y14EagwqnVNc0E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712844402; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=3iHtnwCfWl2lFcVDYKpPavojHkwOv83fHrIwJ46Z5l0=; b=MiE5SIF7coE3ggIweb9vk50Kg3vWvrAjZ+EG4uaAVzt7wumAKLZhLe8zycISDMZNMfcuYX 3LAbAP5QS1XIVq1++UBRRyOs/QcZxCTUMho4dfb684HQ3kuS5LJrZMQJ9CmyySuOdYzDbx TPSgy+oo2VaTTpKGoMCr9hSTaZcdvzg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-17-dekR1-J5PPyY_FYJOEiQ7Q-1; Thu, 11 Apr 2024 10:06:40 -0400 X-MC-Unique: dekR1-J5PPyY_FYJOEiQ7Q-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9C37D88E863; Thu, 11 Apr 2024 14:06:40 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 614C5492BC8; Thu, 11 Apr 2024 14:06:40 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 43BE6Zwx3022929 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 11 Apr 2024 16:06:35 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 43BE6Y9H3022928; Thu, 11 Apr 2024 16:06:34 +0200 Date: Thu, 11 Apr 2024 16:06:34 +0200 From: Jakub Jelinek To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] libstdc++: Regenerate baseline_symbols.txt files for i386-linux-gnu Message-ID: Reply-To: Jakub Jelinek References: <20240411135929.521941-1-jwakely@redhat.com> MIME-Version: 1.0 In-Reply-To: <20240411135929.521941-1-jwakely@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Apr 11, 2024 at 02:59:05PM +0100, Jonathan Wakely wrote: > I think we also want the same change for i386. > > -- >8 -- > > libstdc++-v3/ChangeLog: > > * config/abi/post/i386-linux-gnu/baseline_symbols.txt: > Regenerate. Not sure about that, the file is missing all the 3.4.30, 3.4.31 and other 3.4.32 symbols as well. It needs to be regenerated. I'm not really sure what i386 really is and if we support it at all, given that it doesn't support the fundamental locking instructions. > --- a/libstdc++-v3/config/abi/post/i386-linux-gnu/baseline_symbols.txt > +++ b/libstdc++-v3/config/abi/post/i386-linux-gnu/baseline_symbols.txt > @@ -3186,6 +3186,7 @@ FUNC:_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE10_M_disposeEv@@GLIBCX > FUNC:_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE10_M_replaceEjjPKcj@@GLIBCXX_3.4.21 > FUNC:_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE10_S_compareEjj@@GLIBCXX_3.4.21 > FUNC:_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE11_M_capacityEj@@GLIBCXX_3.4.21 > +FUNC:_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE11_S_allocateERS3_j@@GLIBCXX_3.4.32 > FUNC:_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE12_Alloc_hiderC1EPcOS3_@@GLIBCXX_3.4.23 > FUNC:_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE12_Alloc_hiderC1EPcRKS3_@@GLIBCXX_3.4.21 > FUNC:_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE12_Alloc_hiderC2EPcOS3_@@GLIBCXX_3.4.23 > @@ -3337,6 +3338,7 @@ FUNC:_ZNSt7__cxx1112basic_stringIwSt11char_traitsIwESaIwEE10_M_disposeEv@@GLIBCX > FUNC:_ZNSt7__cxx1112basic_stringIwSt11char_traitsIwESaIwEE10_M_replaceEjjPKwj@@GLIBCXX_3.4.21 > FUNC:_ZNSt7__cxx1112basic_stringIwSt11char_traitsIwESaIwEE10_S_compareEjj@@GLIBCXX_3.4.21 > FUNC:_ZNSt7__cxx1112basic_stringIwSt11char_traitsIwESaIwEE11_M_capacityEj@@GLIBCXX_3.4.21 > +FUNC:_ZNSt7__cxx1112basic_stringIwSt11char_traitsIwESaIwEE11_S_allocateERS3_j@@GLIBCXX_3.4.32 > FUNC:_ZNSt7__cxx1112basic_stringIwSt11char_traitsIwESaIwEE12_Alloc_hiderC1EPwOS3_@@GLIBCXX_3.4.23 > FUNC:_ZNSt7__cxx1112basic_stringIwSt11char_traitsIwESaIwEE12_Alloc_hiderC1EPwRKS3_@@GLIBCXX_3.4.21 > FUNC:_ZNSt7__cxx1112basic_stringIwSt11char_traitsIwESaIwEE12_Alloc_hiderC2EPwOS3_@@GLIBCXX_3.4.23 > -- > 2.44.0 Jakub