From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id B7BC33858D37; Sun, 1 Nov 2020 19:48:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B7BC33858D37 Received: by mail-wr1-x42a.google.com with SMTP id y12so12177515wrp.6; Sun, 01 Nov 2020 11:48:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language; bh=10bXoDJoQ8sTL/cyhuXTITCgEZizGriuTRKyhmcxYho=; b=IRM+WEMKKZh/ks+a74LiGkoU3UhczJSzFBoCg+R1ton6xuNXnalg+MwSLTfS3sS1WD e9eADgDZ0xTU8teMCaM+wW0cK2jTxJ9e5cSivJTPnzkFINgws8ssFfQTfDHyczo1Gl6C QuunwKgxKG5P4zYhlCsXVN6IUsaSxZR5VRZnfK9CLXuPJwBmZ03rZFNBzrClNqEhc+4I G51kR/1b4SALLAQHexyHFaD46EbscEObU4nflCWn5HBTadZPmlBWgOrHYeRl/0qlKX0C ri7a7aZ3jlXcBmnZhYNrTLQUXlEhAWwwaCKLHoDHYK7QrkeeRyc6BypIQFkcMOTkKYNO OSwA== X-Gm-Message-State: AOAM530jpKEbXYukTCXax1qs/FoWh1VeY3aLqDdOTlhA2c9aAvtQT5+8 PfiKhRRLBD35j2ny7SYnSXS7ZCG1sQ8= X-Google-Smtp-Source: ABdhPJwHKc3s9utfkHzAPV8HoWq+CDO4fEkgHD6dN6WnArO45guslpqE2+FXM0IOfT51Hk0j+PASBg== X-Received: by 2002:adf:8b92:: with SMTP id o18mr16505128wra.54.1604260117428; Sun, 01 Nov 2020 11:48:37 -0800 (PST) Received: from ?IPv6:2a01:e0a:1dc:b1c0:39d3:d6dd:2a1d:ba24? ([2a01:e0a:1dc:b1c0:39d3:d6dd:2a1d:ba24]) by smtp.googlemail.com with ESMTPSA id 9sm9850434wmk.5.2020.11.01.11.48.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Nov 2020 11:48:36 -0800 (PST) To: "libstdc++@gcc.gnu.org" , gcc-patches From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= Subject: [PATCH] Add missing gnu-versioned-namespace symbols Message-ID: Date: Sun, 1 Nov 2020 20:48:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------A530E8B1F9E2DB52667DFBAD" Content-Language: fr X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Nov 2020 19:48:40 -0000 This is a multi-part message in MIME format. --------------A530E8B1F9E2DB52667DFBAD Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Several tests are failing because of those missing symbols. I understand why we need to export symbols relying in the versioned namespace but I don't understand why we need to do it for _GLIBCXX_DEBUG symbols which are not version namespace dependant. Do you want to backport the Debug symbol ?     libstdc++: Add mising gnu-versioned-namespace symbols     libstdc++-v3/ChangeLog:             * config/abi/pre/gnu-versioned-namespace.ver:             Add __istream_extract and _Safe_local_iterator_base::_M_attach_single             symbols. Tested under Linux x86_64 versioned namespace. Ok to commit ? François --------------A530E8B1F9E2DB52667DFBAD Content-Type: text/x-patch; charset=UTF-8; name="gnu-versioned-ns.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="gnu-versioned-ns.patch" diff --git a/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver b/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver index 0965854fbc3..3b6d7944d06 100644 --- a/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver +++ b/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver @@ -98,6 +98,9 @@ GLIBCXX_8.0 { _ZNSt3__817__copy_streambufsI*; _ZNSt3__821__copy_streambufs_eofI*; + # std::__istream_extract(wistream&, wchar_t*, streamsize) + _ZNSt3__817__istream_extractIwNS_11char_traitsIwEEEEvRNS_13basic_istreamIT_T0_EEPS4_[ilx]; + # __gnu_cxx::__atomic_add # __gnu_cxx::__exchange_and_add _ZN9__gnu_cxx3__812__atomic_addEPV[il][il]; @@ -145,6 +148,7 @@ GLIBCXX_8.0 { _ZN11__gnu_debug30_Safe_unordered_container_base13_M_detach_allEv; _ZN11__gnu_debug25_Safe_local_iterator_base9_M_attachEPNS_19_Safe_sequence_baseEb; _ZN11__gnu_debug25_Safe_local_iterator_base9_M_detachEv; + _ZN11__gnu_debug25_Safe_local_iterator_base16_M_attach_singleEPNS_19_Safe_sequence_baseEb; # parallel mode _ZN14__gnu_parallel9_Settings3getEv; --------------A530E8B1F9E2DB52667DFBAD--