From: Thomas Rodgers <rodgert@appliantology.com>
To: Mikhail Matrosov <mikhail.matrosov@gmail.com>
Cc: Jonathan Wakely <jwakely.gcc@gmail.com>,
libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: std::atomic_shared_ptr
Date: Wed, 02 Jun 2021 08:03:47 -0700 [thread overview]
Message-ID: <a15eea73ea1d813a654fa37959d97cb4@appliantology.com> (raw)
In-Reply-To: <CADhDkKx8rjn0Hg7HXsixmC8SuLgb4Gsy9SVEN0fuZJSKaHGkJA@mail.gmail.com>
On 2021-06-02 07:37, Mikhail Matrosov wrote:
>> Probably not, because it would require ABI-breaking changes to
> std::shared_ptr, which is out of the question.
>
> Could you please elaborate on that? I can see how folly uses
> std::shared_ptr directly:
>
> https://github.com/facebook/folly/blob/master/folly/concurrency/AtomicSharedPtr.h#L76
> https://github.com/facebook/folly/blob/master/folly/concurrency/detail/AtomicSharedPtr-detail.h#L45
>
> -----
> Best regards, Mikhail Matrosov
I've yet to be convinced that this type warrants the extra complexity
doing so would entail, and if I did decide to incur that level of
complexity, I would likely go a different route (see comments in folly
re: corner cases). Either way, GCC12 won't commit to any ABI for
this, GCC13 might, and the details can change between the two releases.
prev parent reply other threads:[~2021-06-02 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 19:35 std::atomic_shared_ptr Mikhail Matrosov
2021-06-02 1:57 ` std::atomic_shared_ptr Thomas Rodgers
2021-06-02 2:16 ` std::atomic_shared_ptr Thomas Rodgers
2021-06-02 7:10 ` std::atomic_shared_ptr Mikhail Matrosov
2021-06-02 9:22 ` std::atomic_shared_ptr Jonathan Wakely
2021-06-02 14:37 ` std::atomic_shared_ptr Mikhail Matrosov
2021-06-02 15:03 ` Thomas Rodgers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a15eea73ea1d813a654fa37959d97cb4@appliantology.com \
--to=rodgert@appliantology.com \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
--cc=mikhail.matrosov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).