From: "François Dumont" <frs.dumont@gmail.com>
To: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH] Fix inline versioned namespace bootstrap
Date: Fri, 27 Aug 2021 22:57:16 +0200 [thread overview]
Message-ID: <a162465e-8f5e-497b-932d-ee9cac2375b4@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
Since std::allocator<void> is not specialized anymore in
_GLIBCXX_INLINE_VERSION mode _ExtPtr_allocator<void> specialization do
not compile
because std::allocator<void> is incomplete.
So I think primary _ExtPtr_allocator template should also be prefered in
_GLIBCXX_INLINE_VERSION mode.
Ok to commit ?
François
[-- Attachment #2: extptr_allocator.h.patch --]
[-- Type: text/x-patch, Size: 645 bytes --]
diff --git a/libstdc++-v3/include/ext/extptr_allocator.h b/libstdc++-v3/include/ext/extptr_allocator.h
index 7d8aaac7cee..78ee1fa039f 100644
--- a/libstdc++-v3/include/ext/extptr_allocator.h
+++ b/libstdc++-v3/include/ext/extptr_allocator.h
@@ -162,6 +162,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
std::allocator<_Tp> _M_real_alloc;
};
+#if ! _GLIBCXX_INLINE_VERSION
// _ExtPtr_allocator<void> specialization.
template<>
class _ExtPtr_allocator<void>
@@ -183,6 +184,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
private:
std::allocator<void> _M_real_alloc;
};
+#endif
template<typename _Tp>
inline void
next reply other threads:[~2021-08-27 20:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 20:57 François Dumont [this message]
2021-08-27 21:17 ` Jonathan Wakely
2021-08-28 9:26 ` Jonathan Wakely
2021-08-28 10:49 ` Jonathan Wakely
2021-08-28 12:40 ` François Dumont
2021-08-28 13:38 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a162465e-8f5e-497b-932d-ee9cac2375b4@gmail.com \
--to=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).