* [PATCH] Include netinet/in.h in include/experimental/internet
@ 2019-09-30 16:59 Andreas Tobler
2019-09-30 23:25 ` Thomas Rodgers
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Tobler @ 2019-09-30 16:59 UTC (permalink / raw)
To: GCC Patches, libstdc++
Hi all,
I'm going to commit the attached patch to trunk.
It is preapproved by Jonathan. (via #irc)
On FreeBSD the netinet/in.h header is not included by arpa/inet.h, so do
the include if we have the _GLIBCXX_HAVE_NETINET_IN_H defined.
This makes all the experimental/net/internet test cases pass here.
Any comments?
TIA,
Andreas
Commit one-liner:
Include netinet/in.h in include/experimental/internet
2019-09-30 Andreas Tobler <andreast@gcc.gnu.org>
* include/experimental/internet: Include netinet/in.h if we have
_GLIBCXX_HAVE_NETINET_IN_H defined.
Index: include/experimental/internet
===================================================================
--- include/experimental/internet (revision 276342)
+++ include/experimental/internet (working copy)
@@ -51,6 +51,9 @@
#ifdef _GLIBCXX_HAVE_ARPA_INET_H
# include <arpa/inet.h> // inet_ntop
#endif
+#ifdef _GLIBCXX_HAVE_NETINET_IN_H
+# include <netinet/in.h> // IPPROTO_IP
+#endif
#ifdef _GLIBCXX_HAVE_NETINET_TCP_H
# include <netinet/tcp.h> // TCP_NODELAY
#endif
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Include netinet/in.h in include/experimental/internet
2019-09-30 16:59 [PATCH] Include netinet/in.h in include/experimental/internet Andreas Tobler
@ 2019-09-30 23:25 ` Thomas Rodgers
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Rodgers @ 2019-09-30 23:25 UTC (permalink / raw)
To: libstdc++; +Cc: GCC Patches
Looks good to me.
Andreas Tobler writes:
> Hi all,
>
> I'm going to commit the attached patch to trunk.
> It is preapproved by Jonathan. (via #irc)
>
> On FreeBSD the netinet/in.h header is not included by arpa/inet.h, so do the
> include if we have the _GLIBCXX_HAVE_NETINET_IN_H defined.
>
> This makes all the experimental/net/internet test cases pass here.
>
> Any comments?
>
> TIA,
> Andreas
>
> Commit one-liner:
>
> Include netinet/in.h in include/experimental/internet
>
> 2019-09-30 Andreas Tobler <andreast@gcc.gnu.org>
>
> * include/experimental/internet: Include netinet/in.h if we have
> _GLIBCXX_HAVE_NETINET_IN_H defined.
>
> Index: include/experimental/internet
> ===================================================================
> --- include/experimental/internet (revision 276342)
> +++ include/experimental/internet (working copy)
> @@ -51,6 +51,9 @@
> #ifdef _GLIBCXX_HAVE_ARPA_INET_H
> # include <arpa/inet.h> // inet_ntop
> #endif
> +#ifdef _GLIBCXX_HAVE_NETINET_IN_H
> +# include <netinet/in.h> // IPPROTO_IP
> +#endif
> #ifdef _GLIBCXX_HAVE_NETINET_TCP_H
> # include <netinet/tcp.h> // TCP_NODELAY
> #endif
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-30 23:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-30 16:59 [PATCH] Include netinet/in.h in include/experimental/internet Andreas Tobler
2019-09-30 23:25 ` Thomas Rodgers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).