From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mxout014.mail.hostpoint.ch (mxout014.mail.hostpoint.ch [IPv6:2a00:d70:0:e::314]) by sourceware.org (Postfix) with ESMTPS id BCC993858D3C; Fri, 11 Mar 2022 15:35:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BCC993858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vollmann.ch Authentication-Results: sourceware.org; spf=none smtp.mailfrom=vollmann.ch Received: from [10.0.2.44] (helo=asmtp014.mail.hostpoint.ch) by mxout014.mail.hostpoint.ch with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2 (FreeBSD)) (envelope-from ) id 1nShIz-0004th-OZ; Fri, 11 Mar 2022 16:35:49 +0100 Received: from [46.22.24.208] (helo=[192.168.26.4]) by asmtp014.mail.hostpoint.ch with esmtpa (Exim 4.95 (FreeBSD)) (envelope-from ) id 1nShIz-0008wg-Jx; Fri, 11 Mar 2022 16:35:49 +0100 X-Authenticated-Sender-Id: mail-all@vollmann.ch Content-Type: multipart/mixed; boundary="------------aARsEUaB4QRWbpyw44aEpOte" Message-ID: Date: Fri, 11 Mar 2022 16:35:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [committed] libstdc++: Move closing brace outside #endif [PR104866] Content-Language: en-US To: Jonathan Wakely Cc: libstdc++ , gcc Patches References: <20220310211107.1757824-1-jwakely@redhat.com> <4b5afc64-39f6-db5a-c6ba-144af10c698a@vollmann.ch> From: Detlef Vollmann In-Reply-To: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 15:35:53 -0000 This is a multi-part message in MIME format. --------------aARsEUaB4QRWbpyw44aEpOte Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/11/22 16:12, Jonathan Wakely wrote: > On Fri, 11 Mar 2022 at 14:28, Detlef Vollmann wrote: >> With this and the other fix I was able to build the complete >> libstdc++ for AVR based on AVR Libc 2.0 (plus some ad hoc >> AVR header fixes) from git master 5e28be89. > > Nice. I finally figure out that I need to use --enable-libstdcxx *not* > --enable-libstdc++-v3 to build for AVR, Yes, I had the same problem. A comment in the 'configure' script still says libstdc++-v3 and in the configure docs at or there's neither :-( > and now I get errors due to > EOVERFLOW being undefined. Is that what you fixed? One of them. > We should make that work. Arguably, all values of std::errc should > exist, even if the OS doesn't provide a constant. We could > define the missing ones ourselves, choosing numbers > 1000 (and hope > the OS uses small numbers for its own errno values). I simply defined all that were required. I've attached a tarball with all my header fixes. To get them picked up while compiling libstdc++ I had to put them into ${prefix}/avr/lib/include. But these are really ad hoc, some of the problems I think should be fixed in the libstdc++ sources. E.g. I think it's wrong to expect that specific functions are available if a respective header is available (e.g. close() in unistd.h). Detlef --------------aARsEUaB4QRWbpyw44aEpOte Content-Type: application/octet-stream; name="avr-fixups.tar.bz2" Content-Disposition: attachment; filename="avr-fixups.tar.bz2" Content-Transfer-Encoding: base64 QlpoOTFBWSZTWQwjxd8ABHN/jMyQAJB5/f//P+//8P/v//4BAAABAAhQBV5mccnDs3d3K7dj SQNEJT2mQTEjQNAMQA0aD1NpMygaBoA0ANCMk/SUpvQBQADQAAGQAAAAAAkSJoCm0yoZGEGg AADQDQAABoGgc0xGRk0yaAZDRkMmQAAAyNMjQMIZAkkE0BJ5NR6SejFGjQ0BoNGg9QDTQA0A bSc34FxhgPyBtlJyCg5kJp0kkbe1obPRnE4RSo6JPfdPGaEJwVCFriYBOFiDpy6Sp9Xty2yk 18oXRuzZuTt5SSSSSTuzMzMzMySSTMzMzPcve5vMzMknAkknWzU6QFQGRU5udtsL7n16f0wd VGtt8ib8J6gp/IVxld+dHKAsEoD8aBXdPZ61gTOct6nA7OayVfpoSG4FPtpfiy4nzY41qmdK qVwvKU82o+tECepkDDEBwpehY2CqbwbGzGwJGu0A2k2fHzwG+0In5IiIiIiIojmuPNyJBa18 qo++GpOf83LHdXmTmOlRfZLP01X2Nug9MVm9GjY5/qwIOmJIbQA/8F8hSzZ2M85uJ23U0Y2+ e0c1gUCL8LnOip5WY7xz3tHZCpBUF6ZkQPuK8TiQ0Q4Ugy8PDp06XTAg3BfPebe3+zEFMKtw oFHcZa73EiC96Agq3a6scbaV2IoNA9mBENFliIG1JqTBtslKJMvE2JkMJMCwYtRkFI8NYCVY EJwa0i8QTAqEdWCDzKIhk0fycq1vMk3gAefIyB1gJASDUmLVqzBgFRFUImuwuMCrwSay7YBF dcilQqhCFgwawIbBYWoDM9G5VcwBqJYhVozyfJRhNxZEkTNJwkuHd3c5lmyZDTjAw2gOSsQu YkAXJjQ5bndYHJVT4p3BYZboDIVqZqWc64tBYLs40SVGOxR8wTs+k664quctKlOSqt+ryMXt 5Foy6IRgwkCuukt1qjEQybQloaVXbVLOPommwqFmEwGl7sHFAc9FEpEMAhz6MLdQSqmqfNCx XNPUCebJRv5Ca+EgWEFaxsa5rjx9qpAolpiKR+pGmUxVglchgedWwAmiQlrjdStRINORQYS8 oCgKqTU5JTSLohFjFm4VVCwnephDJZZQiwU4sKtXBBtCqwbNcY00qiAoqC2W5lnTUBjkXJox y+Jbsi0tAsheqrpYbWIWRjsD32CRmUqd7bOqukY3tQTa0KvSpYapIxMjRQyNFt01W2okmVtG lOhTFsl2y4uYKQyVpSEZlDBjRA9LTV0zyAmquyqZSKUVXTz1lEXuGH46HEWtBVxpqHsDgIbI sAV1Kq5OJDiWsCZROahRuVgweCOoDQwzBWbU2GfwIyvMFjYBGRIxgIxVof6gYyAkev0mjemQ BQYLhGkgF1igap4JjUIZQSj+QSDgp53BMD8OV+cXE/xQBARYB2Zo0TW58OZnJheRhPauop0Q EhFjrgsT8mC4/9fSLZVdFdZU/c1UEgbbNCNoC2uvW1oFPPx7rRJBEw5r9u+HCYV5JNyIahra Qa2KGGR5ikNaKIOEkFO5G9Mw6egvyHFgRM2MqtLH06wsSLkiSp2IdGCdiwHLKVDRk+ZMIeXK wIg+CEg13aFCLFbdNhMCx4GOWhW5ClSgXS1a8A+GDKcHUNIKp3m2KcntV1RJYqIQQJkr4WbV 6nS/GBNrYqk6JKITCcbuBnuCMxSqEODlYrYhAVTKSusQymHbVZroWLmzKFslqFzClnFBVpZX fALkFmZY1kLuSd26kj/i7kinChIBhHi74A== --------------aARsEUaB4QRWbpyw44aEpOte--