From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6738E3861810 for ; Wed, 14 Feb 2024 20:21:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6738E3861810 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6738E3861810 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707942077; cv=none; b=b95D5HYyZjyZUP3LUdXzA645mWWXCa3JBuQkASjeFnF/aBll2yHcXlKwlvgRoy9C2JEnc3Z+F/21K6Z3LcBiD5Tl5Ne7d8wAayEdYBJySUPuD8CQi/HGiBuEgMAUQjDpVkA9bbG6octdH6Wot4JfMI/kctnTxDxor57JHG5Te+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707942077; c=relaxed/simple; bh=aZcWQQuaMTFkUUsGmQzYOrybeEOKLJFE0HoJreXr2as=; h=DKIM-Signature:From:Date:To:Subject:Message-ID:MIME-Version; b=quTbPd/TLy87giVjnOMay04GzJBZCnpohAN2bxd/jU9PARn9fKcbEvHOYBYaZtYT/fbFdk/fjU/qvePiqEJjuCj2ga1vh77iJ2/Am13pYSuLgFs6QG/6M0Rf3u8jB+jc+bWoOcebEzJ8yeKZFsX7+jsPZw/wSsZdbItyeI3fcrY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707942076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3cbJvI/HbWW6u3/LB6nlTmnIE9LJDCAL+HflMUF4OPc=; b=d4Vutq7iYR+NtJA9hLI9L+bZUB9ZdhzvcmRZZHMggJXJ6MDeK3CsIWBrXJHtVTJWucKGHz BPu+RFOkrd5BDf2pyy6/wYYLdXvfL3eiL9oxQRioSR8EBHR4iMlnIaktFQ/I3Qw8KC4P2H QfXp28XXGxl0HYZIbyzkJFWzvg0vKmE= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-356-TnQ_GbE4Oi6tKmA3F_zn_w-1; Wed, 14 Feb 2024 15:21:14 -0500 X-MC-Unique: TnQ_GbE4Oi6tKmA3F_zn_w-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-680b2c9b0ccso2835626d6.1 for ; Wed, 14 Feb 2024 12:21:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707942074; x=1708546874; h=mime-version:references:message-id:in-reply-to:subject:cc:to:date :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3cbJvI/HbWW6u3/LB6nlTmnIE9LJDCAL+HflMUF4OPc=; b=pVxROn0v8LTvcii0wnSjT3BxEBkqtqi4CVRObbRTi5JUYr6qAKs+/rAe0APjQmTF7G f2cwDReiu8dPt5bT50hNHZ4Yd7n6auUgXN6SX76YMUcrVp4Jr7BXvxfIinMf9eArjZfS bWG1b9pPsMB4k3j5rx9n6tncyVVahfSpEXEP2c3W641qKhKsh7rRVp/0U5d8kcVm9qPa 64GF2yQteVWZs7tEnV8Mdt/vR+Xt3o/6alA50K8EN+JmS5BkEGn/ALLM69L3cProt92d sOaaT+9YsfF0eUWZJ8h24VzA/Z0zpk+fQSpSwscZnA2QEf0mVqc2vccF2AVGT0/ZZ7Cy 7b/A== X-Forwarded-Encrypted: i=1; AJvYcCXHYVv4RfpZdsN0Y3OqgJqwDXcepoE9kIMMLHpTZtYGhtnXnSmzPx6MTJ9rXZHe/eTP4UUNNKFJ2qHBB2wxzYj4bzVhloM= X-Gm-Message-State: AOJu0YytbGfXSWl19GazdgS7b6Bu3h+Si47fIOsO0R69bqwD92jvLtWB ixr+xA+av5OHXc/DCeWYpQmWv6vYrZ9Y5LMC4B7dm5SlYuqYDlhhTEPnVw27HlGAy72eOc5nk4y wns1vmetgdMZAhY1XXc2KEh5g42xCW3K7JqrccZhuL6Qd96GpHmLi X-Received: by 2002:a0c:df82:0:b0:68f:f1a:b383 with SMTP id w2-20020a0cdf82000000b0068f0f1ab383mr1431787qvl.8.1707942074431; Wed, 14 Feb 2024 12:21:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IEQZlK5prviP8+KmztDOvM28jWXvf6x2G+VKU4RREY/3R1xRGo6BFqpdK9btEhqomAe0GFRjw== X-Received: by 2002:a0c:df82:0:b0:68f:f1a:b383 with SMTP id w2-20020a0cdf82000000b0068f0f1ab383mr1431771qvl.8.1707942074182; Wed, 14 Feb 2024 12:21:14 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVn5yd6pgFIKjHMcHm8dYctCLvIXHnBKrj/u9N7DCwy3K5aCRnxRhT5hH21Nc6CbpXOBzJftw3lsQiB8tr8CNTia7DaEug= Received: from [192.168.1.130] (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id ma17-20020a0562145b1100b0068d29a0009csm2550402qvb.85.2024.02.14.12.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 12:21:13 -0800 (PST) From: Patrick Palka X-Google-Original-From: Patrick Palka Date: Wed, 14 Feb 2024 15:21:13 -0500 (EST) To: Ken Matsui cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH v2 4/4] libstdc++: Optimize std::remove_extent compilation performance In-Reply-To: <20240214135252.1416047-4-kmatsui@gcc.gnu.org> Message-ID: References: <20240214114448.847646-1-kmatsui@gcc.gnu.org> <20240214135252.1416047-1-kmatsui@gcc.gnu.org> <20240214135252.1416047-4-kmatsui@gcc.gnu.org> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 14 Feb 2024, Ken Matsui wrote: > This patch optimizes the compilation performance of std::remove_extent > by dispatching to the new __remove_extent built-in trait. > > libstdc++-v3/ChangeLog: > > * include/std/type_traits (remove_extent): Use __remove_extent > built-in trait. LGTM > > Signed-off-by: Ken Matsui > --- > libstdc++-v3/include/std/type_traits | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits > index 3bde7cb8ba3..0fb1762186c 100644 > --- a/libstdc++-v3/include/std/type_traits > +++ b/libstdc++-v3/include/std/type_traits > @@ -2064,6 +2064,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > // Array modifications. > > /// remove_extent > +#if _GLIBCXX_USE_BUILTIN_TRAIT(__remove_extent) > + template > + struct remove_extent > + { using type = __remove_extent(_Tp); }; > +#else > template > struct remove_extent > { using type = _Tp; }; > @@ -2075,6 +2080,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > template > struct remove_extent<_Tp[]> > { using type = _Tp; }; > +#endif > > /// remove_all_extents > template > -- > 2.43.0 > >