From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hp@bitrange.com>
Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131])
 by sourceware.org (Postfix) with ESMTPS id 504353874C04;
 Sun, 28 Feb 2021 15:05:57 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 504353874C04
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=bitrange.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hp@bitrange.com
Received: by arjuna.pair.com (Postfix, from userid 3006)
 id B99908A3A7; Sun, 28 Feb 2021 10:05:47 -0500 (EST)
Received: from localhost (localhost [127.0.0.1])
 by arjuna.pair.com (Postfix) with ESMTP id B8FB48A0C7;
 Sun, 28 Feb 2021 10:05:47 -0500 (EST)
Date: Sun, 28 Feb 2021 10:05:47 -0500 (EST)
From: Hans-Peter Nilsson <hp@bitrange.com>
X-X-Sender: hp@arjuna.pair.com
To: Thiago Macieira <thiago.macieira@intel.com>
cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 4/5] barrier: use int instead of unsigned char for the
 phase state
In-Reply-To: <20210226155937.621324-4-thiago.macieira@intel.com>
Message-ID: <alpine.BSF.2.20.16.2102281004450.52464@arjuna.pair.com>
References: <1968544.UC5HiB4uFJ@tjmaciei-mobl1>
 <20210226155937.621324-1-thiago.macieira@intel.com>
 <20210226155937.621324-4-thiago.macieira@intel.com>
User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libstdc++@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libstdc++ mailing list <libstdc++.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/libstdc++/>
List-Post: <mailto:libstdc++@gcc.gnu.org>
List-Help: <mailto:libstdc++-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Feb 2021 15:05:59 -0000

On Fri, 26 Feb 2021, Thiago Macieira via Gcc-patches wrote:
> ints can be used in futexes. chars can't.

Shouldn't that be an atomic type instead of a bare int then?

> ---
>  libstdc++-v3/include/std/barrier | 21 ++++++++++++---------
>  1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/libstdc++-v3/include/std/barrier b/libstdc++-v3/include/std/barrier
> index e09212dfcb9..ae058bd3dc3 100644
> --- a/libstdc++-v3/include/std/barrier
> +++ b/libstdc++-v3/include/std/barrier
> @@ -70,7 +70,7 @@ It looks different from literature pseudocode for two main reasons:
>
>  */
>
> -  enum class __barrier_phase_t : unsigned char { };
> +  enum class __barrier_phase_t : int { };

brgds, H-P