From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hp@bitrange.com>
Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131])
 by sourceware.org (Postfix) with ESMTPS id 861D93858292;
 Tue,  5 Jul 2022 00:58:37 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 861D93858292
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=bitrange.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bitrange.com
Received: by arjuna.pair.com (Postfix, from userid 3006)
 id D1EAB8A54A; Mon,  4 Jul 2022 20:58:36 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1])
 by arjuna.pair.com (Postfix) with ESMTP id D16618A547;
 Mon,  4 Jul 2022 20:58:36 -0400 (EDT)
Date: Mon, 4 Jul 2022 20:58:36 -0400 (EDT)
From: Hans-Peter Nilsson <hp@bitrange.com>
X-X-Sender: hp@arjuna.pair.com
To: Xi Ruoyao <xry111@xry111.site>
cc: gcc-patches@gcc.gnu.org, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>, 
 Jonathan Wakely <jwakely@redhat.com>, libstdc++@gcc.gnu.org
Subject: Re: [PATCH v2 1/7] config: use $EGREP instead of egrep
In-Reply-To: <227ea157c8576df47a9d016f5f25b7c6feaee53e.camel@xry111.site>
Message-ID: <alpine.BSF.2.20.16.2207042056270.55051@arjuna.pair.com>
References: <fb82297845486b14d51905ae3df8dbba726fcf57.camel@xry111.site>
 <227ea157c8576df47a9d016f5f25b7c6feaee53e.camel@xry111.site>
User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libstdc++@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libstdc++ mailing list <libstdc++.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/libstdc++/>
List-Post: <mailto:libstdc++@gcc.gnu.org>
List-Help: <mailto:libstdc++-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jul 2022 00:58:38 -0000

On Mon, 27 Jun 2022, Xi Ruoyao via Gcc-patches wrote:
> egrep has been deprecated in favor of grep -E for a long time, and the
> next GNU grep release (3.8 or 4.0) will print a warning if egrep is used.
> Unfortunately, old hosts with non-GNU grep may lack the support for -E
> option.  Use AC_PROG_EGREP and $EGREP variable so we'll work fine on
> both old and new platforms.
>
> ChangeLog:
>
> 	* configure.ac: Call AC_PROG_EGREP, and use $EGREP instead of
> 	egrep.

Nit of the day:

> diff --git a/config/lib-link.m4 b/config/lib-link.m4
> index 20e281fd323..5bbbd999de0 100644
> --- a/config/lib-link.m4
> +++ b/config/lib-link.m4
> @@ -99,8 +99,10 @@ AC_DEFUN([AC_LIB_RPATH],
>    AC_REQUIRE([AC_LIB_PROG_LD])            dnl we use $LD, $with_gnu_ld
>    AC_REQUIRE([AC_CANONICAL_HOST])         dnl we use $host
>    AC_REQUIRE([AC_CONFIG_AUX_DIR_DEFAULT]) dnl we use $ac_aux_dir
> +  AC_REQUIRE([AC_PROG_EGREP])             dnl we use $GREP

Shouldn't that be "we use $EGREP"?

brgds, H-P