From: Marc Glisse <marc.glisse@inria.fr>
To: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Cc: "François Dumont" <frs.dumont@gmail.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: std::vector default default and move constructors
Date: Thu, 11 Jan 2018 07:03:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1801110801170.5897@stedding.saclay.inria.fr> (raw)
In-Reply-To: <alpine.DEB.2.21.1801110748090.5897@stedding.saclay.inria.fr>
On Thu, 11 Jan 2018, Marc Glisse wrote:
> On Thu, 11 Jan 2018, François Dumont wrote:
>
> - void _M_swap_data(_Vector_impl& __x) _GLIBCXX_NOEXCEPT
> + void
> + _M_swap_data(_Vector_impl_data& __x) _GLIBCXX_NOEXCEPT
> {
> std::swap(_M_start, __x._M_start);
> std::swap(_M_finish, __x._M_finish);
> std::swap(_M_end_of_storage, __x._M_end_of_storage);
> }
>
>
> I don't remember earlier discussions about this patch, but is this piece of
> code still needed? std::swap(*this, __x) looks like it should work.
Ah, no, there is a non-trivial move constructor, so forget it. I'll still
need to rewrite that function later :-(
--
Marc Glisse
next prev parent reply other threads:[~2018-01-11 7:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-23 17:41 François Dumont
2017-07-28 16:46 ` François Dumont
2017-08-21 19:16 ` François Dumont
2017-09-04 19:47 ` François Dumont
2018-01-11 6:41 ` François Dumont
2018-01-11 6:57 ` Marc Glisse
2018-01-11 7:03 ` Marc Glisse [this message]
2018-01-14 21:13 ` François Dumont
2018-01-15 12:29 ` Jonathan Wakely
2018-01-15 21:33 ` François Dumont
2018-01-16 0:20 ` Jonathan Wakely
2018-01-18 21:01 ` François Dumont
2018-01-29 13:49 ` Jonathan Wakely
2018-06-02 12:01 ` François Dumont
2018-06-26 13:46 ` Jonathan Wakely
2018-06-27 20:27 ` François Dumont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1801110801170.5897@stedding.saclay.inria.fr \
--to=marc.glisse@inria.fr \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).