From: "Martin Storsjö" <martin@martin.st>
To: Liu Hao <lh_mouse@126.com>
Cc: libstdc++@gcc.gnu.org, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: Fwd: libstdc++: Attempt to resolve PR83562
Date: Fri, 6 Nov 2020 10:34:56 +0200 (EET) [thread overview]
Message-ID: <alpine.DEB.2.23.453.2011061034110.15776@cone.martin.st> (raw)
In-Reply-To: <e5df157c-5d36-ee18-925e-a79a12f49331@126.com>
On Fri, 6 Nov 2020, Liu Hao via Gcc-patches wrote:
> 在 2020/10/29 下午3:56, Liu Hao 写道:
>> I forward it here for comments.
>>
>> Basing on the behavior of both GCC and Clang, `__cxa_thread_atexit` is used to register the
>> destructor of thread_local objects directly, suggesting the first parameter should have `__thiscall`
>> convention.
>>
>> libstdc++ used the default `__cdecl` convention and caused crashes on 1686-w64-mingw32 (see
>> PR83562). But to my surprise, libcxxabi uses `__cdecl` too [1], but I haven't heard any of relevant
>> reports so far.
>>
>> Original patch is attached in case you can't find it in gcc-patches.
>>
FWIW, this patch looks good and correct to me, from a mingw perspective.
// Martin
prev parent reply other threads:[~2020-11-06 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3d535e7a-95dc-050f-b1d6-9802436cc669@126.com>
2020-10-29 7:56 ` Liu Hao
2020-11-06 8:23 ` Liu Hao
2020-11-06 8:34 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.23.453.2011061034110.15776@cone.martin.st \
--to=martin@martin.st \
--cc=gcc-patches@gcc.gnu.org \
--cc=lh_mouse@126.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).