public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Patrick Palka <ppalka@redhat.com>
Cc: Jonathan Wakely <jwakely@redhat.com>,
	Jonathan Wakely via Libstdc++ <libstdc++@gcc.gnu.org>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation
Date: Mon, 21 Dec 2020 23:09:05 +0000 (GMT)	[thread overview]
Message-ID: <alpine.LFD.2.21.2012212307440.1637534@eddie.linux-mips.org> (raw)
In-Reply-To: <b4135452-06e-683-fc51-2f781eca8a78@idea>

On Mon, 21 Dec 2020, Patrick Palka wrote:

> >  This breaks with the `vax-netbsdelf' target in GCC compilation:
> > 
> > .../libstdc++-v3/src/c++17/floating_to_chars.cc:126:38: error: static assertion failed
> >   126 |       static_assert(__DBL_MANT_DIG__ == 53);
> >       |                                      ^
> > make[5]: *** [Makefile:577: floating_to_chars.lo] Error 1
> > 
> > So what's the fallback/alternative for non-IEEE-754 FP targets?  Shouldn't 
> > we call into libc (possibly with a warning attribute) for the formats we 
> > don't have explicit handcoded support for?
> 
> Sorry about this bootstrap breakage.  For now, we should probably just
> disable the entire file/implementation on such targets until a proper
> fallback could be implemented.  I posted a patch to that effect here
> https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562379.html
> which is pending review/approval.  Until then, manually stubbing out all of
> floating_to_chars.cc should probably suffice to restore bootstrap on
> this target.

 No worries, breakage happens, especially with the more obscure areas we 
support.  Thanks for the quick fix!

  Maciej

  reply	other threads:[~2020-12-21 23:09 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 19:41 [PATCH 1/4] libstdc++: Import parts of the Ryu library Patrick Palka
2020-07-14 19:41 ` [PATCH 2/4] libstdc++: Apply modifications to our local copy of Ryu Patrick Palka
2020-07-15 18:12   ` Patrick Palka
2020-12-17 14:35     ` Jonathan Wakely
2020-07-14 19:41 ` [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation Patrick Palka
2020-07-15 18:21   ` Patrick Palka
2020-07-17  4:23     ` Patrick Palka
2020-07-17 16:24       ` Patrick Palka
2020-07-20  3:37         ` Patrick Palka
2020-07-20 12:31           ` Jonathan Wakely
2020-07-20 12:53             ` Patrick Palka
2020-07-20 14:13               ` Jonathan Wakely
2020-07-20 14:46                 ` Patrick Palka
2020-07-22 15:56                   ` Patrick Palka
2020-08-19 21:57                     ` Patrick Palka
2020-12-17 14:32                       ` Jonathan Wakely
2020-12-18  4:13                         ` Patrick Palka
2020-12-18 13:24                           ` Christophe Lyon
2020-12-18 14:58                             ` Jonathan Wakely
2020-12-18 15:00                             ` Patrick Palka
2020-12-18 16:52                               ` Christophe Lyon
2020-12-18 17:03                                 ` Patrick Palka
2020-12-18 18:28                                   ` Christophe Lyon
2020-12-20 21:44                           ` Maciej W. Rozycki
2020-12-21 17:06                             ` Patrick Palka
2020-12-21 23:09                               ` Maciej W. Rozycki [this message]
2020-07-14 19:41 ` [PATCH 4/4] libstdc++: Import MSVC floating-point std::to_chars testcases Patrick Palka
2020-07-14 19:49   ` Patrick Palka
2020-12-17 14:37   ` Jonathan Wakely
2020-07-14 19:46 ` [PATCH 1/4] libstdc++: Import parts of the Ryu library Patrick Palka
2020-07-25 11:44 ` Václav Haisman
2020-07-26 13:09   ` Patrick Palka
2020-12-17 14:34 ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.21.2012212307440.1637534@eddie.linux-mips.org \
    --to=macro@linux-mips.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    --cc=ppalka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).