From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8C33D3858C3A for ; Tue, 26 Oct 2021 14:19:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8C33D3858C3A Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-49-12CnlIngN0qpQIeeT3a_rg-1; Tue, 26 Oct 2021 10:19:57 -0400 X-MC-Unique: 12CnlIngN0qpQIeeT3a_rg-1 Received: by mail-qv1-f71.google.com with SMTP id gw8-20020a0562140f0800b0038366347de1so13649729qvb.16 for ; Tue, 26 Oct 2021 07:19:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=omAfsa2r51N1dnaIkBtQPBS71nxSufW8dDHm7hPblt0=; b=77yKbYuvaZzi6jO+LnatC02ToSf9HxVsqy7rC3dEi9H+8vuxoxCPQCXP/lJS+8fe+w RQmnpJoQD9tMS9ctYvkBD8XzkGfeXh8fQFrfg0NbNni8Ipde0Bwq6PfiBJlDZUIXWIRA x1rhn5D9MstYkI1YQqTsxF3i12huk/S0YJrfGCKKOzV27lteVBvN9ZJYldHKs9f7kQEF kRO3zaPtP9zFwxrgGPa0SJdkF5ZNwPIMLUG+wej4QdJCGxTd+kkDv9I2/BPLyjfQCIEJ ZIrqleL1/xfAmdUJi/nywnO3368+F097VeTeK6vOe4Nok1RXMffIseQ2FtjR0GxICVMs JXQw== X-Gm-Message-State: AOAM531bSMLAu9u19sFiKNNXzKQHaqC1xT13xzn9bkjwTP49mFH1ASdC aIgB2eKlO7lUi5r6gLPKsaSPnn7ciCrD2a6cPKABBtQFjiqVqrU8naI9CMAFkQAoHZM+KsTfvCV C04gWsej+ueCv9Lw= X-Received: by 2002:a05:620a:45a4:: with SMTP id bp36mr19351861qkb.51.1635257996196; Tue, 26 Oct 2021 07:19:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQhNZNTe8UJQBcvkC2gi8896yhRrBEW8Z7RU+64etWeSTpPGS3zA2phrTTeVpgGrdtkSqryg== X-Received: by 2002:a05:620a:45a4:: with SMTP id bp36mr19351830qkb.51.1635257995881; Tue, 26 Oct 2021 07:19:55 -0700 (PDT) Received: from [192.168.1.149] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id f21sm11679014qtk.51.2021.10.26.07.19.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Oct 2021 07:19:54 -0700 (PDT) Message-ID: Date: Tue, 26 Oct 2021 10:19:54 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2] c++tools: Fix memory leak To: Jonathan Wakely Cc: libstdc++ , gcc Patches References: <20211021132834.636383-1-jwakely@redhat.com> <2dfa49c9-d55e-8169-616a-ff48a957fb61@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Oct 2021 14:19:59 -0000 On 10/21/21 17:34, Jonathan Wakely wrote: > On Thu, 21 Oct 2021 at 20:38, Jason Merrill wrote: > > On 10/21/21 09:28, Jonathan Wakely wrote: > >   #else > >     buffer = xmalloc (stat.st_size); > >     if (!buffer) > >       return -errno; > > +  struct Deleter { void operator()(void* p) const { free(p); } }; > > +  std::unique_ptr guard; > > Don't you need to initialize guard from buffer? > > > Oops, yes!  Updated patch attached. OK, thanks. Jason