From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id C70AF3861893; Mon, 13 May 2024 05:06:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C70AF3861893 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C70AF3861893 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715576821; cv=none; b=SEhkXHUSKvr9akEQ+MIqCOWHI4dD3CKiuB7yJ+MXlsKNkDVnd5KKMvsjlnUk+LrZn8/LK26rF3E/qkmNMF+5H4nkKu22S+pqUBlFjDvWgWPwe0VTDkOv/mbqoLH2BQY6UrsE6R6OTLUe5VXg2SMf0NBlbxZ25Tc2g7DlgrchWzQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715576821; c=relaxed/simple; bh=IOYH1gj6sUNZz5PNxvodCIIurCVGDUq5E3oBSJGkkVs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=W5XDNAVMxQ1AS4JkWwGBV3w2junSVcljCSU1XQ/E3s3mM0TUf3vkH/A6c85y15+iPhO+8hlwfUz6h6IWVCP6qBdrcoBpVrtVA39jaLB5uzZ/vnF7nLgF5WhezK4L4ykhGYnnksk3FyJXmwF14VC5ZKkJzH0npJ/f819+cwaj3/w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-34e28e32ea4so2455691f8f.2; Sun, 12 May 2024 22:06:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715576818; x=1716181618; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JfieAQk3I2m9IEzeU62k9j33x1tmDyZQMTIwS0BrCe8=; b=BIyytoi+wF7uixnOGm+2N04Dd+AeMoFqPr34TlS4DuVhFZtOpt8UP2gVVjp7DybBOL +ztWcRZfZdI8qlcxgcL21Vw4NQyW+fJREl5daWtCs40GFEUthVW50GRTxMonUCjGUYyj /uk5/rR/9LFdjz1VVckiQzYJe5FFua+EfObw/053gdXwJJHiTHvb2Uc5aH6XsvMgvka5 b4k2eFS41KMy3x80Qgv4cCWsaMviZFefuK70IBT7pSxDYIIMkoMUalcqkSD6LEAIrvGn +drAXbvKfRq3H+I//HbNdDqGw0eMLSUi90dEPDiT3H8yLbLcBXPzxcRy43e/22mhzWka 7L8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715576818; x=1716181618; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JfieAQk3I2m9IEzeU62k9j33x1tmDyZQMTIwS0BrCe8=; b=ENiCLaQTzgxv74EZ4rZ/LkZPR3JuCdxEuaTGlynFyfSDChK/BDHGEy65pbdfcxaodn pfEaYY+MpHNcAubAlV9kjFzZWsyfkb+WtSGH8+tcOtXXTLysP6xYbnRqK29xYjbWe42N hU27/T4GWYBICkQ2NFJ8J7VbqhGJ/UmbeA6it0u4B42AxT+8majA3oZO/U/+4gJ2pVzL I1FewQ8SZosRAwFRNBinPtq2EzTOvYB3vRB9f7bfEcF2sf96+gTE8GsrDogl2jxGMIrY jDzwhjYfyeWQIACFGbzXw8EB3rlh7NJgq8ATsS3bCqI54xRCpJvDx/NWxnokeDXR596t /PXQ== X-Forwarded-Encrypted: i=1; AJvYcCUC/EqX/c/b6dhuzt3JGR4eLIlLr9jamcBkCeAmHbroiZYWBtQ1IFOMb54Mq2tixhqEUHXDddiqurmY0WNvwIVctJVFOYve6w== X-Gm-Message-State: AOJu0YzQ0MDL5NdXmrbk6oYF5/LTjGXkGp8osRDIUtOa/t8rZ7Zs2ivW Np/KrLYoIYtf5/sJuqACLia6V7eIUktAG6iSyRAx2e6xMHWxoc3TrcruUgzq X-Google-Smtp-Source: AGHT+IGfm61Ytc2eAep8u2ex1hB4zL0HrqgGQDefsIqX5LPhWwJD35VkAv+l1cgofvuV4EMalIISow== X-Received: by 2002:adf:e80b:0:b0:34d:9161:3a9d with SMTP id ffacd0b85a97d-3504a737d0emr6051786f8f.19.1715576818309; Sun, 12 May 2024 22:06:58 -0700 (PDT) Received: from [10.52.0.53] ([89.207.171.131]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3502b896a29sm10145020f8f.43.2024.05.12.22.06.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 May 2024 22:06:57 -0700 (PDT) Message-ID: Date: Mon, 13 May 2024 07:06:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Fix gnu versioned namespace mode 00/03 To: Iain Sandoe Cc: libstdc++ , GCC Patches References: <08F3F058-B58A-4FC2-B83E-A0B271791C39@googlemail.com> Content-Language: en-US From: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= In-Reply-To: <08F3F058-B58A-4FC2-B83E-A0B271791C39@googlemail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 07/05/2024 18:15, Iain Sandoe wrote: > Hi François > >> On 4 May 2024, at 22:11, François Dumont wrote: >> >> Here is the list of patches to restore gnu versioned namespace mode. >> >> 1/3: Bump gnu version namespace >> >> This is important to be done first so that once build of gnu versioned namespace is fixed there is no chance to have another build of '__8' version with a different abi than last successful '__8' build. >> >> 2/3: Fix build using cxx11 abi for versioned namespace >> >> 3/3: Proposal to default to "new" abi when dual abi is disabled and accept any default-libstdcxx-abi either dual abi is enabled or not. >> >> All testsuite run for following configs: >> >> - dual abi >> >> - gcc4-compatible only abi >> >> - new only abi >> >> - versioned namespace abi > At the risk of delaying this (a bit) - I think we should also consider items like once_call that have broken impls. Do you have any pointer to this once_call problem, sorry I'm not aware about it (apart from your messages). > in the current library - and at least get proposed replacements available behind the versioned namespace; rather than using up a namespace version with the current broken code. I'm not proposing to fix all library bugs on all platforms with this patch, just fix the versioned namespace mode. As to do so I also need to adopt cxx11 abi in versioned mode it already justify a bump of version. > > I have a proposed once_call replacement (but I think Jonathan also has one or more alternatives there) > > Please can we try to identify any other similar blocked fixes? How ? We can only count on bugzilla bug reports to do so, no ? If we face another similar problem in the future, after gcc 15 release, then we'll just have to bump again. Is it such a problem ? The reason I'm proposing to integrate this patch this early in gcc 15 stage is to have time to integrate any other library fix/optimization that could make use of it. I already have 1 on my side for the hashtable implementation. I hope your once_call fix also have time to be ready for gcc 15, no ? François