From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 4C0623839C78; Tue, 1 Jun 2021 20:00:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4C0623839C78 Received: by mail-wr1-x431.google.com with SMTP id g17so15528611wrs.13; Tue, 01 Jun 2021 13:00:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Nm4H5kmwwssUoxcpR9SB4/B6+jN4crMpTGVrnZyA/AE=; b=oUB1LO7eHKXzlrhAW9UpeSy9nXFLORwQBVNUVDfZjlFQlLLUANRPFYySU9l7lmZ1bL SmqWtTp2RRAB5GV3StZAp0DZ8aNzIoa/skfNP9DbGH0XjwA3w/U3Ox6Lr8lBMsZtAmSW pb5/2cwytNpqR/PO2MLsk8csyDSX/F94XQ6TiLeWEUcwVy9bqWMtHxBdfhKNmFWZNCdP Y6JE1Pg6hP/1eHdY4PJ2L4pHEy+aSTcrGd4N4S/kEDM9snLQCIkibbcNcIMBJ9/buph4 uNZPjA4DDRXahqTBoumejIs1uLiChkHRcT4nyVwQdf7QOUCJ4pztRZeBz4LSYN1dXzix bvqA== X-Gm-Message-State: AOAM531LERoEMGHy1bBB0jH69kQRMEd5skZGPv3mlNunipbXL1Hh7k5L m3iZAWKzsSToWy9fXsUYdic/cj6f8ROICw== X-Google-Smtp-Source: ABdhPJzT5RS7/LfaY/ctZAP35L01euitMDnB04M+bJKZ3ch3dnnWZZF6ShlGODLVerZtnQLfoukEVw== X-Received: by 2002:adf:d20a:: with SMTP id j10mr28724741wrh.188.1622577638076; Tue, 01 Jun 2021 13:00:38 -0700 (PDT) Received: from ?IPv6:2a01:e0a:1dc:b1c0:a1fe:f813:c366:286d? ([2a01:e0a:1dc:b1c0:a1fe:f813:c366:286d]) by smtp.googlemail.com with ESMTPSA id s1sm498438wmj.8.2021.06.01.13.00.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jun 2021 13:00:37 -0700 (PDT) Subject: Re: [PATCH] Hashtable PR96088 To: Jonathan Wakely Cc: Jonathan Wakely , libstdc++ , gcc-patches References: <21854fd0-ad6b-1eaa-adaa-2074421fc107@gmail.com> <7bd748f6-77bd-fdcc-f925-1700ac9da3de@gmail.com> <50b5f8f5-56a3-57a5-2e03-b23118a1a2c5@gmail.com> From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= Message-ID: Date: Tue, 1 Jun 2021 22:00:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Content-Language: fr X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2021 20:00:40 -0000 On 01/06/21 8:10 pm, Jonathan Wakely wrote: > On 01/06/21 18:47 +0100, Jonathan Wakely wrote: >> On 01/06/21 18:45 +0100, Jonathan Wakely wrote: >>> On 22/05/21 18:35 +0200, François Dumont wrote: >>>> diff --git >>>> a/libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc >>>> b/libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc >>>> new file mode 100644 >>>> index 00000000000..53bb754dab6 >>>> --- /dev/null >>>> +++ b/libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc >>>> @@ -0,0 +1,271 @@ >>>> +// { dg-do run { target c++11 } } >>>> + >>>> +// Copyright (C) 2021 Free Software Foundation, Inc. >>>> +// >>>> +// This file is part of the GNU ISO C++ Library.  This library is >>>> free >>>> +// software; you can redistribute it and/or modify it under the >>>> +// terms of the GNU General Public License as published by the >>>> +// Free Software Foundation; either version 3, or (at your option) >>>> +// any later version. >>>> + >>>> +// This library is distributed in the hope that it will be useful, >>>> +// but WITHOUT ANY WARRANTY; without even the implied warranty of >>>> +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>> +// GNU General Public License for more details. >>>> + >>>> +// You should have received a copy of the GNU General Public >>>> License along >>>> +// with this library; see the file COPYING3.  If not see >>>> +// . >>>> + >>>> +// libstdc++/96088 >>>> + >>>> +#include >>> >>> This is a c++11 test, but it uses . >>> >>> The test fails for make check >>> RUNTESTFLAGS=--target_board=unix/-std=gnu++11 >>> >>> I assume it should use { target c++17 } instead? >> >> Same for 23_containers/unordered_map/96088.cc > > I've pushed this fix. > > Tested x86_64-linux. > > I wonder why the same in unordered_multimap/unordered_multiset are not wrong too. Thanks