From: "François Dumont" <frs.dumont@gmail.com>
To: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH][_GLIBCXX_INLINE_VERSION] Adapt to_chars/from_chars symbols
Date: Mon, 28 Nov 2022 07:07:07 +0100 [thread overview]
Message-ID: <bd8a96c6-216d-d774-8356-dad6c9150f15@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
This patch is fixing those tests:
20_util/to_chars/float128_c++23.cc
std/format/formatter/requirements.cc
std/format/functions/format.cc
std/format/functions/format_to_n.cc
std/format/functions/size.cc
std/format/functions/vformat_to.cc
std/format/string.cc
Note that symbols used in <format> for __ibm128 and __iee128 are untested.
I even wonder if the normal mode ones are because I cannot find the
symbols used in gnu.ver.
libstdc++: [_GLIBCXX_INLINE_VERSION] Add to_chars/from_chars
symbols export
libstdc++-v3/ChangeLog
* include/std/format [_GLIBCXX_INLINE_VERSION](to_chars):
Adapt __asm symbol
specifications.
* config/abi/pre/gnu-versioned-namespace.ver: Add
to_chars/from_chars symbols
export.
Ok to commit ?
François
[-- Attachment #2: symbols.patch --]
[-- Type: text/x-patch, Size: 3300 bytes --]
diff --git a/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver b/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver
index 06ccaa80a58..7fc81514808 100644
--- a/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver
+++ b/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver
@@ -142,6 +142,12 @@ GLIBCXX_8.0 {
_ZN14__gnu_parallel9_Settings3getEv;
_ZN14__gnu_parallel9_Settings3setERS0_;
+ # to_chars/from_chars _Float128
+ _ZNSt3__88to_charsEPcS0_DF128_;
+ _ZNSt3__88to_charsEPcS0_DF128_NS_12chars_formatE;
+ _ZNSt3__88to_charsEPcS0_DF128_NS_12chars_formatEi;
+ _ZNSt3__810from_charsEPKcS1_RDF128_NS_12chars_formatE;
+
local:
*;
};
diff --git a/libstdc++-v3/include/std/format b/libstdc++-v3/include/std/format
index 23ffbdabed8..a05f3981622 100644
--- a/libstdc++-v3/include/std/format
+++ b/libstdc++-v3/include/std/format
@@ -1248,27 +1248,51 @@ namespace __format
// Make them available as std::__format::to_chars.
to_chars_result
to_chars(char*, char*, __ibm128) noexcept
+# if !_GLIBCXX_INLINE_VERSION
__asm("_ZSt8to_charsPcS_e");
+# else
+ __asm("_ZNSt3__88to_charsEPcS0_e");
+# endif
to_chars_result
to_chars(char*, char*, __ibm128, chars_format) noexcept
+# if !_GLIBCXX_INLINE_VERSION
__asm("_ZSt8to_charsPcS_eSt12chars_format");
+# else
+ __asm("_ZNSt3__88to_charsEPcS0_eNS_12chars_formatE");
+# endif
to_chars_result
to_chars(char*, char*, __ibm128, chars_format, int) noexcept
+# if !_GLIBCXX_INLINE_VERSION
__asm("_ZSt8to_charsPcS_eSt12chars_formati");
+# else
+ __asm("_ZNSt3__88to_charsEPcS0_eNS_12chars_formatEi");
+# endif
#elif __cplusplus == 202002L
to_chars_result
to_chars(char*, char*, __ieee128) noexcept
+# if !_GLIBCXX_INLINE_VERSION
__asm("_ZSt8to_charsPcS_u9__ieee128");
+# else
+ __asm("_ZNSt3__88to_charsEPcS0_DF128_");
+# endif
to_chars_result
to_chars(char*, char*, __ieee128, chars_format) noexcept
+# if !_GLIBCXX_INLINE_VERSION
__asm("_ZSt8to_charsPcS_u9__ieee128St12chars_format");
+# else
+ __asm("_ZNSt3__88to_charsEPcS0_u9__ieee128NS_12chars_formatE");
+# endif
to_chars_result
to_chars(char*, char*, __ieee128, chars_format, int) noexcept
+# if !_GLIBCXX_INLINE_VERSION
__asm("_ZSt8to_charsPcS_u9__ieee128St12chars_formati");
+# else
+ __asm("_ZNSt3__88to_charsEPcS0_u9__ieee128NS_12chars_formatEi");
+# endif
#endif
#elif defined _GLIBCXX_LDOUBLE_IS_IEEE_BINARY128
@@ -1288,15 +1312,27 @@ namespace __format
// Make them available as std::__format::to_chars.
to_chars_result
to_chars(char*, char*, _Float128) noexcept
+# if !_GLIBCXX_INLINE_VERSION
__asm("_ZSt8to_charsPcS_DF128_");
+# else
+ __asm("_ZNSt3__88to_charsEPcS0_DF128_");
+# endif
to_chars_result
to_chars(char*, char*, _Float128, chars_format) noexcept
+# if !_GLIBCXX_INLINE_VERSION
__asm("_ZSt8to_charsPcS_DF128_St12chars_format");
+# else
+ __asm("_ZNSt3__88to_charsEPcS0_DF128_NS_12chars_formatE");
+# endif
to_chars_result
to_chars(char*, char*, _Float128, chars_format, int) noexcept
+# if !_GLIBCXX_INLINE_VERSION
__asm("_ZSt8to_charsPcS_DF128_St12chars_formati");
+# else
+ __asm("_ZNSt3__88to_charsEPcS0_DF128_NS_12chars_formatEi");
+# endif
# endif
#endif
next reply other threads:[~2022-11-28 6:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 6:07 François Dumont [this message]
2022-11-28 10:10 ` Jonathan Wakely
2022-11-28 10:21 ` Jonathan Wakely
2022-11-28 18:43 ` François Dumont
2022-11-28 18:45 ` François Dumont
2022-11-28 18:35 ` Jonathan Wakely
2022-11-28 20:44 ` François Dumont
2023-01-12 12:05 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd8a96c6-216d-d774-8356-dad6c9150f15@gmail.com \
--to=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).