From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id DE2A23858D33; Sun, 10 Sep 2023 13:56:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE2A23858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4018af1038cso39361755e9.0; Sun, 10 Sep 2023 06:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694354172; x=1694958972; darn=gcc.gnu.org; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=FDJtHpMd1rx2yxIcWaI4kHwFDGS5fmd5n/xs8GeBalQ=; b=cH5a1dpI9UhHFUDCBo1dSBeViGdQNzZRxcbql+WlCb+PyESc1PgMsvZ9bq9QHBI8QT i6NzW2LCPJ+ufusqiI7CVc7zrWF4a/gnjoqpQOnhVQvF84IJu9VoFcWu1GyROBREvT4M cdrDzaH+K7EMtkJ0igeXsCPjq9qi1xKs77TeUOpG7DFt4YK514orwGTGUtWDRNiujCLH actuJkRg/5seeUNTtRbjypC+EzsfDafQkscj2JhZmselU5meDoLEyGE9EznY11ulPJt4 f4Phy3m5jPf3sLozALWVUlnVypIKcnWjzmMFRmGh8YAFfdL9N+7eOFhAQcoRWmNn3Pcl XI9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694354172; x=1694958972; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FDJtHpMd1rx2yxIcWaI4kHwFDGS5fmd5n/xs8GeBalQ=; b=ZF6oMvUpZPKu8S8+FEuazCGyf8a39Ymcce7l/Tjgzfhq1AaFoQoInAQ6l+JXGi8hVn dXBjCgVLw6HbXA2IUaQx5FBCRMQWvr6Tvo06FeW++fP0U5WCJQdUu/U/tuQgSDH94yLS dCQgEgnwyPuXL7hD0AN8NoaJI1hpLr4zCmUJZgFVsy4gMfolj3VBL1160jHT7nW/NcMH UeARXlW5zlI+CCWK8ifiLfqEe6lMy7lvoPcusfz/ItT/HGFqfi4zCXUEjHLx7lBErQ7/ W58Ri97I45SWIwRHDPwbTrEm2g06Li9j3giRQqJCzc+6FNyKQ1aWyyCLu4zSWevXa1E1 XvNw== X-Gm-Message-State: AOJu0YyGpJEpe1c9u+FryQC0yO7nImFmwCm7YajDDzAwVMv47s+VzkZr sEId0rSKTgn9Epoz6LiXAEXIUJRbNFw= X-Google-Smtp-Source: AGHT+IFc/otkvC8JOeQpHD7r+IhfxOSnsoAsoSN52GDHza45dp0OMMI7AL1p3Fnu9rvZlaiJm7/T4Q== X-Received: by 2002:a05:600c:1c98:b0:400:57d1:4915 with SMTP id k24-20020a05600c1c9800b0040057d14915mr6655788wms.37.1694354172374; Sun, 10 Sep 2023 06:56:12 -0700 (PDT) Received: from ?IPV6:2a01:e0a:1dc:b1c0:53f:e49b:d21d:e117? ([2a01:e0a:1dc:b1c0:53f:e49b:d21d:e117]) by smtp.gmail.com with ESMTPSA id d13-20020adff84d000000b00317909f9985sm7340499wrq.113.2023.09.10.06.56.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Sep 2023 06:56:11 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------SOJpupV01k2XUF0U4p7oqMx5" Message-ID: Date: Sun, 10 Sep 2023 15:56:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US To: libstdc++ Cc: gcc-patches From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= Subject: [PATCH] [11/12/13/14 Regression] ABI break in _Hash_node_value_base since GCC 11 [PR 111050] X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------SOJpupV01k2XUF0U4p7oqMx5 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Following confirmation of the fix by TC here is the patch where I'm simply adding a 'constexpr' on _M_next(). Please let me know this ChangeLog entry is correct. I would prefer this patch to be assigned to 'TC' with me as co-author but I don't know how to do such a thing. Unless I need to change my user git identity to do so ?     libstdc++: Add constexpr qualification to _Hash_node::_M_next() https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=1b6f0476837205932613ddb2b3429a55c26c409d     changed _Hash_node_value_base to no longer derive from _Hash_node_base, which means     that its member functions expect _M_storage to be at a different offset. So explosions     result if an out-of-line definition is emitted for any of the member functions (say,     in a non-optimized build) and the resulting object file is then linked with code built     using older version of GCC/libstdc++.     libstdc++-v3/ChangeLog:             * include/bits/hashtable_policy.h             (_Hash_node_value_base<>::_M_valptr(), _Hash_node_value_base<>::_M_v())             Add [[__gnu__::__always_inline__]].             (_Hash_node<>::_M_next()): Add constexpr.     Co-authored-by: TC Ok to commit and backport to GCC 11, 12, 13 branches ? François --------------SOJpupV01k2XUF0U4p7oqMx5 Content-Type: text/x-patch; charset=UTF-8; name="pr111050.patch" Content-Disposition: attachment; filename="pr111050.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My9pbmNsdWRlL2JpdHMvaGFzaHRhYmxlX3BvbGlj eS5oIGIvbGlic3RkYysrLXYzL2luY2x1ZGUvYml0cy9oYXNodGFibGVfcG9saWN5LmgKaW5k ZXggMzQ3ZDQ2OGVhODYuLjEwMWM1ZWI2MzljIDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMv aW5jbHVkZS9iaXRzL2hhc2h0YWJsZV9wb2xpY3kuaAorKysgYi9saWJzdGRjKystdjMvaW5j bHVkZS9iaXRzL2hhc2h0YWJsZV9wb2xpY3kuaApAQCAtMzI3LDE4ICszMjcsMjIgQEAgbmFt ZXNwYWNlIF9fZGV0YWlsCiAKICAgICAgIF9fZ251X2N4eDo6X19hbGlnbmVkX2J1ZmZlcjxf VmFsdWU+IF9NX3N0b3JhZ2U7CiAKKyAgICAgIFtbX19nbnVfXzo6X19hbHdheXNfaW5saW5l X19dXQogICAgICAgX1ZhbHVlKgogICAgICAgX01fdmFscHRyKCkgbm9leGNlcHQKICAgICAg IHsgcmV0dXJuIF9NX3N0b3JhZ2UuX01fcHRyKCk7IH0KIAorICAgICAgW1tfX2dudV9fOjpf X2Fsd2F5c19pbmxpbmVfX11dCiAgICAgICBjb25zdCBfVmFsdWUqCiAgICAgICBfTV92YWxw dHIoKSBjb25zdCBub2V4Y2VwdAogICAgICAgeyByZXR1cm4gX01fc3RvcmFnZS5fTV9wdHIo KTsgfQogCisgICAgICBbW19fZ251X186Ol9fYWx3YXlzX2lubGluZV9fXV0KICAgICAgIF9W YWx1ZSYKICAgICAgIF9NX3YoKSBub2V4Y2VwdAogICAgICAgeyByZXR1cm4gKl9NX3ZhbHB0 cigpOyB9CiAKKyAgICAgIFtbX19nbnVfXzo6X19hbHdheXNfaW5saW5lX19dXQogICAgICAg Y29uc3QgX1ZhbHVlJgogICAgICAgX01fdigpIGNvbnN0IG5vZXhjZXB0CiAgICAgICB7IHJl dHVybiAqX01fdmFscHRyKCk7IH0KQEAgLTM3Miw3ICszNzYsNyBAQCBuYW1lc3BhY2UgX19k ZXRhaWwKICAgICA6IF9IYXNoX25vZGVfYmFzZQogICAgICwgX0hhc2hfbm9kZV92YWx1ZTxf VmFsdWUsIF9DYWNoZV9oYXNoX2NvZGU+CiAgICAgewotICAgICAgX0hhc2hfbm9kZSoKKyAg ICAgIGNvbnN0ZXhwciBfSGFzaF9ub2RlKgogICAgICAgX01fbmV4dCgpIGNvbnN0IG5vZXhj ZXB0CiAgICAgICB7IHJldHVybiBzdGF0aWNfY2FzdDxfSGFzaF9ub2RlKj4odGhpcy0+X01f bnh0KTsgfQogICAgIH07Cg== --------------SOJpupV01k2XUF0U4p7oqMx5--